The Arcive of Official vBulletin Modifications Site.

MajorFm.com · #32 12-31-2004, 05:07 PM

Nice hack... thanks...

KTBleeding · #33 12-31-2004, 07:16 PM

I have been looking for this hack..

[high]* KTBleeding will install when he gets off work.
[/high]

EDIT:

Installed and working fine! I'm so glad I found this hack.

[high]* KTBleeding clicks install[/high]

MajorFm.com · #34 01-07-2005, 02:10 PM

Im getting a error on uploading a avatar thats bigger then the dimentions set...

Fatal error: Call to undefined function: remote_filesize() in /usr/local/apache/www/crazyapes/majorfmforum.com/htdocs/forum/includes/functions_upload.php on line 106

magyosha · #35 01-23-2005, 06:38 PM

could not get this working at all
always says the image is to large and makes no attempt to resize ..
checked and double checked all the editing that was needed ... (tryed with profiles & atachments)
running vb 3.0.3 with the latest security fix's applied

attachments stored in the filesystem .. but would not think this would affect the profile pic as they are in the dbase .. and they don't work either ..

kall · #36 01-26-2005, 06:34 PM

Parse error: parse error, unexpected T_ELSE in /home3/nzboards/public_html/forums/includes/functions_upload.php on line 341

That's just trying to upload a gif larger than the dimensions. Same thing happens if I use jpg.

kall · #37 01-26-2005, 09:43 PM

Quote:

Originally Posted by mini2

Possibly a typo? Could you post that line and I can compare?

Line 341:

PHP Code:


			
else

Context - lines 321 to 362

PHP Code:


			
        if ($imginfo[2] != 1 AND $imginfo[2] != 2 AND $imginfo[2] != 3)

        { // .gif, .jpg, .png

            if ($showerrors)

            {

                @unlink($filename);

                if ($incp)

                {

                    print_stop_message('the_uploaded_file_is_not_valid');

                }

                else

                {

                    eval(print_standard_error('error_imagenotimage'));

                }

            }

            else

            {

                return false;

            }

        }

    }

    else

    {

        if (!$vboptions['allowimgsizefailure'])

        {

            if ($showerrors)

            {

                @unlink($filename);

                if ($incp)

                {

                    print_stop_message('the_uploaded_file_is_not_valid');

                }

                else

                {

                    eval(print_standard_error('error_imagenotimage'));

                }

            }

            else

            {

                return false;

            }

        }

    }

givemeplain · #38 02-06-2005, 05:10 PM

Hey, this works well for me .. but is there a way so that when an image is reduced in size, you can click on it (in post) to view it full size in a new window or something? Thanks.

MrNase · #39 02-23-2005, 07:22 PM

Quote:

Originally Posted by mini2

As an update I've completely removed this hack, thenreinstalled itusing the current uploaded files and it worked with 100%success foravatars and attachments. I tested large jpg, png and gifimagesfor the attachments, no errors, no problems. That's withvBulletin3.0.6.

Thank you very much. I updated because some members reported errors which I never got. I really hope these are resolved now

John_44 · #40 02-28-2005, 07:42 PM

Very nice Hack !
Unfortunatly it doesn´t work for me. No errors until i upload a larger Image -> Then it says Error 500 -> could not execute Script. I´m using the German Provider 1&1 and would apreciate every help possible.

(GD Lib is installed)

John_44 · #41 03-08-2005, 08:28 PM

No, it always hapens.

John_44 · #42 03-10-2005, 02:39 PM

Ok, i played around with it. Please notice that i know nothing about PHP, but i was able to track down the Problem:

If i change:

if ($width_factor > $height_factor)
{
$nw = round($w / $width_factor);
$nh = round($h / $width_factor);
}

to:

if ($width_factor > $height_factor)
{
$nw = 400 ;
$nh = round($h / $width_factor);
}

it works. 500,600,1000 -> Anything bigger 400 don?t.
I guess that for some reasons ImeageCreateTrueColor don?t like big numbers.. but i have no Ideas why.
The image i used was a Standart jpg with 1600*1200. Size played no role.

I would really apreciate your help on this topic, as i will definitly extend this genius hack !

What i want to add:
-Other extension (.jpeg,.jpe ...)
-File size

Does anybody know if GDlib can read EXIF Data ?

(Yes my English sucks

)

John_44 · #43 03-10-2005, 02:52 PM

Sorry. It works with 450 and 500. But 600 is to mutch. This makes me sick.

(And it is not "ImageCopyResampled". The following line works just fine:

ImageCopyResampled($ni,$im,0,0,0,0,1000,$nh,$w,$h) ; )

John_44 · #44 03-10-2005, 04:45 PM

If somebody else has the same Problem: As a workaround i use:

$width_factor = $w / 500;
$height_factor = $h / 500;
if ($width_factor > $height_factor)
{
$nw = round($w / $width_factor);
$nh = round($h / $width_factor);
}
else
{
$nw = round($w / $height_factor);
$nh = round($h / $height_factor);
}

$ni=imagecreatetruecolor($nw,$nh);
ImageCopyResampled($ni,$im,0,0,0,0,$nw,$nh,$w,$h);
UnsharpMask($ni);

John_44 · #45 03-10-2005, 07:43 PM

And i found a Bug: If more than one Image is resized, the script returns an error 500. However the first one is still uploaded.

Anybody else with this error ?

nosaj · #46 03-29-2005, 02:02 AM

thanks mini2, installed and working on my vBulletin Version 3.0.7 Forum. :classic:

LiewCF · #47 03-31-2005, 06:20 PM

Great! this hack work for my bloggers forum. There is other similar hack too, but it does not work.

Thank you!

JohnBee · #48 04-03-2005, 10:09 AM

I started to install this hack on 3.0.3
but in the functions_file.php I could not find the section that says:

Code:

@unlink($attachment);
eval('$error = "' . fetch_phrase('attachbaddimensions', PHRASETYPEID_ERROR) . '";');
$errors[] = array(
	'filename' => $attachment_name,
	'error' => $error...

is there another portion of code I should look for?

Blam Forumz · #49 04-18-2005, 09:00 PM

for attachments is it possible for them to be clikabkle?

Harley D · #50 04-25-2005, 01:32 AM

Quote:

Originally Posted by mini2

No idea on the darker image, I cant reproduce the problem.

I have a PHP Store that has pic resizing, and I've found that gif, jpegs, and pngs.... one of those will darken when resized. try changing the type of file and upload it to see how it renders after being resized.

Harley D · #51 04-25-2005, 01:37 AM

Quote:

Originally Posted by Hexemer

Hello,

first, thank you for this nice hack.

But, I have a Problem. :disappointed: The uploaded picture is "darker" than the original one.

attachment 1: original
attachment 2: uploaded in my forums

gd version: 2.0.12

Can you help me? :ermm:

I did some more checking and found that .JPG will darken but .GIF doesn't.
So use paint shop or photo shop to change from a JPG to GIF, this should solve this problem. If it does, please post so other will know if it works.

Razasharp · #52 05-07-2005, 12:25 AM

Excellent hack! *clicks install* Does exactly what is says on the tin :-)

Just a quick question tho, do the 'original' large files automatically get deleted off the server or do we have to do that manually?

Also a note for people using the attachment resizer, you have to 'increase' the sizes in your ACP to let the larger files get uploaded to then be resized. :-)

Razasharp · #53 05-18-2005, 11:28 PM

Sometimes the images shown (JPG) are a bit dark... anyway to get them lighter? :-/

Most users wont know how to conver to gif, so thats not any option really...

Bounce · #54 05-26-2005, 06:06 PM

Uploaded all as per instructions,doesn't seem to be working

Do you need safe mode turned off for this to work...

Uploaded the 2 hacks,no errors or anything but doesn't work :ermm:

Edit: Got the avatar hack working,slight problem same as another user, the pic is slightly darker

lionslair · #55 06-30-2005, 07:20 AM

Thanks for that wiked hack

kobescoresagain · #56 07-31-2005, 04:02 AM

anyone know if you can intergrate this into vb gallery?

kmike · #57 08-05-2005, 05:41 AM

Excellent hack.
I see a couple of small problems with it though:

it doesn't handle additional image types supported by getimagesize() PHP function, e.g. .SWF, .PSD, and .BMP. First two are probably non-issue, but our forum has .bmp attachments enabled, and this hack will generate an empty resized image for them
a huge image can cause "out of memory" PHP error on ImageCopyResampled() call, and the hack doesn't handle these situations (I think 500 errors cited in this thread are caused exactly by this - check your error logs for PHP errors)
the attachment file size stored in the db is wrong - the stored number is the size of original attachment, not the resized one. the total space occupied by member's attachments will be wrong, which may cause problems if attachment quotas are defined for usergroups
some memory could be freed during script execution by adding ImageDestroy() calls in the proper places
I think UnsharpMask() call is only needed if the attachthumbs option in admin CP set to "Yes - sharpen" (to be consistent with thumbnails handling)
there's no need to mess with "require_once('./includes/functions_image.php');" line at all. The file is only included once, if needed

I've fixed these problems, and also did some code cleanup.
You can uncomment error_log() lines and change email to your actual address to get some idea how this hack performs.

Code:

				// HACK: auto resize uploaded images
				switch ($imginfo[2])
				{
				case 1:
                			$im = ImageCreateFromGIF($attachment);
					break;
				case 2:
                			$im = ImageCreateFromJPEG($attachment);
					break;
				case 3:
                			$im = ImageCreateFromPNG($attachment);
					break;
				// no way to handle these image types
				default:
					// error_log("Couldn't resize $attachment ($filesize bytes)", 1, "email@yourdomain.net");
					@unlink($attachment);
					eval('$error = "' . fetch_phrase('attachbaddimensions', PHRASETYPEID_ERROR) . '";');
					$errors[] = array(
						'filename' => $attachment_name,
						'error' => $error
					);
					return false;
				}

				$w = $imginfo[0];
				$h = $imginfo[1];
				$width_factor = $w / $maxattachwidth;
				$height_factor = $h / $maxattachheight;
				if ($width_factor > $height_factor)
				{
					$nw = round($w / $wdth_factor);
					$nh = round($h / $wdth_factor);
				}
				else
				{
					$nw = round($w / $height_factor);
					$nh = round($h / $height_factor);
				}

				$ni = @ImageCreateTrueColor($nw, $nh);
				if ($ni OR !@ImageCopyResampled($ni, $im, 0, 0, 0, 0, $nw, $nh, $w, $h))
				{
					// failed to resize this image
					// error_log("Couldn't resize $attachment ${w}x${h} to ${nw}x${nh} ($filesize bytes)", 1, "email@yourdomain.net");
					@unlink($attachment);
					eval('$error = "' . fetch_phrase('attachbaddimensions', PHRASETYPEID_ERROR) . '";');
					$errors[] = array(
						'filename' => $attachment_name,
						'error' => $error
					);
					return false;
				}
				@ImageDestroy($im);
				if (PHP_VERSION != '4.3.2' AND $vboptions['attachthumbs'] == 2)
				{
					require_once('./includes/functions_image.php');
					UnsharpMask($ni);
				}
				switch ($imginfo[2])
				{
				case 1:
					@ImageGIF($ni, $attachment);
                			break;
				case 2:
					@ImageJPEG($ni, $attachment, 70);
					break;
				case 3:
					@ImagePNG($ni, $attachment);
					break;
				}
				@ImageDestroy($ni);
				$filesize1 = @filesize($attachment);
				// error_log("Resized $attachment ${w}x${h} to ${nw}x${nh} ($filesize to ${filesize1})", 1, "email@yourdomain.net");
				$filesize = $filesize1;
				// /HACK

mvigod · #58 08-08-2005, 12:41 AM

kmike,

nice fixes. has anyone tested this yet on 3.5 RC2?

thephonemall · #59 08-31-2005, 02:51 PM

I am getting this error when attempting the Profile Pic modification:

Fatal error: Call to undefined function: unsharpmask() in /home/website/forums/includes/functions_upload.php on line 294

EDIT:

Nevermind added
require_once('./includes/functions_image.php');
and it works!

MrNase · #60 10-25-2005, 12:39 PM

Can this one please be ported to vB3.5?

lazytown · #61 11-14-2005, 08:41 AM

A port to 3.5 would be VERY useful.

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.09251 seconds Memory Usage 2,516KB Queries Executed 45 (?)
More Information
Template Usage: (1)SHOWTHREAD (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (1)ad_showthread_beforeqr (2)bbcode_code (2)bbcode_php (4)bbcode_quote (1)footer (1)forumjump (1)forumrules (1)gobutton (1)header (1)headinclude (1)modsystem_post (1)navbar (6)navbar_link (120)option (1)pagenav (1)pagenav_curpage (2)pagenav_pagelink (31)post_thanks_box (31)post_thanks_button (1)post_thanks_javascript (1)post_thanks_navbar_search (31)post_thanks_postbit_info (30)postbit (31)postbit_onlinestatus (31)postbit_wrapper (1)spacer_close (1)spacer_open (1)tagbit_wrapper Phrase Groups Available: global inlinemod postbit posting reputationlevel showthread	Included Files: ./showthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/functions_bigthree.php ./includes/class_postbit.php ./includes/class_bbcode.php ./includes/functions_reputation.php ./includes/functions_post_thanks.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete showthread_start showthread_getinfo forumjump showthread_post_start showthread_query_postids showthread_query bbcode_fetch_tags bbcode_create showthread_postbit_create postbit_factory postbit_display_start post_thanks_function_post_thanks_off_start post_thanks_function_post_thanks_off_end post_thanks_function_fetch_thanks_start post_thanks_function_fetch_thanks_end post_thanks_function_thanked_already_start post_thanks_function_thanked_already_end fetch_musername postbit_imicons bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete postbit_display_complete post_thanks_function_can_thank_this_post_start pagenav_page pagenav_complete tag_fetchbit_complete forumrules navbits navbits_complete showthread_complete
Messages:

The Arcive of Official vBulletin Modifications Site.

It is not a VB3 engine, just a parsed copy!