The Arcive of Official vBulletin Modifications Site.It is not a VB3 engine, just a parsed copy! |
|
Comments |
#17
|
|||
|
|||
/me clicks install!
|
#18
|
|||
|
|||
Quote:
|
#19
|
||||
|
||||
Another great hack from the master..
Thank you.! |
#20
|
|||
|
|||
There is one major problem with this hack.
Permissions. If you have two forums: * An admin/mods forum * Public chit chat forum And you have an incident in the public forum... so you quote the incident in the private (registered users can't get there) forum... then this appears in that users Who Quoted Me? page. This should not be the case. Regardless of where the quote is made... whatever permissions apply to the forum that the thread the contains the quote is in, these should be applied to the Who Quoted Me? page. So... If user A cannot see the admin forum, then when user A is quoted in the admin forum user A should not see the thread in the Who Quoted Me? page. This was reported to me by a user who is on probation on our forum, and that should never have happened. Please issue an update. |
#21
|
|||
|
|||
There was a second problem too... it didn't cache the templates that were being used.
And a third problem... the queries were inefficient... 3 seperate queries! 2 of those in a loop. So if you had the default 20 quotes set, then you would perform 41 queries in total. Really no need for that. However, I shall give credit where it's due. The idea is brilliantly done and the database table is perfect No crude and no playing with vBulletin tables. Anyhow... could the hack author take a look at the version of whoquotedme.php I've attached and consider merging the changes into the one in your zip file. I've added the template caching. I've added the forum permissions logic. I've reduced the whole thing down to 1 database query. So on your average site it will only be 11 queries to generate the page and not 52. The file is attached, I'm sure others might also want to look and merge the differences. |
#22
|
||||
|
||||
Thanks for the quick fix..
Using this file until Gamingforce comes up with an "official" fixed release. |
#23
|
|||
|
|||
Also.. this was missed.
Code:
In includes/functions_online.php Find -------------------------------------- case 'bugs': $userinfo['action'] = construct_phrase($vbphrase['viewing_x'], 'Bugs'); // Don't report 'bugs' as needing to be translated please :p break; Add after -------------------------------- case 'whoquote': $userinfo['action'] = 'User Control Panel'; $userinfo['where'] = "<a href=\"$userinfo[location]\">Who Quoted $userinfo[username]</a>"; break; Find--------------------------------- case 'threadrate.php': $userinfo['activity'] = 'threadrate'; break; Add after ---------------------------------- case 'whoquotedme.php': $userinfo['activity'] = 'whoquote'; break; |
#24
|
|||
|
|||
in quotes.php , around line 195 you have:
Code:
eval('print_output("' . fetch_template(quote_listquote) . '");'); shoud be: Code:
eval('print_output("' . fetch_template('quote_listquote') . '");'); |
#25
|
||||
|
||||
Wow, very nice and usefull hack, easy to install and it works with MultiQuote
|
#26
|
||||
|
||||
*install*
Some TABLE_PREFIXES are needed for bbs using one. Oterwise a clean install. Probably, very handy! |
#27
|
|||
|
|||
I've been holding off installing this pending the next update (with fixes). Any idea as to the timeline?
It seems to have laid dormant for awhile now. |
#28
|
|||
|
|||
/me installs!
|
#29
|
||||
|
||||
great work
|
#30
|
||||
|
||||
Will this script work in 3.07? if yes, do I need to change anything since this was designed fro 3.03?
|
#31
|
|||
|
|||
Are all the corrections incorporated into this hack yet?
And if so... are they all contained in the initial zip file? |
|
|
X vBulletin 3.8.12 by vBS Debug Information | |
---|---|
|
|
More Information | |
Template Usage:
Phrase Groups Available:
|
Included Files:
Hooks Called:
|