New vbcode.js - vBcode and smilie user interface improvement

Hello vB Troopers,

With special permission from the Dev Team I am proud to release an improved version of vbcode.js. Any usage of this script other than in licensed vBulletin driven Boards is a direct violation of Jelsoft copyrights. Any violators will be prosecuted to the full extent of the law!

One MAJOR Improvement(note: only works with IE, NS users are out o luck! But who uses NS anyway?)

vBcode and smilies will be inserted wherever the cursor is instead of at the end of the text.

Installation
Copy the new vbcode.js file over your old one(see "Another small note" below). If you'd like to keep the old file just rename it before copying the new one.

You need to add the following text to the "message" textarea tag:

onChange=getActiveText(this) onclick=getActiveText(this)

It should basically look similiar to this:

<textarea name="message" rows="20" cols="$textareacols" wrap="virtual" tabindex="2" 
onChange=getActiveText(this) onclick=getActiveText(this) >$message</textarea>

Please note: The variable($message) may be different in some templates, editpost for example, so make sure to keep the original variable in the textarea attribute "name =". Otherwise the text may be missing in some instances.

This textarea can be found in the following templates:

Calendar Templates

calendar_enterevent

New Posting Templates

newreply

newthread

Private Messaging Templates

priv_forwardmultiple

priv_sendprivmsg

priv_sendtobuddies

and the editpost template

additional template changes

In the vbcode_popup_smilies template you must delete the following code:

<script language="JavaScript">
function smilie(smilietext) {
        opener.document.vbform.message.value += smilietext+" ";
        //opener.vbform.message.focus();
}
</script>

In the vbcode__popup_smiliebits template you must change:

<a href="javascript:smilie('$smilie[text]')">

to:

<a href="javascript:opener.smilie('$smilie[text]')">

small note:If you use the above code pleas omit the space between java and script.


If these changes aren't made the new script WILL NOT WORK!

I hope to hear from those who use it, and please let me know if you find a bug.


vB.org is using this hack. Try it out!

Scott

Latest release date: 20.04.2002
Any version older than this should be updated.

[Admin]

Then you are doing something wrong.

[TECK]

probably. i will double check. thanks.

[plcguru]

Hi,
Anybody know how to remove the space that gets inserted after the tag is closed?

for example, if you highlight a word and then click the bold button, a space is inserted after the tag automatically. I'd like to get rid of the space.

[plcguru]

Any ideas to get rid of the space? Please??

I tried modifying the vbcode.js file, but I give up as the space still remains. The hack works extremely well but that space...

[s.molinari]

Hello plcguru,

Since this feature wasn't actually programmed into the code (really! it just happens) I 'll have to look into how it even happens.

It may take a while though, cause I'm working hard on vB-germany.

Maybe someone else can take a shot at it.

Scott

[plcguru]

Originally posted by s.molinari
@FWC and Brain Cruz

Thanks for the info. I think I'll have to post a fix for this. The problem is, when the user doesn't wish to use the vB buttons or smilies we have calls to functions that don't exist. The actual vbcode.js isn't the problem but rather the calling of the functions.

Keep me posted if you here some more news and I'll try to see about adding the fix.
...snip....
Scott

Was there ever a fix for this? I installed in about 3 weeks ago and I'm starting to have users complain of javascript errors. If I re-enable the VBCode for them, the problem disappears just as has been posted earier.
Any fix?
(still a great hack... )
Thx,
Phil

[s.molinari]

Hello plcguru,

Sorry, I had fixed this in the vB-Germany thread but forgot to update you guys. Shame on me.

Here is the fix. I never tested it but a couple of German users told me it works like a charm so give it a try. If you have probs. let me know. Please read the note below too!

In the newthread template replace

onChange=getActiveText(this) onclick=getActiveText(this)

with

$jsinsert

Then search for the following code in newthread.php

PHP Code:

  if ($foruminfo[allowsmilies]) {
    if ($bbuserinfo[showvbcode] && $allowvbcodebuttons)
      $vbcode_smilies = getclickysmilies();
    eval("\$disablesmiliesoption = \"".gettemplate("newpost_disablesmiliesoption")."\";");
  } else {
    $disablesmiliesoption="";
  }
  if ($bbuserinfo[showvbcode] && $allowvbcodebuttons)
    $vbcode_buttons = getcodebuttons(); 


and replace it with:

PHP Code:

if ($foruminfo[allowsmilies]) {
    if ($bbuserinfo[showvbcode] && $allowvbcodebuttons)
      $vbcode_smilies = getclickysmilies();
      $jsinsert = "onChange=getActiveText(this) onclick=getActiveText(this)";
    eval("\$disablesmiliesoption = \"".gettemplate("newpost_disablesmiliesoption")."\";");
  } else {
    $disablesmiliesoption="";
    $jsinsert="";
  }
  if ($bbuserinfo[showvbcode] && $allowvbcodebuttons) {
    $vbcode_buttons = getcodebuttons();
    $jsinsert = "onChange=getActiveText(this) onclick=getActiveText(this)";
  }else{
    $jsinsert = "";
  } 


NOTE!Of course this will only fix the js errors for a new thread. You'll have to fix the other templates and scripts too. (i.e. for new replies and private messages) If someone could post the other templates and scripts here I would be very greatfull.

Scott

[plcguru]

Thanks Scott,
The fix worked fine

The php code also needs to be changed as you wrote(exactly the same) in editpost.php and newreply.php.
Then the template changes should also be done (exactly the same as you wrote) in the editpost template and newreply template.

This fixes the javascript errors.

Regarding the private message phps (private.php and private2.php) the code is different and I didn't want to mess with it (i.e. break it :ermm: ). So, I just removed the

onChange=getActiveText(this) onclick=getActiveText(this)

code from the following templates:

priv_forwardmultiple
priv_sendprivmsg
priv_sendtobuddies

Now users don't have the added convenience when sending PMs but at least they don't get an error. A reasonable trade I think.

Awesome hack ... one of my favorites! Danke

[Sinecure]

If I get a change I'll post the modifications to the rest of the templates. I can't get around to it today, I spent like 5 hours upgrading to 2.2.6

[plasir]

works 2.2.5 with 2.2.6 ?