Go Back   vb.org Archive > vBulletin Modifications > Archive > Modification Graveyard
FAQ Community Calendar Today's Posts Search

Reply
 
Thread Tools
OS/Browser Display in Postbits Details »»
OS/Browser Display in Postbits
Version: 1.0.6, by nhawk nhawk is offline
Developer Last Online: May 2021 Show Printable Version Email this Page

Category: Show Thread Enhancements - Version: 4.1.5 Rating:
Released: 03-29-2012 Last Update: 05-09-2012 Installs: 84
DB Changes Uses Plugins
Additional Files  
No support by the author.

No longer available on vB.org.

Show Your Support

  • This modification may not be copied, reproduced or published elsewhere without author's permission.
4 благодарности(ей) от:
Adrijan, DirtRider, Megaboost, MikeF

Comments
  #152  
Old 07-28-2012, 01:48 PM
nhawk nhawk is offline
 
Join Date: Jan 2011
Posts: 1,604
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by DirtRider View Post
nhawk on your forum it shows the Blackberry icon but when I installed it I see the ? unknown icon. Also nothing for Tapatalk at all just a blank.
I'm running the next version that hasn't been released yet.

The next time the person that isn't showing tapatalk is on, go to Who's Online and set 'User Agent' to 'Yes'. Then send me the useragent that isn't showing on your site.
Reply With Quote
  #153  
Old 08-03-2012, 08:51 AM
EliasAlucard's Avatar
EliasAlucard EliasAlucard is offline
 
Join Date: Nov 2009
Location: Sweden
Posts: 125
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Okay, I've installed vB 4.2 now, a few issues:

Android isn't supported when using Firefox; only the Firefox icon is shown, and the reason for that is because Firefox doesn't show the version number of Android. Here's the UA:

Mozilla/5.0 (Android; Mobile; rv:14.0) Gecko/14.0 Firefox/14.0.1

Using Konqueror:

Mozilla/5.0 (X11; Linux x86_64) KHTML/4.8.4 (like Gecko) Konqueror/4.8

It shows Konqueror as 4.8.4 but isn't that the KHTML version?

When using Chromium, it shows the Chrome icon. It's possible to show the Chromium, I've done this with my plugin. Here's the UA for Chromium:

Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/535.19 (KHTML, like Gecko) Ubuntu/12.04 Chromium/18.0.1025.168 Chrome/18.0.1025.168 Safari/535.19

Moreover, the Chrome icon is the old and outdated Chrome icon, in my opinion, it would look better if you used the updated 2011 Chrome icon. And the 2011 Chromium icon.

And then there's this bug that keeps deselecting all usergroups in admincp, so basically no one can see the icons. Not sure what's causing this. Maybe installation of new plugins or something. Shouldn't be like that though, because it's a pain in the ass to select all usergroups.

If you need to identify a user agent string, you should use this site:

http://id.furud.net/

And its database is most helpful:

http://id.furud.net/showdb.php

I would also prefer if you resized the icons to 24 pixels in height, it looks better than 19. You can use my icons, I even have customised versions of Android for each major release (ICS, Honeycomb, CyanogenMod etc.) and I also have more icons than you.
Reply With Quote
  #154  
Old 08-03-2012, 10:13 AM
nhawk nhawk is offline
 
Join Date: Jan 2011
Posts: 1,604
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by EliasAlucard View Post
Okay, I've installed vB 4.2 now, a few issues:

Android isn't supported when using Firefox; only the Firefox icon is shown, and the reason for that is because Firefox doesn't show the version number of Android. Here's the UA:

Mozilla/5.0 (Android; Mobile; rv:14.0) Gecko/14.0 Firefox/14.0.1

Using Konqueror:

Mozilla/5.0 (X11; Linux x86_64) KHTML/4.8.4 (like Gecko) Konqueror/4.8

It shows Konqueror as 4.8.4 but isn't that the KHTML version?

When using Chromium, it shows the Chrome icon. It's possible to show the Chromium, I've done this with my plugin. Here's the UA for Chromium:

Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/535.19 (KHTML, like Gecko) Ubuntu/12.04 Chromium/18.0.1025.168 Chrome/18.0.1025.168 Safari/535.19

Moreover, the Chrome icon is the old and outdated Chrome icon, in my opinion, it would look better if you used the updated 2011 Chrome icon. And the 2011 Chromium icon.

And then there's this bug that keeps deselecting all usergroups in admincp, so basically no one can see the icons. Not sure what's causing this. Maybe installation of new plugins or something. Shouldn't be like that though, because it's a pain in the ass to select all usergroups.

If you need to identify a user agent string, you should use this site:

http://id.furud.net/

And its database is most helpful:

http://id.furud.net/showdb.php

I would also prefer if you resized the icons to 24 pixels in height, it looks better than 19. You can use my icons, I even have customised versions of Android for each major release (ICS, Honeycomb, CyanogenMod etc.) and I also have more icons than you.
I'll look into the Android/Firefox combination for the next release.

KHTML is the heart of Konqueror so the versioning is correct.

I'll look into Chromium for the next release.

The Chrome icon IS the new one. Look closely at it.

I've always known where to check useragents, but I am not going to run through the thousands of useragents to accomodate obscure rarely used ones. If someone reports one that is in use and not displayed, I do my best to add it.

I have no intention of increasing the size of the icons. If you want to change them on your site, that's up to you.

And I'm going to try to be nice about this. Please stop referring to 'Your' plugin in this thread, it is off topic and irrelevant to vB 4.x in this thread. In my opinion it is not your plugin, but that's up to the people at vB.org to decide. And also, please stop attempting to educate me. I have been doing this type of work since the inception of the internet. If I don't already know something, I ask.

What that boils down to in your case is... if you don't like it, uninstall it.
Reply With Quote
  #155  
Old 08-03-2012, 10:54 AM
EliasAlucard's Avatar
EliasAlucard EliasAlucard is offline
 
Join Date: Nov 2009
Location: Sweden
Posts: 125
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by nhawk View Post
I'll look into the Android/Firefox combination for the next release.
Great.

Quote:
Originally Posted by nhawk View Post
KHTML is the heart of Konqueror so the versioning is correct.
Ok, I stand corrected then.

Quote:
Originally Posted by nhawk View Post
I'll look into Chromium for the next release.
Great.

Quote:
Originally Posted by nhawk View Post
The Chrome icon IS the new one. Look closely at it.
No it's not. It is as a matter of fact, the old Chrome icon. How could you possibly not have noticed this?

Quote:
Originally Posted by nhawk View Post
I've always known where to check useragents, but I am not going to run through the thousands of useragents to accomodate obscure rarely used ones. If someone reports one that is in use and not displayed, I do my best to add it.
I think you should. I've added support for various obscure browsers. On most forums, they're not needed because most people use the major browsers and operating systems, but on software forums for example, such obscure browsers are more common. I understand the extra work may not seem like it's worth it, but still, such plugins are all about perfection.

Quote:
Originally Posted by nhawk View Post
I have no intention of increasing the size of the icons. If you want to change them on your site, that's up to you.
I could do it easily, were it not for the browser-icon-sprites.png, this makes every icon a pain in the ass to change. Is it possible to ditch the browser-icon-sprites.png? It's not used in the other plugins of this kind.

Quote:
Originally Posted by nhawk View Post
And I'm going to try to be nice about this. Please stop referring to 'Your' plugin in this thread.
Why? Is there a rule here that one cannot discuss other similar plugins? I'm not promoting my plugin, I think yours is better but it does need some improvements.

Quote:
Originally Posted by nhawk View Post
In my opinion it is not your plugin, but that's up to the people at vB.org to decide. And also, please stop attempting to educate me. I have been doing this type of work since the inception of the internet. If I don't already know something, I ask.
What's with the attitude? I can play this game too: this isn't your plugin either, and you should also stop taking credit for it, because you've stolen most of the source code directly from Web Browser Identifier v0.9, which is licensed under the GPL, and so you're violating the GPL, yet you're acting like this plugin is all copyrighted. I have no problem acknowledging that I've modified Fighter's plugin and improved upon it a little, but most of these browser/os postbit icons share the same GPL source code. This one for example has much code in common with yours:

http://custom.simplemachines.org/mod...x.php?mod=1515

I also think I should educate you, since you didn't even notice it was the old Chrome icon you were using, which means your perception is less than impeccable.

Listen, I'm trying to help out here, and I don't like your condescending attitude. There are some things you don't know, such as the fact that you're using the old Chrome icon.

Quote:
Originally Posted by nhawk View Post
What that boils down to in your case is... if you don't like it, uninstall it.
No, I like it fine. Somehow you seem to think it doesn't need improvement, or you're simply not intellectually mature enough to understand constructive criticism (this is a common problem amongst many developers though, especially Linux developers).
Reply With Quote
  #156  
Old 08-03-2012, 11:18 AM
nhawk nhawk is offline
 
Join Date: Jan 2011
Posts: 1,604
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Ok, that's the end of this mod on vB.org.
Reply With Quote
  #157  
Old 08-03-2012, 11:23 AM
LouiseWilson LouiseWilson is offline
 
Join Date: Oct 2007
Posts: 154
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by nhawk View Post
Ok, that's the end of this mod on vB.org.
I wouldn't let 1 person discourage you, you have done some good work for vb mods , just ignore and move on in my opinion.
Reply With Quote
  #158  
Old 08-03-2012, 11:26 AM
EliasAlucard's Avatar
EliasAlucard EliasAlucard is offline
 
Join Date: Nov 2009
Location: Sweden
Posts: 125
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by nhawk View Post
Ok, that's the end of this mod on vB.org.
That's good, I think you did the right thing in removing it, because you're simply not doing a good job. I'll improve upon "your" stolen GPL source code and modify it properly, and I'll upload it later when it's done, and of course I'll add the GPL license which you didn't. If you can't handle criticism then don't bother uploading plugins in the first place.

Quote:
Originally Posted by LouiseWilson View Post
I wouldn't let 1 person discourage you, you have done some good work for vb mods , just ignore and move on in my opinion.
I'm not discouraging him. I was even trying to help him out, give him friendly advice, even recommended him using the icons I had spent time on resizing. I don't see how that's discouraging anything. The problem is that he has a childish and hostile mentality to any one giving him suggestions on what could be done to improve things. He could have just added two different sizes in icons, for example.

Also, it's quite pointless to remove the plugin from vbulletin.org especially when it has been downloaded 403 times, which means that someone will upload it somewhere else, if not here, then on rapidshare or similar sites. I think nhawk is behaving like a control freak over this. It's just a plugin for crying out loud.
Reply With Quote
  #159  
Old 08-03-2012, 11:39 AM
nhawk nhawk is offline
 
Join Date: Jan 2011
Posts: 1,604
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by EliasAlucard View Post
That's good, I think you did the right thing in removing it, because you're simply not doing a good job. I'll improve upon "your" stolen GPL source code and modify it properly, and I'll upload it later when it's done, and of course I'll add the GPL license which you didn't. If you can't handle criticism then don't bother uploading plugins in the first place.
I never claimed it was all mine. As a matter of fact...
http://snogssite.com/showthread.php?...fo-in-postbits

I don't mind suggestions, but in my opinion the level you took it to should have been done via a private discussion.

If you don't understand what the sprites are for, try looking into them. They are a good thing.

But, it's no sweat off my back. Either way, have fun.
Reply With Quote
  #160  
Old 08-03-2012, 12:03 PM
EliasAlucard's Avatar
EliasAlucard EliasAlucard is offline
 
Join Date: Nov 2009
Location: Sweden
Posts: 125
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by nhawk View Post
I never claimed it was all mine. As a matter of fact...
http://snogssite.com/showthread.php?...fo-in-postbits
If it's not all yours, then why did you act so proprietary over it when I suggested that I fork it?

Quote:
Originally Posted by nhawk View Post
I don't mind suggestions, but in my opinion the level you took it to should have been done via a private discussion.
I don't see the need for that, it's better discussed here so that everyone can see.

Quote:
Originally Posted by nhawk View Post
If you don't understand what the sprites are for, try looking into them. They are a good thing.
Are the sprites really needed? Like I said, the Simple Machines version doesn't use the CSS sprites, and it's working just fine.

Quote:
Originally Posted by nhawk View Post
But, it's no sweat off my back. Either way, have fun.
I still think your behaviour is immature and childish. It's like, 'don't tell me what to do, don't talk to me that way, or else I'll take it down!!!!!', which is lame, and your 'don't educate me' reeks of a big ego who can't handle friendly suggestions. Chill dude, I'm just giving my two cents so that you can improve a good plugin.
Reply With Quote
  #161  
Old 08-03-2012, 12:26 PM
nhawk nhawk is offline
 
Join Date: Jan 2011
Posts: 1,604
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Discussions are one thing, but the way you present information is like your way is the best and/or the only good way. That is not conducive to friendly discussions. And is what has resulted in me pulling this mod from vB.org. I've been around too long to put up with someone telling me that their way is better without presenting it in a civil manner and accepting my decision on if something happens or doesn't happen. Remember, the coder always has the final say no matter how much you disagree with them.

So far as sprites go, just about every page speed test around recomends using them. vBulletin itself uses them for a few things. Look into them, they are a good thing.
Reply With Quote
Reply


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT. The time now is 12:51 AM.


Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2024, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.08750 seconds
  • Memory Usage 2,351KB
  • Queries Executed 25 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)ad_showthread_beforeqr
  • (19)bbcode_quote
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)modsystem_post
  • (1)navbar
  • (4)navbar_link
  • (120)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (3)pagenav_pagelink
  • (1)pagenav_pagelinkrel
  • (11)post_thanks_box
  • (4)post_thanks_box_bit
  • (11)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit
  • (11)post_thanks_postbit_info
  • (10)postbit
  • (11)postbit_onlinestatus
  • (11)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available:
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files:
  • ./showthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • forumjump
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • fetch_musername
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • post_thanks_function_fetch_thanks_bit_start
  • post_thanks_function_show_thanks_date_start
  • post_thanks_function_show_thanks_date_end
  • post_thanks_function_fetch_thanks_bit_end
  • post_thanks_function_fetch_post_thanks_template_start
  • post_thanks_function_fetch_post_thanks_template_end
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • pagenav_page
  • pagenav_complete
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • showthread_complete