The Arcive of Official vBulletin Modifications Site.

[VB3 RC3] Attachments in private messages · **Released**: 01-06-2004

Unsupported. VB3.5 version is here:
https://vborg.vbsupport.ru/showthread.php?t=91220

Tested on 3.0.3

This hack enables you to send attachments in a private message. This feature was really useful to me in vb2 and I kind of missed it on vb3 so I rehacked it myself.

When a user writes a private message they will be given the option to add an attachment, the same as when writing a post. It uses the same rules you have defined for a convencional attachment including file types, quotas, etc. It is only an extension for attachments to be used in private messages.

As always it is advised to backup your files before hacking in case you want to go back, this is some big hack including modification of multiple files, some templates and adding two extra columns in the database tables.

Instructions are provided in the txt, and some screenshots on where the attachment option appears.

Info for hackers:
You may modify, improve, upgrade, redistribute this hack, include it
in another hack or yours or translate it provided you do it free of
charge and you distribute it in www.vbulletin.org at least, there is no
need to pm me asking for permission
Some portions of the code are (c) Jelsoft Enterprises Ltd.

Edit by MarcoH64:
Because of multiple requests to make this hack work on vB3.0.7 i created upgrade instructions. These upgrade instructions can be followed after the original instructions (the 3.0.3 version). The original coder can not be held responsible for my modification.

RobinHood · #**212** 09-14-2004, 02:34 AM

Quote:

Originally Posted by Weasel

I'm having problems with your code RobinHood, it seems to break the permissions of normal attachments, i.e. no one can view them now.

Okay, try this:

Change:

PHP Code:


			
if (!($forumperms & CANGETATTACHMENT)) 

{ 

    $vboptions['viewattachedimages'] = 0; 

    $vboptions['attachthumbs'] = 0; 

}

To:

PHP Code:


			
if (!($forumperms & CANVIEW) OR !($forumperms & CANGETATTACHMENT)) 

{ 

    $vboptions['viewattachedimages'] = 0; 

    $vboptions['attachthumbs'] = 0; 

}

That should do the trick. Let me know how it goes.

BamaStangGuy · #**213** 09-14-2004, 05:08 AM

Quote:

Originally Posted by RobinHood

Okay, try this:

Change:

PHP Code:


			
if (!($forumperms & CANGETATTACHMENT)) 

{ 

    $vboptions['viewattachedimages'] = 0; 

    $vboptions['attachthumbs'] = 0; 

}

To:

PHP Code:


			
if (!($forumperms & CANVIEW) OR !($forumperms & CANGETATTACHMENT)) 

{ 

    $vboptions['viewattachedimages'] = 0; 

    $vboptions['attachthumbs'] = 0; 

}

That should do the trick. Let me know how it goes.

all my thumbnails are red x's and I get a no permisson

I have done what you said to do above and it still doesnt work

BamaStangGuy · #**214** 09-14-2004, 05:12 AM

Something I just realized

It breaks all the thumbnails and images that were uploaded before the pm hack was installed. But if I upload a new image on the forum it works fine.

Basically all my old attachments show up as red x's and give a no permission when clicked.

But if I add a new attachment to a thread then it works fine

BamaStangGuy · #**215** 09-14-2004, 05:57 AM

Quote:

Code:

if (!($forumperms & CANGETATTACHMENT)) 
{ 
    $vboptions['viewattachedimages'] = 0; 
    $vboptions['attachthumbs'] = 0; 
} 

// check if there is a forum password and if so, ensure the user has it set 
    verify_forum_password($attachmentinfo['forumid'], $attachmentinfo['password']); 

$pmUsers = $DB_site->query_first("SELECT toUserArray FROM ".TABLE_PREFIX."pmtext WHERE pmtextid='".$attachmentinfo['private']."'"); 
    $toUserArray = unserialize($pmUsers['toUserArray']);          
    if ($toUserArray[$bbuserinfo['userid']] != $bbuserinfo['username'] && $attachmentinfo['userid'] != $bbuserinfo['userid']) { 
            print_no_permission();         
           }

It works fine until I had this part. Id di it in steps. Aded the first uploaded images showed. Added the second part images still showed. When I added the above part the images broke.

It still does it with what you posted in your lsat post as well

Weasel · #**216** 09-14-2004, 10:38 AM

Yea same here, it breaks all previously uploaded attechments to the forum (thumbs and permissions to view).

Saphrym · #**217** 09-14-2004, 05:49 PM

Quote:

Originally Posted by Weasel

Yea same here, it breaks all previously uploaded attechments to the forum (thumbs and permissions to view).

Ok. Got this thing to work right in 3.0.3. I spent some time trying to figure out exactly what was trying to be done with the edits, and figured out how to do it.

Start with a fresh attachment.php (or one without the modifications for pms)

Find:

PHP Code:


			
attachment.visible, mimetype, NOT ISNULL(deletionlog.primaryid) AS isdeleted,

        thread.forumid, forum.password, thread.threadid

Change to: (Purpose: Adds private as an option variable)

PHP Code:


			
attachment.visible, mimetype, NOT ISNULL(deletionlog.primaryid) AS isdeleted,

        thread.forumid, forum.password, thread.threadid, private

Find:

PHP Code:


			
if ($attachment['postid'] == 0 AND $bbuserinfo['userid'] == $attachmentinfo['userid'])

Add Above: (Purpose: Starts an if/then statement that if it's not a private message attachment do things like normal)

PHP Code:


			
if (!$attachmentinfo['private']) {

Find:

PHP Code:


			
    // check if there is a forum password and if so, ensure the user has it set

    verify_forum_password($attachmentinfo['forumid'], $attachmentinfo['password']);



    if (!$attachmentinfo['visible'] AND !can_moderate($attachmentinfo['forumid'], 'canmoderateattachments') AND $attachmentinfo['userid'] != $bbuserinfo['userid'])

    {

        $idname = 'attachment';

        eval(print_standard_error('error_invalidid'));

    }

}

Add Below: (Purpose: Ends the if/then statement and adds what to do if it IS a private message attachment.)

PHP Code:


			
} else {

    $pmUsers = $DB_site->query_first("SELECT toUserArray FROM ".TABLE_PREFIX."pmtext WHERE pmtextid='".$attachmentinfo['private']."'");

    $toUserArray = unserialize($pmUsers['toUserArray']);         

    if ($toUserArray[$bbuserinfo['userid']] != $bbuserinfo['username'] && $attachmentinfo['userid'] != $bbuserinfo['userid']) {

            print_no_permission();        

           }

}

I've tested it with different users until I got the code working properly for both regular attachments and pm attachments. So this should work fine for those of you using 3.0.3.

Hope this helps.

BamaStangGuy · #**218** 09-14-2004, 06:02 PM

It worked!!!

Thanks

Weasel · #**219** 09-14-2004, 09:16 PM

Good job, the simplest solution is always the best, huh?

RobinHood · #**220** 09-18-2004, 09:46 PM

Quote:

Originally Posted by Weasel

Good job, the simplest solution is always the best, huh?

Is it just me or is there something wrong with the script? Why does it kept deleting the attachments right after a few hours or so???

AZone · #**221** 09-19-2004, 06:23 PM

I am sorry, but can someone summarize all the steps I need to do to get it work? Or does the file in the first post contain complete solution?
Thank you.

Weasel · #**222** 09-20-2004, 05:32 PM

Quote:

Originally Posted by RobinHood

Is it just me or is there something wrong with the script? Why does it kept deleting the attachments right after a few hours or so???

Hmm, you're right. It must be a problem in the cleanup cron. :disappointed:

beano33 · #**223** 09-20-2004, 09:40 PM

Quote:

Originally Posted by AZone

I am sorry, but can someone summarize all the steps I need to do to get it work? Or does the file in the first post contain complete solution?
Thank you.

I'd appreciate that too. A re-release for vBulletin Version 3.0.3 is what's needed.

Mattius · #**224** 09-22-2004, 04:05 AM

the same problem occurs with the attachments for calendar hack. the same missing $postid code etc...

Ive posted a message there as well

theArchitect · #**225** 09-22-2004, 11:48 PM

This Hack concept sounds sensational. But I am having a problem with the install. I have got down to the section where I need to modify the attachment.php file and I have been asked to find:

PHP Code:


			
$postid = verify_id('post', $attachmentinfo['postid']);

But I can't find this code anywhere. I initially thought it was due to another hack I had installed. But I have checked the original vB 3.0.3 file and it isn't there either. Nor is the next line of code:

PHP Code:


			
verify_forum_password($foruminfo['forumid'], $foruminfo['password']);

Assistance would be most appreciated.

Mattius · #**226** 09-23-2004, 06:42 AM

Many others are in the same boat

Its not in the 3.0.3 code, this current hack is designed for 3.0.0 and 3.0.1...but with relatively small changes you should be able to get it too work in 3.0.3.

The problem gets worse when your trying to implement the calendar hack as well because modify identical bits of code, which i sort of had working apart from the fact the attachment disappears after a while

...a couple others have had the same problem here...Im using 3.0.3.

We really need a genius to come along and sort it all out for us. Unfortunately im not that genius

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.06075 seconds Memory Usage 2,394KB Queries Executed 30 (?)
More Information
Template Usage: (1)SHOWTHREAD (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (1)ad_showthread_beforeqr (1)bbcode_code (12)bbcode_php (7)bbcode_quote (1)footer (1)forumjump (1)forumrules (1)gobutton (1)header (1)headinclude (1)modsystem_post (1)navbar (6)navbar_link (120)option (1)pagenav (1)pagenav_curpage (4)pagenav_pagelink (1)pagenav_pagelinkrel (16)post_thanks_box (16)post_thanks_button (1)post_thanks_javascript (1)post_thanks_navbar_search (16)post_thanks_postbit_info (15)postbit (16)postbit_onlinestatus (16)postbit_wrapper (1)spacer_close (1)spacer_open (1)tagbit_wrapper Phrase Groups Available: global inlinemod postbit posting reputationlevel showthread	Included Files: ./showthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/functions_bigthree.php ./includes/class_postbit.php ./includes/class_bbcode.php ./includes/functions_reputation.php ./includes/functions_post_thanks.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete showthread_start showthread_getinfo forumjump showthread_post_start showthread_query_postids showthread_query bbcode_fetch_tags bbcode_create showthread_postbit_create postbit_factory postbit_display_start post_thanks_function_post_thanks_off_start post_thanks_function_post_thanks_off_end post_thanks_function_fetch_thanks_start post_thanks_function_fetch_thanks_end post_thanks_function_thanked_already_start post_thanks_function_thanked_already_end fetch_musername postbit_imicons bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete postbit_display_complete post_thanks_function_can_thank_this_post_start pagenav_page pagenav_complete tag_fetchbit_complete forumrules navbits navbits_complete showthread_complete
Messages:

The Arcive of Official vBulletin Modifications Site.

It is not a VB3 engine, just a parsed copy!