Optimizing Forumhome

Ok, what this Hack does is it reduces the ammount of queries on forumhome by caching the moderatorlist and by optimizing most of the queries used on index.php


I'd really appreciate getting feedback how it reduces serverload on greater boards

On an unhacked vb index.php (pm enabled accesmask disabled) it reduces the ammount of queries from 19 to 15
my experiments have shown, that the queries are faster than the normal ones, too....

[Xenon]

sorry, have overread it nuno.

have you done the last step and edited a forum (save without any changes?)

[nuno]

Yes.
Just go to ACP and save any forum right?
Did that, all mods are gone.
Guess i'll just have to redo the whole install from the start.

[Xenon]

yes, it should work have tested it on two boards right now, and everything works

the jumping point for the mods part is the modified forum.php if you have forgotten just one line your bug could appear

just check in the db if the fields are filles

[nuno]

Originally posted by Xenon
yes, it should work have tested it on two boards right now, and everything works

the jumping point for the mods part is the modified forum.php if you have forgotten just one line your bug could appear

just check in the db if the fields are filles

Thank you Xenon, that did it.

[Seby]

I have the "user online today" hack installed and that cause not being able to install the hack. even when I remove it I cant do teh find/replace stuff cause my lines are different, I'll be bugging you on icq xenon, maybe you can help me

[Xenon]

i haven't time for private requests!

remove the hack and apply my part or just leave that part out..

@nuno: you're welcome

[Xenon]

little upgrade.
the pm queries had a bug, just replace the old pm code with the new one

[Xyphen]

Did this on vB2.3.0 and worked fine, dropped about 3 queries I belive or maybe more.

My forum is hacked badly -_-.

Result: Page generated in 0.25047302 seconds (53.65% PHP - 46.35% MySQL) with 55 queries.

Result Before: Page generated in 0.25559199 seconds (53.88% PHP - 46.12% MySQL) with 58 queries.

[Xenon]

wow, good server if it's that fast with 55 queries

but i think you should optimize index.php more than just with my hack

[erdem]

hi xenon ...

i just want to remove moderator querys from index ...
i have to do these

PHP Code:

remove:
$imodcache = array();
$mod = array();
$forummoderators=$DB_site->query('SELECT user.userid,user.username,moderator.forumid
                                  FROM moderator
                                  LEFT JOIN user
                                    ON (moderator.userid=user.userid)
                                  ORDER BY user.username');
while ($moderator=$DB_site->fetch_array($forummoderators)) {
  $imodcache["$moderator[forumid]"][] = $moderator;
  $mod["$moderator[userid]"] = 1;
}
$DB_site->free_result($forummoderators);
unset($moderator); 


PHP Code:

find:
        $listexploded=explode(",", $forum['parentlist']);
        while ( list($mkey1,$mval1)=each($listexploded) ) {
          if ( !isset($imodcache["$mval1"]) ) {
            continue;
          }
          reset($imodcache["$mval1"]);
          while ( list($mkey2,$moderator)=each($imodcache["$mval1"]) ) {
            if ( !isset($forum['moderators']) ) {
              eval("\$forum['moderators'] = \"".gettemplate('forumhome_moderator')."\";");
            } else {
              eval("\$forum['moderators'] .= \", ".gettemplate('forumhome_moderator')."\";");
            }
          }
        }

        if ( !isset($forum['moderators']) ) {
          $forum['moderators'] = ' ';
        }

replace with:
        eval("\$forum[moderators] = \"".addslashes($forum[moderators])."\";"); 


right ?

also this wont cause any problem right ? like update problem or so ?
Thanks

[Xenon]

yes right

it won't hurt anymore then
you shouldn't have any upgrade problems, AFAIK Erwin has removed that col long time ago already and didn't get in trouble..

nevertheless if you just remove the mod query and don't install the mod thing into forum.php (of my file) and also don't improve the whos' online on forumhome queries with my hacking advices, mods wouldn't be highlighted anymore (just supermods and admins would..)

[erdem]

is that means after removing moderator querys from index.php , i have to apply other querys to other files ?

a little confused ...

[Xenon]

no, no other files are affected

hmm, maybe i've posted a bit complicated.

There is the online now feature on forumhome right?
and if you have enabled the moderatorhighlightin, all your online mods show up bold.
if you remove the mod query above and do not change the part which generates the current online users, all normal mods wouldn't be bold anymore

[Xyphen]

Originally posted by Xenon
wow, good server if it's that fast with 55 queries

but i think you should optimize index.php more than just with my hack

Now the result is 'Page generated in 0.26656604 seconds (43.08% PHP - 56.92% MySQL) with 50 queries.' Since I turned off the vBportal left colum display.

One question, how can I optimize it even more? :knockedout:

[Xenon]

well i don't know without knowing your index.php

you can look into my way to combine some queries and try if you can do so yourself on other queries