Add-On Releases - Rewrite eBay To ShoppingAds

Rewrite eBay To ShoppingAds

*** Please be aware that a member has had his ShoppingAds account deactivated through the use of this modification. (See https://vborg.vbsupport.ru/showpost....&postcount=113) ***

Description:
Adds ShoppingAds prefix to posted eBay links.

Request:
https://vborg.vbsupport.ru/showthread.php?t=144207

Installation:
All the installation information is in the package.

Changes:
2 Plugins
1 File

[Dismounted]

The modification should work on everything that uses the vBulletin BB Code Parser. vBAdvanced may cache data that has already been parsed, so you may have to wait for the cache to expire or clear the cache for the modification to come into effect.

[ludachris]

Originally Posted by Dismounted

The modification should work on everything that uses the vBulletin BB Code Parser. vBAdvanced may cache data that has already been parsed, so you may have to wait for the cache to expire or clear the cache for the modification to come into effect.

So if I have an RSS feed set up on a vBa page, the links should be rewritten? It doesn't seem to be working that way. Could it be because I have it set up as a php module? I tried changing it to a template module and that didn't seem to do it.

[Dismounted]

My guess is that the RSS feed is not passed through the vBulletin BB code parser (with good reason, RSS feed content is in HTML). The links wouldn't be rewritten in this case.

[ludachris]

Originally Posted by Dismounted

My guess is that the RSS feed is not passed through the vBulletin BB code parser (with good reason, RSS feed content is in HTML). The links wouldn't be rewritten in this case.

Anyway you can think of that I could rig it to work? Would it even be possible to write a hack that would make it work? Maybe I'll attempt my first hack... for example, could I create a custom vb page/script as described here:
https://vborg.vbsupport.ru/showthread.php?t=98009

and then apply an htaccess file for that page to do a rewrite? Or might there be an easier way? Thanks for the replies.

[Dismounted]

Originally Posted by ludachris

Anyway you can think of that I could rig it to work? Would it even be possible to write a hack that would make it work?

It's possible, but not without some major changes how the RSS feed is imported. (Is there an option to turn the RSS feed's HTML into BB code? vBulletin allows this in its RSS feed manager, I'm not sure about vBAdvanced.)

Originally Posted by ludachris

Maybe I'll attempt my first hack... for example, could I create a custom vb page/script as described here:
https://vborg.vbsupport.ru/showthread.php?t=98009

and then apply an htaccess file for that page to do a rewrite? Or might there be an easier way? Thanks for the replies.

That would not work. You are looking to modify the display of the URLs (what this modification does), not URLs hitting your server (this is what mod_rewrite does).

[ludachris]

Thanks for the replies. This goes beyond the realm of your hack so I'll not take it anymore off topic. Maybe I'll just post a request if I can't figure it out. Thanks again for answering my questions.

[Reece^B]

Using this mod, love it.

But I get an error each time someone clicks a active link:

This Listing Is Unavailable

This listing () has been removed or is no longer available. Please make sure you entered the right item number.
If the listing was removed by eBay, consider it cancelled. Note: Listings that have ended more than 90 days ago will no longer appear on eBay.

[Paul M]

There is a bug in this, which sometimes screws up the generated url (giving the above error).

To fix it I added a line in functions_rewrite_ebay_auctionads.php

I changed this ;

	// encode URL
	$encodedlink = urlencode($rightlink);

To this ;

	// encode URL
	$encodedlink = urlencode($rightlink);
	$encodedlink = str_replace('%26amp%3B','&',$encodedlink); // Paul M Fix, 04/02/2009

[Dismounted]

That error occurs when the encoding "doubles up". (I remember I fixed this, but it seems not.)

[DieselMinded]

Is this going to be updated for vb 3.8+