Go Back   vb.org Archive > vBulletin Modifications > Archive > vB.org Archives > Premium Archives > Advanced Warning System (AWS)
Private Messaging Cut-off bug Details »»
Private Messaging Cut-off bug
Version: , by Tom1234 Tom1234 is offline
Developer Last Online: Jan 2015 Show Printable Version Email this Page

Version: Unknown Rating:
Released: 04-26-2005 Last Update: Never Installs: 0
 
No support by the author.

Even though I have "Private Messaging Cut-off Limit" set to 0, I am seeing this statement in warning PMs:

"Please note that your Private Messaging system in our Forums has been deactivated, due to your Warning Level."

Show Your Support

  • This modification may not be copied, reproduced or published elsewhere without author's permission.

Comments
  #2  
Old 04-26-2005, 07:16 PM
sv1cec sv1cec is offline
 
Join Date: May 2004
Location: Athens, Greece
Posts: 2,091
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by Tom1234
Even though I have "Private Messaging Cut-off Limit" set to 0, I am seeing this statement in warning PMs:

"Please note that your Private Messaging system in our Forums has been deactivated, due to your Warning Level."
Yeap, in your functions_warning.php find:

PHP Code:
if($vboptions['warn_send_pm_warning']==AND $level $vboptions['warn_pmcutoff']) 
Replace that with:

PHP Code:
if($vboptions['warn_send_pm_warning']==AND $level $vboptions['warn_pmcutoff'] AND $vboptions['warn_pmcutoff']>0
Also in the same file find:

PHP Code:
if($vboptions['warn_send_em_warning']==OR ($level >= $vboptions['warn_pmcutoff']} 
Replace that with:

PHP Code:
if($vboptions['warn_send_em_warning']==OR ($level >= $vboptions['warn_pmcutoff'] AND $vboptions['warn_pmcutoff']>0)) 
Didn't try these, but they should work. Somehow I didn't take into consideration, that you could set that to zero, stupid me.

Rgds
  #3  
Old 04-26-2005, 08:29 PM
Tom1234 Tom1234 is offline
 
Join Date: Sep 2003
Posts: 90
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

There is a comment in the form that implies you should set it to zero to de-activate it, so I didn't think that would be rare:

"If you set this number to anything but 0,..."

Should I be concerned along the same lines about the avatar and signature cut-off limit? I have them set to zero also.
  #4  
Old 04-26-2005, 08:34 PM
sv1cec sv1cec is offline
 
Join Date: May 2004
Location: Athens, Greece
Posts: 2,091
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

LoL, not you, I was concerned, that I haven't done something stupid in the other places as well. You were right, to set it to zero, it's just that when I made the code, which adds that remark at the end of the PM or email, I didn't bother checking for zero value, I just checked if the warnings lever was higher than the cut-off limit.

No the rest of the code is correct, I checked!!

Rgds
  #5  
Old 04-28-2005, 10:50 AM
kmike kmike is offline
 
Join Date: Oct 2002
Posts: 169
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

This has caused the absence of PMs about warning in 3.4.7 when PM cutoff is zero.
When I change this line:
Code:
	if($vboptions['warn_send_pm_warning']==1 AND $level < $vboptions['warn_pmcutoff'] AND $vboptions['warn_pmcutoff']>0)
to the v3.4.6's:
Code:
	if($vboptions['warn_send_pm_warning']==1)
in includes/functions_warning.php, all works as expected.
  #6  
Old 04-28-2005, 12:31 PM
sv1cec sv1cec is offline
 
Join Date: May 2004
Location: Athens, Greece
Posts: 2,091
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Yes, but you are not covering the case, when a user is receiving a warning while being above the pm cutoff limit. He can't see the warning PM in this case, that's why in the laterst versions, whoever is above the cutoff limit, gets an e-mail, instead of a PM.
  #7  
Old 04-28-2005, 01:13 PM
kmike kmike is offline
 
Join Date: Oct 2002
Posts: 169
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

But new code simply doesn't send any PMs when "PM cutoff" is zero and user already has some warnings, because $level is always greater than $vboptions['warn_pmcutoff'] in this case.
  #8  
Old 04-28-2005, 08:25 PM
sv1cec sv1cec is offline
 
Join Date: May 2004
Location: Athens, Greece
Posts: 2,091
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

You are right, the conditional should be changed to :

PHP Code:
    if (($vboptions['warn_send_pm_warning']==AND $vboptions['warn_pmcutoff']==0) OR (($vboptions['warn_send_pm_warning']==AND $vboptions['warn_pmcutoff']!=AND $level $vboptions['warn_pmcutoff'])) 
I'll change it in the next release, asap.

Rgds and tnx
  #9  
Old 04-28-2005, 10:00 PM
Tom1234 Tom1234 is offline
 
Join Date: Sep 2003
Posts: 90
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Is this fixed in 3.4.8 or the next release after that?
  #10  
Old 04-29-2005, 02:48 PM
sv1cec sv1cec is offline
 
Join Date: May 2004
Location: Athens, Greece
Posts: 2,091
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

No, got it fixed in 3.4.8.

Rgds and sorry for the inconvenience.
Closed Thread

Thread Tools

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT. The time now is 09:22 AM.


Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2024, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.05958 seconds
  • Memory Usage 2,288KB
  • Queries Executed 23 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)ad_showthread_beforeqr
  • (2)bbcode_code
  • (5)bbcode_php
  • (1)bbcode_quote
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)modsystem_post
  • (1)navbar
  • (6)navbar_link
  • (120)option
  • (10)post_thanks_box
  • (10)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (10)post_thanks_postbit_info
  • (9)postbit
  • (10)postbit_onlinestatus
  • (10)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available:
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files:
  • ./showthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • forumjump
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • showthread_complete