Go Back   vb.org Archive > vBulletin Modifications > Archive > vB.org Archives > Premium Archives > Advanced Warning System (AWS)
Problem With Private.php Details »»
Problem With Private.php
Version: , by j_86 j_86 is offline
Developer Last Online: Jan 2013 Show Printable Version Email this Page

Version: Unknown Rating:
Released: 04-22-2005 Last Update: Never Installs: 0
 
No support by the author.

Hi.

When performing the 3.4.4 to 3.4.5 upgrade, after one of these edits:

PHP Code:
// set up for PM reply / forward
        
if ($_REQUEST['pmid'])
        {
            if (
$pm $DB_site->query_first("
                SELECT pm.*, pmtext.*
                FROM " 
TABLE_PREFIX "pm AS pm
                LEFT JOIN " 
TABLE_PREFIX "pmtext AS pmtext ON(pmtext.pmtextid = pm.pmtextid)
                WHERE pm.userid=
$bbuserinfo[userid] AND pm.pmid=" intval($_REQUEST['pmid']) . "
            "
))
            {
            
Right below thatadd:

            if (
$bbuserinfo['userid'] == $vboptions['warn_collector'])
                {
                    
$dualid=1;
                    
$dual_option='';
                    
$dual_option.="<option value='{$bbuserinfo['userid']}'>User name: {$bbuserinfo['username']} - User ID: {$bbuserinfo['userid']} (your own)</option>";
                    if (
$vboptions['warn_warner']!='')
                    {
                        
$w1=$DB_site->query_first("SELECT username FROM " TABLE_PREFIX "user WHERE userid=$vboptions[warn_warner]");
                        
$dual_option.="<option value='{$vboptions['warn_warner']}'>User name: {$w1['username']} - User ID: {$vboptions['warn_warner']} (Hidden Warner)</option>";
                    }
                    if (
$vboptions['warn_automatic_warner']!='')
                    {
                        
$w1=$DB_site->query_first("SELECT username FROM " TABLE_PREFIX "user WHERE userid=$vboptions[warn_automatic_warner]");
                        
$dual_option.="<option value='{$vboptions['warn_automatic_warner']}'>User name: {$w1['username']} - User ID: {$vboptions['warn_automatic_warner']} (Automatic Warner)</option>";
                    }
                }
                else
                {
                    
$dualid=0;
                } 
PHP Code:
In the same file find:

                
$DB_site->query("INSERT INTO " TABLE_PREFIX "pmtext\n\t(fromuserid, fromusername, title, message, touserarray, iconid, dateline, showsignature, allowsmilie)\nVALUES\n\t($bbuserinfo[userid], '" addslashes($bbuserinfo['username']) . "', '$title', '$message', '" addslashes(serialize($tostring)) . "', $iconid, " TIMENOW ", $signature$disablesmilies)");
    
Replace that with:

                                
                if (
$bbuserinfo['userid'] == $vboptions['warn_collector'])
                {
                    
$sender=$pm['sender'];
                    
$w1=$DB_site->query_first("SELECT username FROM " TABLE_PREFIX "user WHERE userid=$sender");
                    
$sendername=$w1[username];
                    
$DB_site->query("INSERT INTO " TABLE_PREFIX "pmtext\n\t(fromuserid, fromusername, title, message, touserarray, iconid, dateline, showsignature, allowsmilie)\nVALUES\n\t($sender, '" addslashes($sendername) . "', '$title', '$message', '" addslashes(serialize($tostring)) . "', $iconid, " TIMENOW ", $signature$disablesmilies)");
                }
                else
                {
                    
$DB_site->query("INSERT INTO " TABLE_PREFIX "pmtext\n\t(fromuserid, fromusername, title, message, touserarray, iconid, dateline, showsignature, allowsmilie)\nVALUES\n\t($bbuserinfo[userid], '" addslashes($bbuserinfo['username']) . "', '$title', '$message', '" addslashes(serialize($tostring)) . "', $iconid, " TIMENOW ", $signature$disablesmilies)");
                } 

Any new PM that someone tries to send after pressing submit, they get this SQL error:

Code:
Database error in vBulletin 3.0.7:

Invalid SQL: SELECT username FROM user WHERE userid=
mysql error: You have an error in your SQL syntax.  Check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1

mysql error number: 1064
I have installed the SaveDrafts hack, but I cannot see where this may be effecting it. There is code, however, placed near where the first code replacement here takes place.

The code from the SaveDrafts hack replaces this original vB code:

PHP Code:
    if (defined('PMPREVIEW'))
    {
        
$postpreview = &$preview;
        
$pm['title'] = htmlspecialchars_uni($pm['title']);
        
$pm['message'] = htmlspecialchars_uni($pm['message']);
        
$pm['recipients'] = htmlspecialchars_uni($pm['recipients']);
        
construct_checkboxes($pm);
    } 
Any ideas?

Show Your Support

  • This modification may not be copied, reproduced or published elsewhere without author's permission.

Comments
  #2  
Old 04-23-2005, 05:44 AM
sv1cec sv1cec is offline
 
Join Date: May 2004
Location: Athens, Greece
Posts: 2,091
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Correct, please edit private.php and find:

PHP Code:
                if ($bbuserinfo['userid'] == $vboptions['warn_collector'] and $pm['sender']!='')
                {
                    
$sender=$pm['sender'];
                    
$w1=$DB_site->query_first("SELECT username FROM " TABLE_PREFIX "user WHERE userid=$sender");
                    
$sendername=$w1[username];
                    
$DB_site->query("INSERT INTO " TABLE_PREFIX "pmtext\n\t(fromuserid, fromusername, title, message, touserarray, iconid, dateline, showsignature, allowsmilie)\nVALUES\n\t($sender, '" addslashes($sendername) . "', '$title', '$message', '" addslashes(serialize($tostring)) . "', $iconid, " TIMENOW ", $signature$disablesmilies)");
                }
                else
                {
                    
$DB_site->query("INSERT INTO " TABLE_PREFIX "pmtext\n\t(fromuserid, fromusername, title, message, touserarray, iconid, dateline, showsignature, allowsmilie)\nVALUES\n\t($bbuserinfo[userid], '" addslashes($bbuserinfo['username']) . "', '$title', '$message', '" addslashes(serialize($tostring)) . "', $iconid, " TIMENOW ", $signature$disablesmilies)");
                } 
Replace it with:

PHP Code:
                if ($bbuserinfo['userid'] == $vboptions['warn_collector'])
                {
                    
$sender=$pm['sender'];
                    
$w1=$DB_site->query_first("SELECT username FROM " TABLE_PREFIX "user WHERE userid=$sender");
                    
$sendername=$w1[username];
                    
$DB_site->query("INSERT INTO " TABLE_PREFIX "pmtext\n\t(fromuserid, fromusername, title, message, touserarray, iconid, dateline, showsignature, allowsmilie)\nVALUES\n\t($sender, '" addslashes($sendername) . "', '$title', '$message', '" addslashes(serialize($tostring)) . "', $iconid, " TIMENOW ", $signature$disablesmilies)");
                }
                else
                {
                    
$DB_site->query("INSERT INTO " TABLE_PREFIX "pmtext\n\t(fromuserid, fromusername, title, message, touserarray, iconid, dateline, showsignature, allowsmilie)\nVALUES\n\t($bbuserinfo[userid], '" addslashes($bbuserinfo['username']) . "', '$title', '$message', '" addslashes(serialize($tostring)) . "', $iconid, " TIMENOW ", $signature$disablesmilies)");
                } 
Closed Thread

Thread Tools

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT. The time now is 09:27 AM.


Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2024, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.06198 seconds
  • Memory Usage 2,269KB
  • Queries Executed 15 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)ad_showthread_beforeqr
  • (1)bbcode_code
  • (5)bbcode_php
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)modsystem_post
  • (1)navbar
  • (6)navbar_link
  • (120)option
  • (2)post_thanks_box
  • (2)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (2)post_thanks_postbit_info
  • (1)postbit
  • (2)postbit_onlinestatus
  • (2)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available:
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files:
  • ./showthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • forumjump
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • showthread_complete