Kill 1 Query In BBCode Manager (ACP)

While looking through bbcode.php in admincp/, i noticed that a global query was executed on all of it's pages, however only 2 actions need this query to be executed, so its a useless query on other pages within the BBCode Manager.

In admincp/bbcode.php
Find:

PHP Code:

$bbcodes = $DB_site->query("SELECT bbcodetag, bbcodereplacement, twoparams FROM " . TABLE_PREFIX . "bbcode");
$searcharray = array();
$replacementarray = array();
$doubleRegex = "/(\[)(%s)(=)(['\"]?)([^\"']*)(\\4])(.*)(\[\/%s\])/siU";
$singleRegex = "/(\[)(%s)(])(.*)(\[\/%s\])/siU";

while ($bbcode = $DB_site->fetch_array($bbcodes))
{
    if ($bbcode['twoparams'])
    {
        $regex = sprintf($doubleRegex, $bbcode['bbcodetag'], $bbcode['bbcodetag']);
    }
    else
    {
        $regex = sprintf($singleRegex, $bbcode['bbcodetag'], $bbcode['bbcodetag']);
    }
    $searcharray[] = $regex;
    $replacementarray[] = $bbcode['bbcodereplacement'];
} 


Replace It With:

PHP Code:

if($_REQUEST['do'] == "test" || $_REQUEST['do'] == "modify"){

    $bbcodes = $DB_site->query("SELECT bbcodetag, bbcodereplacement, twoparams FROM " . TABLE_PREFIX . "bbcode");
    $searcharray = array();
    $replacementarray = array();
    $doubleRegex = "/(\[)(%s)(=)(['\"]?)([^\"']*)(\\4])(.*)(\[\/%s\])/siU";
    $singleRegex = "/(\[)(%s)(])(.*)(\[\/%s\])/siU";

    while ($bbcode = $DB_site->fetch_array($bbcodes))
    {
        if ($bbcode['twoparams'])
        {
            $regex = sprintf($doubleRegex, $bbcode['bbcodetag'], $bbcode['bbcodetag']);
        }
        else
        {
            $regex = sprintf($singleRegex, $bbcode['bbcodetag'], $bbcode['bbcodetag']);
        }
        $searcharray[] = $regex;
        $replacementarray[] = $bbcode['bbcodereplacement'];
    }
} 


I know it's not much, but every little helps!

- Zero Tolerance

hum.. a Mini Hack... why not release this in the Bug Reports at vb.com ?!!!

[Zero Tolerance]

Hey, 1 thing at a time, here: http://www.vbulletin.com/forum/bugs....iew&bugid=3864

And yes a mini mod, however its result is optomizing the forum, so i put it in here instead

- Zero Tolerance

[Zachery]

at least its not being run on ever non acp page

[ericgtr]

Originally Posted by nexialys

hum.. a Mini Hack... why not release this in the Bug Reports at vb.com ?!!!

Geez dude, you are always the first to post and discredit mods in any way possible, nothing better to do?

Zero, thanks for posting this up, every little bit helps streamline the process.

[Bad Bunny]

Originally Posted by nexialys

hum.. a Mini Hack... why not release this in the Bug Reports at vb.com ?!!!

Yeah, it does seem like you're the unofficial homeland security of v.org. Nex.

Anyway! Keen eye, and thanks for this.

[Zero Tolerance]

Heh, well i got an expected reply from the vb team:

Originally Posted by Scott MacVicar

Not a bug, the code isn't executed enough to justify the change.

Disapointing really, justification of the change shouldn't be based on how much it is executed, executing once is more than enough, personally if i saw a minor area where i could improve the script, i go for it, no matter how small it is. Meh =/

- Zero Tolerance

[eva01_]

wow that is just a bunch of crap from them, you would think that if they find something that fixes it ever so slightly they would do it

vbulletin seems to me like micro++++

now then we just need something that is like Apple where they care

[Polo]

Originally Posted by Zero Tolerance

personally if i saw a minor area where i could improve the script, i go for it, no matter how small it is. Meh =/

- Zero Tolerance

I'm with you on this one Zero Tolerance..... :ermm:

[yoyoyoyo]

I agree- it is total crap for them to give you that reply- what is the point of NOT fixing it?