Go Back   vb.org Archive > vBulletin 3 Discussion > vB3 Programming Discussions
  #1  
Old 10-31-2004, 10:42 PM
kaotic's Avatar
kaotic kaotic is offline
 
Join Date: Mar 2003
Posts: 259
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default Proper Comma Construction?

Here's the code that I'm working with:

Code:
$GetUser = $DB_site->query("select s.*,u.* from ".TABLE_PREFIX."session s
left join ".TABLE_PREFIX."user u on (u.userid = s.userid) where s.location like '%test.php%'");
	while($UserIN = $DB_site->fetch_array($GetUser)){
	if(!$store_c[$UserIN['userid']]){
		if($UserIN['userid']){
		$activeusers .= "<a href='member.php?u={$UserIN['userid']}'>{$UserIN['username']}</a>, ";
		}
	}
}
I'm using it to contruct a users online list, but I'm having a problem with comma placements. Using the code above, a comma is placed once after each users name, including the last one to be listed... so it ends up looking like:

Quote:
user1, user2, user3,
Can anyone help me rid myself of the final comma? Assistance would be most appreciated.
Reply With Quote
  #2  
Old 10-31-2004, 10:58 PM
filburt1 filburt1 is offline
 
Join Date: Feb 2002
Location: Maryland, US
Posts: 6,144
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Add everything to an array in the loop, then use implode(", ", $arrays_name) to add the commas.

I also wrote an English sentence comma delimiter in Java it if helps (operates on an array of Objects).
Reply With Quote
  #3  
Old 10-31-2004, 11:15 PM
kaotic's Avatar
kaotic kaotic is offline
 
Join Date: Mar 2003
Posts: 259
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Ehh... I apologize for my ignorance, but I'm not very familiar with PHP. Could you further elaborate?
Reply With Quote
  #4  
Old 10-31-2004, 11:19 PM
filburt1 filburt1 is offline
 
Join Date: Feb 2002
Location: Maryland, US
Posts: 6,144
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

PHP Code:
$users = array();

$GetUser $DB_site->query("select s.*,u.* from ".TABLE_PREFIX."session s
left join "
.TABLE_PREFIX."user u on (u.userid = s.userid) where s.location like '%test.php%'");
    while(
$UserIN $DB_site->fetch_array($GetUser)){
    if(!
$store_c[$UserIN['userid']]){
        if(
$UserIN['userid']){
        
array_push($users"<a href='member.php?u={$UserIN['userid']}'>{$UserIN['username']}</a>");
        }
    }
}

$activeusers implode(", "$activeusers); 
edit: BTW, you badly need to add more whitespace to your code...it is very hard to read with it all scrunched together.
Reply With Quote
  #5  
Old 10-31-2004, 11:35 PM
kaotic's Avatar
kaotic kaotic is offline
 
Join Date: Mar 2003
Posts: 259
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Aye! Well, thank you for that. I appreciate the assistance.
Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT. The time now is 11:41 PM.


Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.03994 seconds
  • Memory Usage 2,198KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)ad_showthread_beforeqr
  • (1)ad_showthread_firstpost
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (1)bbcode_code
  • (1)bbcode_php
  • (1)bbcode_quote
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)navbar
  • (3)navbar_link
  • (120)option
  • (5)post_thanks_box
  • (5)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (5)post_thanks_postbit_info
  • (5)postbit
  • (5)postbit_onlinestatus
  • (5)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available:
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files:
  • ./showthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • forumjump
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • showthread_complete