help fix this error...

first im not know much about code so maybe the code have a little strange....

ok here we go...

i want to show the top poster in last week in my main page so i use this code in index.php

PHP Code:

$d= mktime (0,0,0,date("m"),date("d")-7,date("Y"));
$post7day = $DB_site->query_first("SELECT DISTINCT(userid),COUNT(postid) AS posts FROM post WHERE userid > 0 AND post.dateline>=$d GROUP BY userid ORDER BY posts DESC LIMIT 1");
while ($xxx=mysql_fetch_array($post7day)){
$post7dayuser=$DB_site->query_first("SELECT username FROM user WHERE userid=$xxx[userid]");}
eval("\$topthread = \"".gettemplate("top_thread")."\";"); 


and i creat a template name:top_thread(contant with username and posts) also put the $topthread
in forumhome.....when i goto my main page i found the error message in my header...

Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in /home/squawell/public_html/XXX/forum/index.php on line 61

this is line 61
while ($xxx=mysql_fetch_array($post7day)){

want help....thankz......

[Xenon]

$DB_site->query_first never returns a mysql result, it returns a normal php array.

remove the _first to get it working..

edit: just the query before the while loop is meant

[squawell]

Today at 07:36 PM Xenon said this in Post #2
$DB_site->query_first never returns a mysql result, it returns a normal php array.

remove the _first to get it working..

edit: just the query before the while loop is meant

thankz Xenon u always give me big help ...now the error is gone.....

but it only show up usernamethe post number did not below is the template in top_thread

PHP Code:

<a href=member.php?s=$session[sessionhash]&action=getinfo&userid=$xxx[userid]>$post7dayuser[username]</a><BR>$post7dayuser[posts] 


do i use wrong variable??thankz agian.....

[Xenon]

$post7dayuser=$DB_site->query_first("SELECT username FROM user WHERE userid=$xxx[userid]");}

you jhust read out username, not posts here

[squawell]

Today at 08:08 PM Xenon said this in Post #4
$post7dayuser=$DB_site->query_first("SELECT username FROM user WHERE userid=$xxx[userid]");}

you jhust read out username, not posts here

oh.....how should i change my code to show them both???

[Xenon]

PHP Code:

$d = mktime (0,0,0,date("m"),date("d")-7,date("Y"));
$post7day = $DB_site->query_first("
  SELECT DISTINCT(post.userid), COUNT(postid) AS posts, user.username 
  FROM post 
  LEFT JOIN user USING(userid)
  WHERE post.userid > 0 AND post.dateline>=$d 
  GROUP BY post.userid 
  ORDER BY posts DESC 
  LIMIT 1
");
eval("\$topthread = \"".gettemplate("top_thread")."\";"); 


template:

<a href=member.php?s=$session[sessionhash]&action=getinfo&userid=$xxx[userid]>$post7day[username]</a><BR>$post7day[posts]

[squawell]

Today at 06:47 AM Xenon said this in Post #6

PHP Code:

$d = mktime (0,0,0,date("m"),date("d")-7,date("Y"));
$post7day = $DB_site->query_first("
  SELECT DISTINCT(post.userid), COUNT(postid) AS posts, user.username 
  FROM post 
  LEFT JOIN user USING(userid)
  WHERE post.userid > 0 AND post.dateline>=$d 
  GROUP BY post.userid 
  ORDER BY posts DESC 
  LIMIT 1
");
eval("\$topthread = \"".gettemplate("top_thread")."\";"); 


template:

<a href=member.php?s=$session[sessionhash]&action=getinfo&userid=$xxx[userid]>$post7day[username]</a><BR>$post7day[posts]

thankz Xenon...it works!!!

another question...if i want another code also use in same template should i put the code above this

eval("\$topthread = \"".gettemplate("top_thread")."\";");

am i right?

[Boofo]

Xenon, how would you do this on a per forum type basis?

[Xenon]

@squawell: yes right, every variabole appearing in the template has to be before that eval!

@boofo:

it would slow down the query but i think this should do the trick:

PHP Code:

$post7day = $DB_site->query_first("
  SELECT DISTINCT(post.userid), COUNT(postid) AS posts, user.username 
  FROM post 
  LEFT JOIN user USING(userid)
  LEFT JOIN thread USING(threadid)
  WHERE post.userid > 0 AND post.dateline>=$d AND thread.forumid=xx
  GROUP BY post.userid 
  ORDER BY posts DESC 
  LIMIT 1
"); 


[squawell]

Today at 07:08 PM Xenon said this in Post #9
@squawell: yes right, every variabole appearing in the template has to be before that eval!

Thankz reply..Xenon

above ur code it will affect when u apply the code right?and the

post number will recount after 7 days later is that right too??