Fetch Row isn't grabbing all data in row

[Alwandy]

Hey there, basically I'm making something for my group and currently being a newbie in VB Classes & hooks.

Anyways, I made a query that would fetch every row in the table which it does because when I do this.

PHP Code:

$result = $db->query_read("SELECT * FROM uksfroster");
  
while ($fname = $vbulletin->db->fetch_row($result)){
    echo $fname[1];
} 


It displays them all but we know it requires to work with the template so I save it in $ffname like this.

PHP Code:

$result = $db->query_read("SELECT * FROM uksfroster");
  
while ($fname = $vbulletin->db->fetch_row($result)){
    $ffname = $fname[1];
}
$templater->register('firstname', $ffname); 


And uses this in template,

    <div class="blockbody">
      <div class="blockrow">
      {vb:raw firstname}
    </div>
    </div>

What happens is that only last piece of information get shown like this.
Lets say I got Alpha Bravo Charlie and I use row to show them all but in the end only Charlie comes out but I want Alpha and Bravo too.

What am I doing wrong?

[kh99]

You are overwriting the value of $ffname every time through the loop, so that in the end it is just set to the last name, as you saw. You could do this:

$result = $db->query_read("SELECT * FROM uksfroster");
  
while ($fname = $vbulletin->db->fetch_row($result)){
    $ffname .= $fname[1] . '<br />';
}
$templater->register('firstname', $ffname);

Then you should see them all. You could also render a small template inside the loop to format the data for each user, so that you wouldn't need to have any html in the code.

Another way to do it would be to use the vb4 loop template tags. WHat you'd do is build an array of the names, register that to the template, then put the loop tags in the template, like:

$result = $db->query_read("SELECT * FROM uksfroster");
  
while ($fname = $vbulletin->db->fetch_row($result)){
    $ffname[] = $fname[1];
}
$templater->register('firstname', $ffname);

Then in the template:

<vb:each from="firstname" key="key" value="username">
   Name: {vb:var username}<br />
</vb:each>

[Scanu]

I remember i do this sometime ago in a mod.. What's the template where you are registering the variable?
you can try something like this:

PHP Code:

$result = $db->query_read("SELECT * FROM uksfroster"); 
   
while ($fname = $vbulletin->db->fetch_row($result)){ 
    $ffname = $fname[1]; 
    $templater->register('firstname', $ffname);
} 


I don't think it will work but you can try

--------------- Added [DATE]1372083944[/DATE] at [TIME]1372083944[/TIME] ---------------

Kevin get it first yes that's what i've used, that's like the foreach function in php

[Alwandy]

Thanks for the help!
First way worked but didn't get 2nd way work, I'll look into it as 2nd way looks more easier to do and have since it'll be a roster.

Resolved it, thanks!

[kh99]

I fixed the template code above - I had used 'ffname' instead of 'firstname' that you used to register the variable. Maybe that's why it didn't work for you.