Go Back   vb.org Archive > vBulletin 3 Discussion > vB3 Programming Discussions

Reply
 
Thread Tools Display Modes
  #1  
Old 03-31-2008, 09:30 PM
RetroDreams RetroDreams is offline
 
Join Date: Nov 2002
Posts: 238
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default Removing trailing comma in loop?

I've got a ranking script using the query below.

PHP Code:
$othervotes $db->query_read("SELECT team, rankem_team.teamid, sum(points) AS totalpoints
FROM rankem_rank
INNER JOIN rankem_team ON rankem_team.teamid = rankem_rank.teamid
WHERE rankem_rank.weekid = 
$week
GROUP BY rankem_team.teamid
ORDER BY totalpoints DESC 
LIMIT 25,100"
);
if (
$db->num_rows($othervotes) > 0)
{
while (
$others $db->fetch_array($othervotes))
{
eval(
'$otherbits .= "' fetch_template('rank_otherbits') . '";');
}

Here is what is in the rank_otherbits template

PHP Code:
$others[team$others[totalpoints], 
As you can guess, there is a trailing comma. Is there a template conditional I can use to strip the last comma? If not, how can I do so programatically?
Reply With Quote
  #2  
Old 03-31-2008, 11:05 PM
Boofo's Avatar
Boofo Boofo is offline
 
Join Date: Mar 2002
Location: Des Moines, IA (USA)
Posts: 15,776
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Try:

$otherbits .= ', ' . trim($otherbits);
Reply With Quote
  #3  
Old 04-01-2008, 12:02 AM
RetroDreams RetroDreams is offline
 
Join Date: Nov 2002
Posts: 238
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by Boofo View Post
Try:

$otherbits .= ', ' . trim($otherbits);
Pardon my ignorance, but where exactly is it placed? I've put it before, in and after the loop and nothing formats correctly.
Reply With Quote
  #4  
Old 04-01-2008, 12:08 AM
Boofo's Avatar
Boofo Boofo is offline
 
Join Date: Mar 2002
Location: Des Moines, IA (USA)
Posts: 15,776
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

After.
Reply With Quote
  #5  
Old 04-01-2008, 12:10 AM
RetroDreams RetroDreams is offline
 
Join Date: Nov 2002
Posts: 238
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Like so, right?

PHP Code:
$othervotes $db->query_read("SELECT team, rankem_team.teamid, sum(points) AS totalpoints
FROM rankem_rank
INNER JOIN rankem_team ON rankem_team.teamid = rankem_rank.teamid
WHERE rankem_rank.weekid = 
$week
GROUP BY rankem_team.teamid
ORDER BY totalpoints DESC 
LIMIT 25,100"
);
if (
$db->num_rows($othervotes) > 0)
{
while (
$others $db->fetch_array($othervotes))
{
eval(
'$otherbits .= "' fetch_template('rank_otherbits') . '";');
}
}
$otherbits .= ', ' trim($otherbits); 
Here it is in action... it duplicates the list and adds a space.

http://www.goldhelmet.com/rankings.php?week=1
Reply With Quote
  #6  
Old 04-01-2008, 12:13 AM
Boofo's Avatar
Boofo Boofo is offline
 
Join Date: Mar 2002
Location: Des Moines, IA (USA)
Posts: 15,776
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

$otherbits = ', ' . trim($otherbits);

Sorry
Reply With Quote
  #7  
Old 04-01-2008, 12:17 AM
RetroDreams RetroDreams is offline
 
Join Date: Nov 2002
Posts: 238
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Hmm, still no go. Wondering if it is something wrong with my if statement.
Reply With Quote
  #8  
Old 04-01-2008, 12:19 AM
Boofo's Avatar
Boofo Boofo is offline
 
Join Date: Mar 2002
Location: Des Moines, IA (USA)
Posts: 15,776
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Put this above the eval:

$otherbits .= ', ' . trim($otherbits);
Reply With Quote
  #9  
Old 04-01-2008, 12:24 AM
RetroDreams RetroDreams is offline
 
Join Date: Nov 2002
Posts: 238
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

No go. Duplicates the list numerous times. I tried without the . as well and it just prints like n number of ,s and then the list as it did before.

--------------- Added [DATE]1207013300[/DATE] at [TIME]1207013300[/TIME] ---------------

Got it. I placed $otherbits = trim($otherbits, ', '); after the loop and it got the rangly rascal! Thanks for the gentle kick in the arse!
Reply With Quote
  #10  
Old 04-01-2008, 12:48 AM
Boofo's Avatar
Boofo Boofo is offline
 
Join Date: Mar 2002
Location: Des Moines, IA (USA)
Posts: 15,776
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Above the eval, right?
Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT. The time now is 07:44 AM.


Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2024, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.06415 seconds
  • Memory Usage 2,257KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)ad_showthread_beforeqr
  • (1)ad_showthread_firstpost
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (3)bbcode_php
  • (1)bbcode_quote
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)navbar
  • (3)navbar_link
  • (120)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (1)pagenav_pagelink
  • (10)post_thanks_box
  • (10)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (10)post_thanks_postbit_info
  • (10)postbit
  • (10)postbit_onlinestatus
  • (10)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available:
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files:
  • ./showthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • forumjump
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • pagenav_page
  • pagenav_complete
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • showthread_complete