Release 0.1 Mark Forum Read/Mark All Read from database hack

Here's the hack I worked on this week, in rough and not too pretty form. I'll be beautifying it soon.

You can download an rtf with all the code changes listed at http://murmurs.com/codechanges.rtf. Also in that file is the table creation statement.

Attached is a zip of all the changed files. Comments are included, but not consistant yet.

You can see this in action at http://tony.murmurs.com. Only two forums, but still.

I'll pretty up the code this weekend and make better install instructions.

This is way beta, so if there are any problems just post. Don't put this on a production board yet

Ethan

[Mike Sullivan]

ethank,

I had to remove your codechanges.zip file because it is in violation of the licensing agreement -- you may not post full files. You have to release them as instructions (or if you come up with a better way).

[ethank]

Doh! OK. Well, the rtf has the changed code, not full source. I'll figure out a better way to indicate where the changed code should go.

Anyhow, look at the rtf, as that will give you most of what you need, although its not as clear as it should be yet.

EThan

[ethank]

Two more additions. These two blocks assure that people get an initial Mark Read entry in the database if they don't have one. Its set to 0:00AM for the day they enter without one.

This goes in the login method in member.php, before the URL portion:

// *** CODE ADDED BY ETHANK
	
$record_exists=$DB_site->query("select userid from markread where userid='$userid' AND forumid = '0'");
    $num_records=$DB_site->num_rows($record_exists);
    if($num_records<1)
	{
		$firsttime=mktime(0,0,0);
		$DB_site->query("INSERT INTO markread (readtime, userid, forumid) VALUES ('$firsttime','$userid', '0')");
	}
// END ADD

And this goes in register.php, after the initial databse insert after the Start Add Member comment. This goes right before the big insert method...:

// *** ADDED BY ETHANK
		// Create Unix time for midnight...
		$firsttime=mktime(0,0,0);

		$DB_site->query("INSERT INTO markread (readtime, userid, forumid) VALUES ('$firsttime','$userid', '0')");


// END ADD

One general inprovement that would be usefull (in general) for VBulletin.

If the link that marks read contained a timestamp of the time when you displayed the page, then anything posted after you read that page would still show as unread.

For instance.....

If you display the page at 12:00 ..
then sit there for an hour ..
then press Mark Read ..
anything posted after 12:00 will still be shown as unread.

The way that VB does it is it marks stuff as read from the moment that you hit the link, so there is a possiblity that you could miss postings made inbetween the period of actually displaying the page and hitting the read link.

Onslo

[ethank]

Originally posted by Onslo
One general inprovement that would be usefull (in general) for VBulletin.

If the link that marks read contained a timestamp of the time when you displayed the page, then anything posted after you read that page would still show as unread.

For instance.....

If you display the page at 12:00 ..
then sit there for an hour ..
then press Mark Read ..
anything posted after 12:00 will still be shown as unread.

The way that VB does it is it marks stuff as read from the moment that you hit the link, so there is a possiblity that you could miss postings made inbetween the period of actually displaying the page and hitting the read link.

Onslo

That happened with Webboard too.. I guess the way we could do it is set a timestamp in a cookie on page load, then when they mark read, use that instead of the time they click the Mark Read. Maybe have it as an option?

The other bug I found was that if you mark a child forum read, the parent forums still are flagged "new" cause they just look at the "lastpost" from all their children. I need to have it make sure that that last post wasn't in a forum that was marked read, and if it was look at the second to the last post, etc. I'll work on that bug tonight.

EThan

Hows it coming Ethan?

Onslo

[ethank]

I wasn't home all weekend so didn't have a chance to compile it all. I'll be working on it today as well as doing one last bug fix. There's a weird thing with subconferences....

Ethan

[ethank]

I'm back from Georgia and seeing as how final is being released Monday, I'll post an updated instructions document and the current iteration of the hack here on Tuesday (hopefully)!

Thanks for your patience.

EThan

Excellent!

I await your masterpiece.

Top sport Ethan

Onslo