Strange problem in a plug-in

[sv1cec]

I am trying to use a simple query in a plug-in, located in the postbit_display_start hook, and for some strange reason, it crashes with the following error:

Fatal error: Call to a member function on a non-object in /home/xxx/xxx/includes/class_postbit.php(251) : eval()'d code on line 80

The code in that line, looks like:

$get_notes=$db->query_read("select w.*, u.username as warner from ".TABLE_PREFIX."warn_notes w
			LEFT JOIN ".TABLE_PREFIX."user u on (u.userid=w.warned_by)
			where warned_user='{$post[userid]}' order by warned_time desc");

I am not familiar with the new 3.5 conventions, but I can't find anything wrong with that statement, so any help would be greatly appreciated.

Rgds

Hm...try:

PHP Code:

$get_notes=$vbulletin->db->query_read("select w.*, u.username as warner from ".TABLE_PREFIX."warn_notes w
            LEFT JOIN ".TABLE_PREFIX."user u on (u.userid=w.warned_by)
            where warned_user='{$post[userid]}' order by warned_time desc"); 


[merk]

postbit_display_start is inside a class. You will need to use $this->registry instead of $vbulletin. Also be aware your query location is going to cause a query for every post on a page, if someone was in 100pp mode, there would be 100 queries just for your addition. (on top of the showthread queries)

[sv1cec]

Yes, I know, I think this is something I should address, but at the moment, that's how the code is. I have some idea on how to improve it.

Thanks

[merk]

If thats how the code is it wont work

You will have to use $this-registry to gain access to the db object.

[sv1cec]

Question: will $this-registry work everywhere, or there are places that your SHOULD use $this-registry and other places that you SHOULD user $vbulletin?

Tnx

[Marco van Herwaarden]

Inside classes use: &this->xxxxx
Outside use: $vbulletin->xxxxx

[merk]

Most hooks inside classes will have "data" ie "userdata_start" in them, but some wont. As Marco said, youll need to mix and match, BUT you should be able easily tell them apart by the error.

If you get "Call to a member function on a non-object " you're using the wrong one

[sv1cec]

LoL, yes, that much, I 've figured already!

Thanks folks, appreciated!