Go Back   vb.org Archive > vBulletin 3 Discussion > vB3 General Discussions

Closed Thread
 
Thread Tools Display Modes
  #1  
Old 06-06-2003, 09:20 PM
Jethro
Guest
 
Posts: n/a
Default FYI in case anyone else thought this was a vBulletin bug

Quote:
Database relations: deleting accounts can cause relations within the database to be broken; explaining it further would require extensive knowledge of vBulletin's underpinnings.
Reply just in from vBulletin support, and are those folks getting fast on the answers

Quote:
Honestly I have no idea what he means by that. I've deleted accounts before and have never had a problem. Nor have I heard of any problems like this in the almost two years I've been providing support.
Some one was asking my advice as to whether or not this was a possible bug in vBulletin before purchasing. Thank fully l can say it isn't and just posting it in case other's have read the message on the net and were wondering.

HTH.
  #2  
Old 06-06-2003, 09:24 PM
filburt1 filburt1 is offline
 
Join Date: Feb 2002
Location: Maryland, US
Posts: 6,144
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

It can break custom hacks that expect specific usernames or userids; also, for example, the tables userfield, post, thread, privatemessage, mailmessage, mailfilter, mailfolder, mailab, etc.

edit: stock vB doesn't have a problem (except when just deleting a row from the user table), but hacked vBs, which many people, including myself run, don't always integrate with vB's user deletion system. So you're fine if you want to use stock vB
  #3  
Old 06-06-2003, 09:52 PM
Jethro
Guest
 
Posts: n/a
Default

Custom usernames or userids, gee some people need to go back to college and learn about not hard coding information into software. Thank fully the 60 or so hacks we use, don't cause this problem, but then again we have some mighty fine php coders on the team (this doesn't include me, l'm technically lame).
  #4  
Old 06-06-2003, 10:02 PM
Link14716's Avatar
Link14716 Link14716 is offline
 
Join Date: Jun 2002
Location: Georgia, USA
Posts: 2,519
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

So, do you expect people to create a database field for every tiny hack they make? I don't think so.

And, for the record, I can't go back to college, considering I am still in high school.
  #5  
Old 06-06-2003, 10:10 PM
filburt1 filburt1 is offline
 
Join Date: Feb 2002
Location: Maryland, US
Posts: 6,144
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Today at 06:52 PM Jethro said this in Post #3
Custom usernames or userids, gee some people need to go back to college and learn about not hard coding information into software. Thank fully the 60 or so hacks we use, don't cause this problem, but then again we have some mighty fine php coders on the team (this doesn't include me, l'm technically lame).
Maybe you're misinterpreting what I meant; I mean that some rows reference nonexistant userids in some tables (other than user, of course). As such, strange things could happen when those userids are further queried to get username, styleid, etc.
  #6  
Old 06-06-2003, 10:20 PM
Jethro
Guest
 
Posts: n/a
Default

Quote:
Today at 09:02 AM Link14716 said this in Post #4
So, do you expect people to create a database field for every tiny hack they make? I don't think so.

And, for the record, I can't go back to college, considering I am still in high school.
I'm not sure what you are on about here. We have added exactly two table fields in the course of development. Hard coding what should be variable data is considered extremely bad coding practise in any language. Do some reading as to the reasoning behind it I would suggest some of Fabian Pascal's stuff, who's one of those relational db experts that keep us all informed of normalisation, though l am at a bit of a head scratching stage with seventh normal form. Don't know, if some one else could explain it that would be cool.

Hey when you graduate go to college young man. Keg parties and co-eds and all that....
  #7  
Old 06-06-2003, 10:22 PM
Jethro
Guest
 
Posts: n/a
Default

Should add thread was only started as a response to a question and through Jelsoft's answer to it.

The offending statement should perhaps be changed to reflect the true situation rather than being able to be misconstrued as meaning there is a problem in the underlying vBulletin software.
  #8  
Old 06-06-2003, 10:25 PM
filburt1 filburt1 is offline
 
Join Date: Feb 2002
Location: Maryland, US
Posts: 6,144
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

As I've said, stock vBulletin doesn't have a problem.

Let me put the analogy a different way; in my webmail hack, there's a mailmessage table with a column, among others, of userid. This column obviously stores the userid of whom the message belongs.

Now if the user was deleted via vB's user deletion system, the user/userfield rows would be deleted and all posts set to guests (not sure how PMs are handled). However, in my hack, the rows with that user's userid would still remain. The results could be unpredicable, from either just junk taking up space in the database, queries failing when trying to join data between tables, or some other bizarre problem.

Virtually every type of hack like my webmail hack--i.e., a hack that stores data per user--is affected by this problem.
  #9  
Old 06-06-2003, 11:54 PM
Jungleman Jungleman is offline
 
Join Date: Nov 2001
Posts: 23
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

If all of the user's data, that includes any PMs, posts, etc that they may have, is deleted via database queries, there should not be any problems.

Filburt, it's as simple as running a simple MySQL query to delete rows with that user's userID. Any admin that knows their way around VB, PHP, and mySQL should have no problems whatsoever.
  #10  
Old 06-07-2003, 12:18 AM
filburt1 filburt1 is offline
 
Join Date: Feb 2002
Location: Maryland, US
Posts: 6,144
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

I know. But, as I'm reiterating for the third time, most hacks that are in the data-per-user genre do not integrate with vB's user removal system and therefore are not cleaned up when a user is deleted.
Closed Thread

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT. The time now is 01:28 AM.


Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2024, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.04279 seconds
  • Memory Usage 2,242KB
  • Queries Executed 13 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)ad_showthread_beforeqr
  • (1)ad_showthread_firstpost
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (4)bbcode_quote
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)navbar
  • (3)navbar_link
  • (120)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (1)pagenav_pagelink
  • (10)post_thanks_box
  • (10)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (10)post_thanks_postbit_info
  • (10)postbit
  • (6)postbit_onlinestatus
  • (10)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available:
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files:
  • ./showthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • forumjump
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • postbit_imicons
  • pagenav_page
  • pagenav_complete
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • showthread_complete