Improved PM Popup JavaScript

What's it do?
Simple: it checks to see how many new PMs a user has. If they've only got one (which is usually the case...I don't think many people get tons of new PMs), the popup JavaScript alert displayed to them will let them know who sent them the message, what it's title is, and, rather than take them to the Inbox, it'll take them directly to the message.

If there's more than one, it'll display a more vague message, letting them know just how many new messages they have, and redirecting them to their Inbox (which is where the current popup directs you). Anyway, here's the hack:


Open global.php. Around line 266 you should see the following:

$newpmmsg=1;

RIGHT below it, place this (REPLACE your current code for this hack with the code below, if you happen to be one of the few people who actually intalled this originally from the Beta Hacks forum. )

  $latest_pm = $DB_site->query("SELECT p.privatemessageid AS pm_popup_id, p.title AS pm_popup_title, u.username AS pm_popup_username FROM privatemessage p, user u WHERE messageread = 0 AND p.userid = $bbuserinfo[userid] AND p.fromuserid = u.userid ORDER BY dateline DESC");
  $hack_pm_total  = $DB_site->num_rows($latest_pm);
  
    if ($hack_pm_total > 1) {
      eval("\$pm_popup_text = \"".gettemplate('pm_popup_multiple')."\";");
      eval("\$pm_popup_url  = \"".gettemplate('pm_popup_url_multiple')."\";");
    } else {
      extract($DB_site->fetch_array($latest_pm));
      eval("\$pm_popup_text = \"".gettemplate('pm_popup')."\";");
      eval("\$pm_popup_url  = \"".gettemplate('pm_popup_url')."\";");
    }

Now, create the four new templates. I've attached a file to this post containing the names of the four templates, and the text I've used to populate them -- which will probably be the same text and such you'll want to use. Don't be intimidated...they're all very small.

After that, edit your head_newpm template to make use of the new variables. Here's my use of it (highly suggested):

<script language="JavaScript">
<!--
function confirm_newpm() {
	input_box = confirm("$pm_popup_text");
	if (input_box == true) { // Output when OK is clicked
		second_box = confirm("Open in new window?\n\n(Press cancel to open your $inboxname in the current window.)");
		if (second_box == true) {
			window.open('$pm_popup_url','pmnew','width=600,height=500,menubar=yes,scrollbars=yes,toolbar=yes,location=yes,directories=yes,resizable=yes,top=50,left=50'); 
		} else {
			window.location = "$pm_popup_url";
		}
	} else {
	// Output when Cancel is clicked
	}
}
-->
</script>

Enjoy.

[69-FLy-gUy]

there is a script error also.. line 69

[santeematt]

w00t

thanks

[Brianna]

edit: NEVERMIND! I hope you aren't trying to figure it out right at this moment, cos it was just a very stoopid mistake on my behalf... :S

great hack! ^_^

[Dave-ahfb]

I have been working on this hack this morning, everything works fine if it is a single pm. When there is multiple pms I get a JS error I have narrowed it down to the following line of output

PHP Code:

input_box = confirm("You have 9 new private messages.\n Click OK to view your Inbox, or cancel to hide this prompt.
"); 


I am not a JS expert and cannot figure out what is making the "); go to a new line.

any suggestions?

Dave

[Dave-ahfb]

got it, had a space in the pm_popup_multiple template

Thanks for the hack

Dave

[MarkL]

Okay, having a question. Now that I have done this hack, a Pop-Up Message won't show. Anyone know what could be wrong? :$

[RetroDreams]

Installed flawlessly AFTER I cleaned out my inbox. =)

[Anjie]

I cleaned out my inbox, set the templates to no HTML, and now there is no pop up at all. Any advice?
Forgot to add, added all templates, and replace all coding exactly as suggested. Does appear in source code. Using version 2.3.0

[tkeil69575]

i have a slight improvement to this hack because of the following problem. when you have a user in your ignore list and he has sent you a pm (which wont show in your private messages, because you are ignoring him) the pop-up will say when getting a new pm that you have 2 new pms, although your only seeing one.

thats because the sql is not ignoring the useres in your ignore list.

here the modification I made (which seems to work):

above twtcommisch hack add:

 if (trim($bbuserinfo['ignorelist'])!="") {
    $ignoreusers='AND fromuserid<>'.implode(' AND 
fromuserid<>',explode(' ', trim($bbuserinfo['ignorelist'])));
  }

then change the sql to:

 $latest_pm = $DB_site->query("SELECT 
p.privatemessageid AS pm_popup_id, p.title AS pm_popup_title, 
u.username AS pm_popup_username FROM privatemessage p, 
user u WHERE messageread = 0 AND p.userid = $bbuserinfo
[userid] AND p.fromuserid = u.userid $ignoreusers ORDER BY dateline DESC");

tina

[Bison]

installed and working with vb 2.30