Miscellaneous Hacks - Patched Flash Uploader to Fix Known Exploits

UPDATE Dec 2014: 4.2.2 PL2, 4.2.2 PL3 and 4.2.3 core download packages from vBulletin now include this patched version of uploader.swf as standard.

This is a patched version of YUI 2.9.0 uploader.swf as used by vBulletin 4.x for managing multiple file uploads.

An exploit was found in the flash uploader (uploader.swf) file supplied with vBulletin 4.x. This file is part of the Yahoo YUI 2 Library which is end of life and Yahoo have stated that they will not be fixing it. Yahoo recommends that the file is removed as the flash uploader has been deprecated.

vBulletin's recommended fix is to replace the file with an empty file of the same name. If you do this, however, and rely solely on the Ajax uploader you will not be able to select multiple files without further modifications.

This modification is a recompiled version of uploader.swf with the above exploit fixed. An additional potential exploit has also been fixed by disabling a parameter not used by vBulletin.

The YUI source used is provided freely by Yahoo to whom I give full credit.


1) Installation

a) Extract uploader.swf from the .zip file and replace your existing file here:

<forum_root>/clientscript/yui/uploader/assets/uploader.swf

b) Make sure the flash uploader is enabled in the Admin Control Panel

Options -> Message Attachment Options -> Asset Manager - Enable -> Select "Yes, Flash Upload by Default"

c) Make sure you are NOT using remote YUI

vBulletin Options -> Server Settings and Optimization Options

Use Remote YUI set to None

d) You may also need to clear your browser cache and/or vBulletin cache (Maintenance ->Clear system cache) if you have performed the above steps correctly but clicking the Upload button still does nothing.



2) Changes

11th January 2014

The parameter 'allowedDomain' has been sanitised with a REGEX to prevent malicious javascript being passed in a query string.


11th January 2014 v2

Many thanks to FranzBanz (http://www.vbulletin.com/forum/member/449383-franzbanz) for his suggestions

• finding another exploit (using another parameter). Exploit fixed by setting the parameter (not used by vBulletin) to null.
• '-' Character added to allowed characters in allowedDomain

Non-Flash Alternative
Please note that if you would rather avoid using flash altogether an alternative Mod has been released by BirdOPrey5, although there are some compromises/limitations with IE10+.

Asset Manager / Image Upload Fix to upload multiple files like the Flash uploader


DISCLAIMER
I am not a flash developer, I am just another vBulletin customer trying to keep his members happy!
This file is provided free of charge for the benefit of the vBulletin community. You use it at your own risk!


Copyright ? 2013 Yahoo! Inc. All rights reserved.
Redistribution and use of this software in source and binary forms, with or without modification, are permitted provided that the following conditions are met:

Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer.

Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution.

Neither the name of Yahoo! Inc. nor the names of YUI's contributors may be used to endorse or promote products derived from this software without specific prior written permission of Yahoo! Inc.

THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

[alexm]

Not sure what to suggest... presume you've tried re-uploading all the vBulletin files in case something got corrupted during transfer? (remember to replace uploader.swf again afterwards!)

If that doesn't do it then maybe try reverting any relevant templates?

[rharbison]

Alex, yep, tried re-uploading.

My templates are all stock, I've run VB for many years ago, and long ago tired of customizing everything like a kid putting rims and spoilers on his new ride, only to have a new release require them to all be done over. I now run my forums as stock as I can possibly get and try to do any customizing, like ads, from within the framework.

What's really strange is why a couple forums on the same server would have one not work and another one work. But in any case, I decided I'd had enough hassles to trying to make it work and decided that was going to be my XF testbed.

[weave]

This is no longer working for me on 4.2.2 PL1 either. Clicking the button does nothing at all.

I have made sure I have the right file and settings no less than 3 times.

I have run the maintenance test, no issues found.

I have tried with.

APPLE:
Safari
Chrome
Firefox

Windows7:
IE 11
Firefox

Windows8:
IE11

The ONLY time I got it to work was on Windows with IE and all plugins/hooks disabled. It still was not working on the others.

Any ideas?

Thanks

[alexm]

Originally Posted by weave

This is no longer working for me on 4.2.2 PL1 either.

I have made sure I have the right file and settings no less than 3 times.

I have run the maintenance test, no issues found.

I have tried with.

APPLE:
Safari
Chrome
Firefox

Windows7:
IE 11
Firefox

Windows8:
IE11

The ONLY time I got it to work was on Windows with IE and all plugins/hooks disabled. It still was not working on the others.

Any ideas?

Thanks

Need more info. What is actually happening?

[weave]

Originally Posted by alexm

Need more info. What is actually happening?

Nothing. The button is there but clicking it does nothing at all.

[alexm]

Have you tried all the following?...

1) Make sure the flash uploader is enabled in the Admin Control Panel

Options -> Message Attachment Options -> Asset Manager - Enable -> Select "Yes, Flash Upload by Default"

2) Make sure you are NOT using remote YUI

vBulletin Options -> Server Settings and Optimization Options

Use Remote YUI set to None

3) Clear your browser cache

4) Clear VB cache

Maintenance ->Clear system cache

Can you PM me a link to your forum and a test account with upload permission and I'll try to take a look?

[weave]

Originally Posted by alexm

Have you tried all the following?...

1) Make sure the flash uploader is enabled in the Admin Control Panel

Options -> Message Attachment Options -> Asset Manager - Enable -> Select "Yes, Flash Upload by Default"

2) Make sure you are NOT using remote YUI

vBulletin Options -> Server Settings and Optimization Options

Use Remote YUI set to None

3) Clear your browser cache

4) Clear VB cache

Maintenance ->Clear system cache


Can you PM me a link to your forum and a test account with upload permission and I'll try to take a look?

Let me add the SWF back and will send you the PM with the logon info.

Thanks.

[weave]

Originally Posted by weave

Let me add the SWF back and will send you the PM with the logon info.

Thanks.

So now, for whatever reason, this is ALL working on my MAC.

I tested with:
Safari
Chrome
Firefox

And it all working.....but I did not do anything any different than before.

[Mickie D]

great work thank you!

[cloudfarmer]

woo hoo!! thankyou so much. To anyone else that is completely new at this sort of thing, you must delete your browser cache if using Chrome. I kept missing this step and it would not work.

using 4.2.2