Show Thread Enhancements - CES Intelligent Postbit Query

CES Intelligent Postbit Query
Version: 1.0.1

This hack is now used as a troubleshooting tool for members with unusually high queries on showthread. You do not need to install this unless your queries peak around 20 or higher.

Note that if after installing this you experience a drop in queries, it means you have a bad plugin installed. Leaving this installed, while this does not hurt your forum at all, does not solve your query problem - it only now hides it.

To disable the tool, you only need to change the line:

PHP Code:

$lastcheck = ($lastfetchtype == $fetchtype) ? true : false; 


to:

PHP Code:

// $lastcheck = ($lastfetchtype == $fetchtype) ? true : false; 


Post your query success stories in the thread!

For those without success (i.e. it doesn't seem to make a difference), please don't uninstall, but help us determine what is different in your case. PHP version, MySQL version, hacks installed, PHP cache, etc. would all be useful information. Thanks!

*** NEWS ***
This section has become a list of bad plugins. Often these plugins can be optimized by a rewrite using a different hook, and thus not causing this query issue.

Product: Username Management
Hook Location: postbit_factory
Bad Plugin: Add Username history to postbit(legacy)

1/28/2007 - v1.0.0, v1.0.1 released

I actually came across this while trying to reduce queries in my CES Site News mod which uses a customized showthread.php.

Known Issues:
- NONE

- Some users see an amazing improvement, others do not see a difference in query count for some time, while still others don't see any difference at all. It all depends on your server setup and your current vBulletin installation (settings, other mods, etc). This hack is still young (1 day) so we haven't narrowed down what causes these differences in success.

- If you are still experiencing the stolen signatures issue, you need to clear your sig_cache. Do this by going to AdminCP -> Maintenance -> Update Counters -> Empty Signature Cache.

What It Does:
On some installations showthread wastes 1 query per post in showthread.php when creating the postbits. You can tell if this applies to your installation if you approach or exceed 20 queries on a page of only 10 or so posts.

By adding these 4 lines, showthread checks to see if it already has created the appropriate Postbit Factory object instead of doing it all over again. Queries on showthread are thus DRASTICALLY reduced (1 per post), even though the code reveals no direct database references.

This can be a HUGE performance boost.

I hope someone from Jelsoft sees this thread...

Mod Features:
- removes multiple pointless queries

Products to Install: 0
Plugins Included: 0
Files to Upload: 0
Files to Edit: 1
New Templates: 0
Template Edits: 0
Queries Added*: -1

*See "What It Does" for details.

*** Changelog ***
As of Version 1.0.1:
- fixed bug where posts would "steal" signatures from each other
Special thanks to TheFrienzNet for his help ^_^

[da420]

Please read the original post by the author of this hack.
It will explain why it was taken out...

[thincom2000]

Yes, but to clarify: some users have reported that they did not have that product (Username Management) installed and still had high query counts.

There are a number of plugins that cause this, although in one case I have been unable to determine the origin of the 1 query per post.

If you have ibProArcade installed, there is a plugin which allows you to show crowns, etc. in the Postbit. This could potentially add 2 queries per post, so disable it.

If anyone has ibProArcade installed and can tell me the name of the plugin, I will include it in the first post.

Also, if you had neither of these installed and your query count on showthread is unusually high (around 20), post here, and we can work together to identify all the bad plugins (and request that the coders use $hook_query_joins in hook showthread_query instead).

I will re-upload the file for members to download as a troubleshooter in this respect, not as a hack.

[Skyline_GT]

I am looking to try this. How can we check how many Query it is using?

[da420]

Enable Debug mode.

[JohnBee]

Installed and it looks like its working from 20 queries down to 14 !!!
I will keep and eye on it for awhile to make certain this is for real

[fastforward]

Originally Posted by JohnBee

Installed and it looks like its working from 20 queries down to 14 !!!
I will keep and eye on it for awhile to make certain this is for real

You might want to read this earlier post again. You might be breaking any plugins you have installed that use the pobit hooks.

[thincom2000]

In case you haven't read the description to this hack recently, or my extensive post on the purpose of the hack: the point IS to break those plugins. The fact that your queries dropped means that you have plugins installed that aren't properly optimized and should either be rewritten (if you have experience coding) or disabled.

[JohnBee]

Originally Posted by thincom2000

In case you haven't read the description to this hack recently, or my extensive post on the purpose of the hack: the point IS to break those plugins. The fact that your queries dropped means that you have plugins installed that aren't properly optimized and should either be rewritten (if you have experience coding) or disabled.

No negative side effects to date. I have been working on the forum since yesterday testing things out.

Thanks for a great hack!

[oldford]

11 - 0 = 11 ... So no change for me. This is on a thread viewing 40 posts.

I appreciate your efforts and I'm glad it seems to help out those with more queries. I just wanted to post that it didn't affect mine. Thanks!

[thincom2000]

10 queries is the lowest I've been able to get queries on a showthread page. This is with NO attachments and NO polls. An attachment(s) will add 1 query to the entire thread, and a poll will add 2.

So if you have 10-13 queries, as a rule you probably don't need any optimization.

For me, so far I've been able to join all queries that do anything on a showthread page except the 2 additional poll queries. They seem to be a little more complicated.