[HTL] & [Normal] Shoutbox Hack - 1.03d

Re-released at https://vborg.vbsupport.ru/showthrea...790#post547790

[Cloudrunner]

Hey link, I uploaded all the files and such and ran the installer, however, all I get is that it automatically found my shoutbox version and when I click through, it says it doesn't need to update anything.

Nowhere in the installer does it ask for a new install (and I need a new install obviously).

Where for do I find this option?

Thanks
)O( Cloudrunner )O(

i.e. when I open the file for the first time I get:

Welcome to the upgrade/install script of the shoutbox hack by squall14716. This script will automatically install the phrases, settings, and database changes for you.

We have automatically detected your shoutbox verion. You may start the upgrade process by clicking the link below.

Click here to continue.

And that's it.

[monstergamer]

Originally Posted by Cloudrunner

Hey link, I uploaded all the files and such and ran the installer, however, all I get is that it automatically found my shoutbox version and when I click through, it says it doesn't need to update anything.

Nowhere in the installer does it ask for a new install (and I need a new install obviously).

Where for do I find this option?

Thanks
)O( Cloudrunner )O(

i.e. when I open the file for the first time I get:

And that's it.

what shoutbox did you have before
cause i was about to install this, cause we have been talking and he made an converter for the shoutbox here https://vborg.vbsupport.ru/showthread.php?t=59602and
i just wanted to know if it is working or not

[Cloudrunner]

Originally Posted by monstergamer

what shoutbox did you have before
cause i was about to install this, cause we have been talking and he made an converter for the shoutbox here https://vborg.vbsupport.ru/showthread.php?t=59602and
i just wanted to know if it is working or not

no other shoutbox...clean install...

[Darkwolf]

/me click install

[Link14716]

Well, in other words it sees the a setting that RC1 put in there controlling your shoutbox version. So that means that you have already ran the installer.

Take uninstall out of the Misc folder in the zip and run it in phpMyAdmin, then run these queries as well.
[sql]DELETE FROM phrasetype WHERE phrasetypeid='716';
ALTER TABLE language DROP phrasegroup_shoutbox;[/sql]

[Cloudrunner]

Originally Posted by Link14716

Well, in other words it sees the a setting that RC1 put in there controlling your shoutbox version. So that means that you have already ran the installer.

Take uninstall out of the Misc folder in the zip and run it in phpMyAdmin, then run these queries as well.
[sql]DELETE FROM phrasetype WHERE phrasetypeid='716';
ALTER TABLE language DROP phrasegroup_shoutbox;[/sql]

If I run the uninstall from the misc folder I'll end up deleting settings from the phrase table that are inherent within vb3.

setting_stopshouting_title
setting_stopshouting_desc
options_options_stopshouting_text
options_options_stopshouting_title

None of the other settings, varnames, or tables are present in my database because I have never installed the shoutbox (rc1 or otherwise). This is a clean install attempt on an unhacked board (not live yet (testing server)).

I do, however, have a copy of the RC1. Should I run that first? Or hold off until we figure out why RC2 is not liking a clean install?

please advise.

Thanks
)O( Cloudrunner )O(

[Link14716]

I'll look into it. It seems like an RC2 installer bug. Install it from the RC1 installer insetad for now.

EDIT: Attachment removed.

[Cloudrunner]

Originally Posted by Link14716

I'll look into it. It seems like an RC2 installer bug. Install it from the RC1 installer insetad for now.

Looking at the install code for RC2, I'm personally thinking that perhaps it lies somewhere around here?

Between line 84 and line 100

	if ($vboptions['shoutbox_version_no_touch'] != SHOUTBOX_VERSION_SH) {
		// Version auto-detected (RC1 and above)
		echo "We have automatically detected your shoutbox verion. You may start the upgrade process by clicking the link below.<br /><br />";
		echo "<a href='".THIS_SCRIPT.".php?step=2&amp;version=".$vboptions['shoutbox_version_no_touch']."'>Click here to continue.</a>";
		exit;
	} elseif ($vboptions['shoutbox_version_no_touch'] == SHOUTBOX_VERSION_SH) {
		echo "We have automatically detected your current shoutbox version, and it appears to be up-to-date.";
		exit;
	} else {
		// Version cannot be auto-detected (Gamma 1 and below)
		echo "We cannot detect your shoutbox version. This means that you are running 1.0 Gamma 1 or below, or have not installed the shoutbox yet. You may use this script to continue upgrading <b>but only if you are running 1.0 Gamma 1 or doing a clean install</b>! This script cannot upgrade your shoutbox if you are running Beta 5 or below, so upgrade to Gamma 1 manually first!<br /><br />";
		echo "If you are running 1.0 Gamma 1, ";
		echo "<a href='".THIS_SCRIPT.".php?step=2&amp;version=10g1'>click here to start the upgrade to ".SHOUTBOX_VERSION.".</a> ";
		echo "If you want to do a new install of the shoutbox, ";
		echo "<a href='".THIS_SCRIPT.".php?step=2&amp;version=new'>click here to install ".SHOUTBOX_VERSION.".</a> ";
		exit;
	}

Since back on line 61 your conditionals look for shoutbox_version_no_touch, and if not found they set $nextversion = "1.0 Release Candidate 1", but in the line 84 code it again looks for the shoutbox_version_no_touch, but has nothing in that conditional about the $nextversion variable?

Perhaps adding a conditional that compares what was set in $nextversion versus what is in SHOUTBOX_VERSION, or SHOUTBOX_VERSION_SH? The reason I say this is that for a clean install the following (from line 84) will always be "true":

$vboptions['shoutbox_version_no_touch'] != SHOUTBOX_VERSION_SH

because $vboptions['shoutbox_version_no_touch'] will be non-existant on a clean install, and therefore will never be = SHOUTBOX_VERSION_SH.

did that even make sense?

[Link14716]

Yes, I saw that right after looking at it now. I don't see why I didn't catch it before.

I have fixed it, just give me a minute to put it in the zip.

[Cloudrunner]

Originally Posted by Link14716

Yes, I saw that right after looking at it now. I don't see why I didn't catch it before.

I have fixed it, just give me a minute to put it in the zip.

kewl.

Thanks! I'l give it a shot as soon as the zip is up