Improved Who's Online Display

This hack is pretty straightforward: it provides more detail on the Who's Online? page. Here are some examples:

• Things like "Editing Buddy List" or "Editing Forum Options" are not accompanied by links. "Buddy List" links to the page to edit your own Buddy List, and so on with "Forum Options, "Ignore List," and a few others similar to that.
  
• Instead of "Sending Email to Another Forum User" or "Viewing the Profile of a Forum Member," you'll be told which user it is in both cases, and their username will be a link to their profile.
  
• Most significantly, IMO: no more vague "Sending Private Message" or "Reading Private Message" messages. Now you have the following:
  -- Reading a Private Message
  -- Reading a Private Message From You
  -- Replying to a Private Message
  -- Replying to Your Private Message
  -- Sending a Private Message
  -- Sending a Private Message to You
  
  As you can see, this is much more useful, yet it still protects the basic privacy of each member. Cool, eh?
  
• "Viewing the Results of a Poll" now links you to the results of that poll, and the word "Post" in "Editing Post" is a link to the post being edited.
  
• The word "Attachment in "Viewing Attachmet in Thread Blah Blah Blah" is now a link to the specific attachment being viewed.

That's it, basically. I'm using it on my site: http://www.movieforums.net/online.php

It is *HIGHLY* recommended that you use vBHacker to install this hack, as it involves 14 code edits in one file (online.php)...automating that can save you a lot of time. Attached is an archive containing a vBHacker installation file, as well as a plain text instruction file. Enjoy.

[TWTCommish]

I'm looking at the code now...what did you say the problem was? Which link is giving you trouble?

[Kars10]

...$userinfo[where] = "Schaut sich das Profil an von <a href=\"member.php?s=$session[sessionhash]&action=getinfo&userid=$user[userid]\">$user[username]</a>";


and here is the problem. It looks like: schaut sich das profil an von >>mr.x<<. If i click on mr.x ill get a message that this user are not registered.

[TWTCommish]

I'm not sure what's wrong, but to make sure the link works, replace this:

PHP Code:

if ($user[username]) { 


with this:

PHP Code:

if (intval($user[userid])) { 


[Kars10]

Thank you Chris. I will try it.

[FleaBag]

Running well on 2.2.6 apart from 1 issue with the profile userid, it doesn't put the number of the member in the hyperlink.

[TWTCommish]

Replace this...

$user   = $DB_site->query_first("SELECT username FROM user WHERE userid = ".intval($userid[1]));

...with this...

$user   = $DB_site->query_first("SELECT userid, username FROM user WHERE userid = ".intval($userid[1]));

[FleaBag]

Thanks Chris. Nobody viewing profiles for me to check at the moment, but I'm sure it works!

[FleaBag]

It doesn't say the name of the person who's profile they are viewing at all now... I'm gonna check my online.php just to be sure everything is as it should be.

[FleaBag]

Right everything is as it should be, all the file edits are done. Did you deliberately remove that feature Chris? If so wouldn't it be better to have the member name without the link, if it isn't easy to do? I have no idea what I'm talking about by the way.

[TWTCommish]

The whole block of code should look like this:

    case 'getinfo':
      $userid = explode('userid=', $userinfo[location]);
      $user   = $DB_site->query_first("SELECT username FROM user WHERE userid = ".intval($userid[1]));
      
        if ($user[username] && $user[userid]) {
          $userinfo[where] = "Viewing Profile of <a href=\"member.php?s=$session[sessionhash]&action=getinfo&userid=$user[userid]\">$user[username]</a>";
        } else {
          $userinfo[where] = "Viewing Profile of a Forum Member";
        }
        
      break;

Anyway, you can always test it without anyone else: just view a profile, and make the next page you go to be the Who's Online page. That's how I tested it.