[RELEASE] Private Messaging 1.2.5

Not much of a release, but should be 1.1.4 compliant.

Please discuss here: http://www.vbulletin.org/hacks/hacks...=gethack&id=36

if ($table=="privatercvd") {
    $messages = $DB_site->query("SELECT msgid,toid,fromid,title,UNIX_TIMESTAMP(datetime) AS datetime,iconid,repliedto FROM $table WH
  } elseif ($table=="privatesent") {
   $messages = $DB_site->query("SELECT msgid,toid,fromid,title,UNIX_TIMESTAMP(datetime) AS datetime,iconid FROM $table WHERE fromid
  }
  if ($messages) {
  //parse each message
  while ($message=$DB_site->fetch_array($messages)) {
    $fromid = trim($message[fromid]);
    if ($ignore[$fromid]) {
      continue;
    }
    $fromuser = $DB_site->query_first("SELECT username FROM user WHERE userid=$fromid");
    $from = stripslashes(trim($fromuser[username]));
    $toid = trim($message[toid]);
    $touser = $DB_site->query_first("SELECT username FROM user WHERE userid=$toid");
    if ($table=="privatesent") {
      $from = trim($touser[username]);

I have just read through the code briefly... and have a few suggestions:
1) The part where we want to get the name of $fromuser is a new query, so the number of queries fired will be proportional to the number of PM a person gets, why not do a join ?
2) the second part, to find the $touser, afaik, this field is useful if we are at the SentItems folder? So if we are else where, those queries fired are just wasting CPU cycles?

just my 2 cents..

Hey,
cool hack
i'm using vb v1.1.3

annybody has the instructions for v1.1.3 ?

becuz...
i can't find in the showthread.php:

$posts=$DB_site->query("SELECT post.dateline as dateline,post.postid as postid,post.pagetext as pagetext,
                               post.allowsmilie as allowsmilie,post.signature AS showsignature,post.title as title,
                               post.ipaddress as ipaddress,post.iconid as iconid,post.username as fakename,
                               post.userid as userid, 
                               user.userid as userid,user.email as email,user.username as username,
                               user.usertitle as usertitle,user.signature as signature,user.showemail as showemail,
                               user.homepage as homepage,user.icq as icq,user.aim as aim,user.yahoo as yahoo,
                               user.joindate as joindate,user.posts as posts

only this looks like it

$posts=$DB_site->query("SELECT dateline,postid,pagetext,allowsmilie,signature AS showsignature,title,ipaddress,iconid,username,userid FROM post WHERE threadid=$threadid AND visible=1 ORDER BY dateline $postorder LIMIT $limitlower,$perpage");

please annybody help me.. thnx

i also cant find $userinfo=$post; in showthread.php

Why not upgrade?

because i installed allready a lot of hacks

Hi everyone,,

Pleas help me 24 hours only from installing PM . And now my forums not work .

It is gaive me this messag :


There seems to have been a slight problem with the database. Please try again by pressing the refresh button in your browser.

An E-Mail has been dispatched to our Technical Staff, who you can also contact if the problem persists.

We apologise for any inconvenience.







So PLEAS Any body can help .

Error message is... I dunno, usually... REQUIRED!

Ed Sullivan

Error message is... I dunno, usually... REQUIRED!

Ed, Pleas I cant understand , Now 4 hours not work .

what can i do now to solve this ?

You need to tell me the actual error message you're getting. Not just that cover. Paste the email here or view the page source and you'll see it.

Ed , there is no email sent to me .

Because (Technical Staff,) Not linkting to any email .

if you know where i have to but my email .

Thank you Ed ,