Go Back   vb.org Archive > vBulletin Modifications > vBulletin 4.x Modifications > vBulletin 4.x Add-ons

Reply
 
Thread Tools
Chrome Browser Notice (For Quick Reply Editor) - How to fix non-working space bar Details »»
Chrome Browser Notice (For Quick Reply Editor) - How to fix non-working space bar
Version: 1.0.0, by BirdOPrey5 (Senior Member) BirdOPrey5 is offline
Developer Last Online: Aug 2023 Show Printable Version Email this Page

Category: New Posting Features - Version: 4.x.x Rating:
Released: 11-04-2016 Last Update: 11-04-2016 Installs: 42
Supported Uses Plugins Auto-Templates
Re-useable Code  

If you are not already aware the latest version of Chrome browser (Version 54.0.2840.71, possibly others) has introduced a bug or incompatibility with the version of CKEditor used in VB 4.x.

If a user attempts to use the "Reply With Quote" feature on an existing post and begins to type their reply under the existing quote without hitting the Enter key first, the space bar will not work.

The issue is talked about on vBulletin.com here: http://www.vbulletin.com/forum/forum...rking-on-reply

While this is not a true fix, it does display a notice above the quick reply editor advising Chrome users that they can fix the problem simply by hitting the Enter key. (See Screenshot.)



The actual text displayed is held in a Global phrase called chrome_editor_message_bop5 so it is easily edited or translated as needed using Phrase Manager in the Admin CP.

There are no options, just install it and it will become active. Disable or remove the product to stop using it.

Notice will only be displayed in Chrome browser and when the enhanced WYSIWYG editor is enabled in the user's options. The Standard Editor and Basic Editor do not have this bug.

The function that attempts to determine the browser version was publicly available, location it can be found is a comment in the Functions plugin.

This mod will only install on VB 4.x versions and is only useful with VB 4.x versions 4.1.12 and above. May not work on heavily customized styles.

------------------------------------------------------

Please "Mark as Installed" if you use this.
Donations always appreciated. :up:
Nominate MOTM if you LOVE it!

Download Now

File Type: xml product-chromeeditorwarnbop5.xml (2.8 KB, 147 views)

Screenshots

File Type: jpg chrome_browser_warn_ss.jpg (62.3 KB, 0 views)

Show Your Support

  • This modification may not be copied, reproduced or published elsewhere without author's permission.
4 благодарности(ей) от:
Alan_SP, Dragonsys, Inna, RichieBoy67

Comments
  #42  
Old 01-25-2017, 11:33 AM
tpearl5's Avatar
tpearl5 tpearl5 is offline
 
Join Date: Nov 2001
Location: PA
Posts: 1,014
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by Kane@airrifle View Post
I take no credit, this kludge was posted elsewhere by man1c.

To get it to work in PMs and Quick reply add this to the bottom of editor_contents.css.

Code:
/*-- Temporary Chrome Spacebar Fix --*/
@supports (-webkit-appearance:none) {
body.forum {white-space: pre-wrap;}
body.content {white-space: pre-wrap;}
}
Thanks for this! Is it just putting the cursor before the quote tag, or am I missing something?
Reply With Quote
  #43  
Old 01-30-2017, 01:52 AM
sticky sticky is offline
 
Join Date: Sep 2003
Posts: 934
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Anyone know if the latest chrome update resolves this?
Reply With Quote
  #44  
Old 02-01-2017, 04:09 AM
Kane@airrifle's Avatar
Kane@airrifle Kane@airrifle is offline
 
Join Date: Jun 2011
Location: ZA
Posts: 181
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by tpearl5 View Post
Thanks for this! Is it just putting the cursor before the quote tag, or am I missing something?
Other than occasionally testing I never use the WYSIWYG editor myself so I do not really know what the usual cursor position is for it.

After complaints about the massive amount of whitespace the above css kludge adds to quoted contents while editing, particularly irksome when the post is long, I went another route in the end.

I removed the css from editor_contents.css and kept Quick Edit turned off. In New Posting Templates/newpost_quote I simply added 3 blank lines below:
Code:
{QUOTE={vb:raw originalposter}]{vb:raw pagetext}[/QUOTE}
It has the same effect as the css kludge without the aggravation of the white space in the quoted content. Users imply move the cursor to the 1st, 2nd or 3rd line below the quote and reply. If you can live an under quote you can put the blank lines above the code.

Quote:
Originally Posted by sticky View Post
Anyone know if the latest chrome update resolves this?
BirdOPrey5's mod is still relevant with the latest version of Chrome ( 56.0.2924.76 ). I don't think Google will fix it. I don't think the baked in CKEditor needs a complete overhaul either, as far as I know only two files need updating, ckeditor.js and the enhancedsourcearea plugin.
Reply With Quote
  #45  
Old 02-01-2017, 11:37 AM
tpearl5's Avatar
tpearl5 tpearl5 is offline
 
Join Date: Nov 2001
Location: PA
Posts: 1,014
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by Kane@airrifle View Post
Other than occasionally testing I never use the WYSIWYG editor myself so I do not really know what the usual cursor position is for it.

After complaints about the massive amount of whitespace the above css kludge adds to quoted contents while editing, particularly irksome when the post is long, I went another route in the end.

I removed the css from editor_contents.css and kept Quick Edit turned off. In New Posting Templates/newpost_quote I simply added 3 blank lines below:
Code:
{QUOTE={vb:raw originalposter}]{vb:raw pagetext}[/QUOTE}
It has the same effect as the css kludge without the aggravation of the white space in the quoted content. Users imply move the cursor to the 1st, 2nd or 3rd line below the quote and reply. If you can live an under quote you can put the blank lines above the code.



BirdOPrey5's mod is still relevant with the latest version of Chrome ( 56.0.2924.76 ). I don't think Google will fix it. I don't think the baked in CKEditor needs a complete overhaul either, as far as I know only two files need updating, ckeditor.js and the enhancedsourcearea plugin.
Yes, I noticed the extra line breaks too.

I'm going to do some testing with the updated ckeditor rar (v3.6.6) file posted here: http://www.vbulletin-ressources.com/...10-et-ckeditor

and see if it makes a difference.
Reply With Quote
  #46  
Old 02-01-2017, 01:36 PM
tpearl5's Avatar
tpearl5 tpearl5 is offline
 
Join Date: Nov 2001
Location: PA
Posts: 1,014
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Okay, yeah, that rar isn't going to work without modifying things further. It looks like they just merged the vbulletin plugin with the latest ckeditor code, but by default vbulletin doesn't use the core directory.

Quote:
Originally Posted by Kane@airrifle View Post
I don't think the baked in CKEditor needs a complete overhaul either, as far as I know only two files need updating, ckeditor.js and the enhancedsourcearea plugin.
In ckeditor.js there's actually a function to insert the enter key
Code:
(function () {n.add('enterkey', {
If that were to be used after clicking reply with quote that would probably solve the issue. Unfortunately I don't know enough JavaScript to modify things myself.
Reply With Quote
  #47  
Old 03-27-2017, 11:31 AM
Flipfloptrader Flipfloptrader is offline
 
Join Date: Jan 2011
Location: Gold Coast
Posts: 69
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Installed and working, exactly what I was after, thank you.
Reply With Quote
Благодарность от:
BirdOPrey5
  #48  
Old 04-01-2017, 02:48 PM
War Machine War Machine is offline
 
Join Date: Sep 2011
Posts: 19
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

I can't translate the whole phrase. Everytime i try it my site crash in white page. Any solutions?
Reply With Quote
  #49  
Old 04-01-2017, 03:27 PM
sticky sticky is offline
 
Join Date: Sep 2003
Posts: 934
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by tpearl5 View Post
Okay, yeah, that rar isn't going to work without modifying things further. It looks like they just merged the vbulletin plugin with the latest ckeditor code, but by default vbulletin doesn't use the core directory.



In ckeditor.js there's actually a function to insert the enter key
Code:
(function () {n.add('enterkey', {
If that were to be used after clicking reply with quote that would probably solve the issue. Unfortunately I don't know enough JavaScript to modify things myself.
Any update or solution?
Reply With Quote
  #50  
Old 04-02-2017, 08:48 AM
BirdOPrey5's Avatar
BirdOPrey5 BirdOPrey5 is offline
Senior Member
 
Join Date: Jun 2008
Location: New York
Posts: 10,610
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by War Machine View Post
I can't translate the whole phrase. Everytime i try it my site crash in white page. Any solutions?
Check your PHP error log right after you get a white screen. It will be one of the most recent errors listed in the log. That will help figure out the issue. My guess, perhaps, out of memory, but wild guess without actual error.
Reply With Quote
  #51  
Old 05-01-2017, 02:40 PM
creative-friend creative-friend is offline
 
Join Date: Feb 2009
Posts: 340
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Now space bar working fine on WYSIWYG mode
Reply With Quote
Reply

Thread Tools

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT. The time now is 01:18 AM.


Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2024, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.08526 seconds
  • Memory Usage 2,347KB
  • Queries Executed 26 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)ad_showthread_beforeqr
  • (5)bbcode_code
  • (7)bbcode_quote
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)modsystem_post
  • (1)navbar
  • (4)navbar_link
  • (120)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (3)pagenav_pagelink
  • (11)post_thanks_box
  • (5)post_thanks_box_bit
  • (11)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (2)post_thanks_postbit
  • (11)post_thanks_postbit_info
  • (10)postbit
  • (2)postbit_attachment
  • (11)postbit_onlinestatus
  • (11)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available:
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files:
  • ./showthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • forumjump
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • fetch_musername
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • post_thanks_function_fetch_thanks_bit_start
  • post_thanks_function_show_thanks_date_start
  • post_thanks_function_show_thanks_date_end
  • post_thanks_function_fetch_thanks_bit_end
  • post_thanks_function_fetch_post_thanks_template_start
  • post_thanks_function_fetch_post_thanks_template_end
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_attachment
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • pagenav_page
  • pagenav_complete
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • showthread_complete