Add-On Releases - Rewrite eBay To ShoppingAds

Rewrite eBay To ShoppingAds

*** Please be aware that a member has had his ShoppingAds account deactivated through the use of this modification. (See https://vborg.vbsupport.ru/showpost....&postcount=113) ***

Description:
Adds ShoppingAds prefix to posted eBay links.

Request:
https://vborg.vbsupport.ru/showthread.php?t=144207

Installation:
All the installation information is in the package.

Changes:
2 Plugins
1 File

[Kamran]

Hi,

I installed it, but some users experienced popups asking if they wanted to download a file from auctionads, so I've disabled it now.

Here is the thread with screenshots on my forum.

[WoodiE]

I think this mod might be having problems with other mods as on a clean install forum this mod works fine, on my live forum it doesn't.

Kamran,

How long ago have you tried this? AA did have a problem a few days ago to which has been reported as fixed. If so you might want to try it again.

[Kamran]

Woodie - it was a few days ago, so I'll have a go again next week sometime, I'll let you know how it goes

I do have some other mods installed also, so its possible there is a conflict somewhere.

[Dismounted]

Originally Posted by WoodiE

I think this mod might be having problems with other mods as on a clean install forum this mod works fine, on my live forum it doesn't.

I've only tested on my board with my custom modifications and a clean board so that's maybe why I can't pinpoint the problem. I would be happy to go in and check which modification is causing the conflict for you.

[Paul M]

We came across a small issue with this today.

We had a thread that was generating errors and it turned out to be this causing them - it didn't like http://??? .

[Dismounted]

It generated a parse_url() error, correct? The cause of the error is that it isn't a valid URL. I'll need to do a loop to suppress errors, instead of using array_map().

In the meantime, just do this edit to the plugin "Rewrite Function". Find:

PHP Code:

$parsed = array_map('parse_url', array_map('strtolower', $links)); 


Replace With:

PHP Code:

// convert all links to lowercase
$links = array_map('strtolower', $links);

// parse links
$parsed = array();
foreach ($links AS $link)
{
    $parsed[] = @parse_url($link);
} 


[Paul M]

Originally Posted by Dismounted

It generated a parse_url() error, correct? The cause of the error is that it isn't a valid URL.

Yep, I ended up having to edit the post.

[siliconfinance]

I used your change to fix the parse error...no more parse error, but now it does not seem to rewrite the ebay links. Any thoughts?

[Dismounted]

Try this instead:

PHP Code:

// convert all links to lowercase
$lower_links = array_map('strtolower', $links);

// parse links
$parsed = array();
foreach ($lower_links AS $link)
{
    $parsed[] = @parse_url($link);
} 


[DieselMinded]

/me clicks installed