Existing Topics Check

This hack will allow you and your members to check for existing topics, or similar ones, of the thread you plan to create when at newthread.php.

This should help to prevent double topics that often appear from newbish members who neglect to use the search feature.

It uses the exact functions as the "similar threads" feature, therefore has the same accuracy.

Tested to work on:

• vBulletin 3 RC2
• Internet Explorer 6 (with Javascript enabled)
• Mozilla Firebird 0.7 / Mozilla 1.5 (with Javascript enabled)

------------------------------------------------

Tweak #1

If you would like the find icon to show upon typing in the input box, and then disappear if the input box is empty upon change, please do the following:


In the template newthread, find:

function showFind(object)
{
  if(object.value != '')
  {
    document.findicon.src = "$stylevar[imgdir_button]/findicon_on.gif";
    document.findicon.style.cursor = "pointer";
  }
  else
  {
    document.findicon.src = "$stylevar[imgdir_button]/findicon_off.gif";
    document.findicon.style.cursor = "default";
  }
}

Replace it with:

function showFind()
{
    document.findicon.src = "$stylevar[imgdir_button]/findicon_on.gif";
    document.findicon.style.cursor = "pointer";
}

function hideFind(object)
{
  if(object.value == '')
  {
    document.findicon.src = "$stylevar[imgdir_button]/findicon_off.gif";
    document.findicon.style.cursor = "default";
  }
}

In the same template, find:

<td><input type="text" class="bginput" name="subject" onChange="showFind(this)" value="$subject" size="40" maxlength="85" tabindex="1" /></td>

Replace it with:

<td><input type="text" class="bginput" name="subject" onchange="hideFind(object)" onkeypress="showFind()" value="$subject" size="40" maxlength="85" tabindex="1" /></td>

------------------------------------------------

Attached is a screenshot.

Inside the zip are English, German, and French installation instructions. Please be aware I used a software translator for the German and French docs.

Enjoy.

[buro9]

Originally Posted by Boofo

How do we add the trim code to this?

To add trim you'd do something like this:

function trim(str) {return str.replace(/^\s+/,'').replace(/\s+$/,'');}

function showFind(element) {
  if(trim(element.value) != '') {

And then carry on as before.

As regards your quotes bug, it isn't apparent on my site using Firefox and IE6 to test with.

[Boofo]

I get a line 7 expected ')' error when I use the quotes in a thread title. Isn't there a way to trim any code like that in the trim statement so it only looks for words? I use IE 6, by the way.

[buro9]

Originally Posted by Boofo

I get a line 7 expected ')' error when I use the quotes in a thread title. Isn't there a way to trim any code like that in the trim statement so it only looks for words? I use IE 6, by the way.

I have just registered on your site and tested this, and I cannot generate an error.

I believe that the problem lies elsewhere... try CTRL+F5 to refreh your IE cache in case it has old files... and then look at any changes you've made to other JavaScript on the page (such as any hacks you've put into the vb supplied javascript).

I tested with "'` and all worked fine.

Line 7 also suggests something much higher in the file... maybe in one of the included files?

Cheers

David K

[Boofo]

It only seems to happen when you use the quotes with a topic that doesn't exist. It the topic exists (like "testing") then I don't get the error. If I use "killing my chickens", I get the error. Does this make any sense?

[buro9]

Originally Posted by Boofo

It only seems to happen when you use the quotes with a topic that doesn't exist. It the topic exists (like "testing") then I don't get the error. If I use "killing my chickens", I get the error. Does this make any sense?

Got it... it's here:

<script language="javascript">
   window.alert("No matches found for:\n\""killing all chickens"\"");
   window.close();
</script>

The double quotes aren't escaped in the javascript error message.

[Boofo]

How do we fix that?

[buro9]

Originally Posted by buro9

Got it... it's here:

<script language="javascript">
   window.alert("No matches found for:\n\""killing all chickens"\"");
   window.close();
</script>

The double quotes aren't escaped in the javascript error message.

Simple solution... in findtopic.php at the bottom, find:

eval('print_output("' . fetch_template('newthread_find') . '");');

Above it add:

if (empty($threads)) {
  $subject = str_replace('"','\"',$subject);
}

[Boofo]

You are a saint! Thank you, sir. That worked great!

I'm glad it wasn't my imagination.

[Zilvia]

Does this work with the final release of vB 3.0.0?

[Velocd]

Yes.