Attachments as files

Well after alot of time leaving it in the beta hacks forums without any problems, I'm now moving it to the Full Releases, I'm satisfied that there isn't any bugs that need to be addressed. Thanks to Jawelin he pointed out most of the mistakes through alot of his testing.
I've attached it as an installer file here, as it needs to make changes to the database. Two new rows to settings and a new column in the attachment table.

Scott

Updated some more

Note the > is missing off the bottom of the file after the ?, add it before trying to install

[Scott MacVicar]

Silly question how isn't it working for vB 2.3.0 I didn't see any changes in the attachment code.

I will test this now on a fresh cvs copy.

[Scott MacVicar]

and there has been 2 users who upgraded to vB3 as well as using this hack, I provided a script to do so and you only need vB 2.2.9 to upgrade to vB3.

[Scott MacVicar]

Installed file on a 2.3.0 board following the instructions exactly. How exactly did you go about the upgrade?
All you needed to do was make the file changes, you didn't need to uninstall the hack beforehand as this would remove the hash column and you would lose the association with the attachments in the directory.

[scotty]

I followed the instructions exactly, the hash is still in the databse, can access the files per browser (supply the filename directly), but get the error:

Warning: stat failed for /home/web3/html/ioff/attachments/84902300622b0d0ded64d1ddcb68ff5e.file (errno=2 - No such file or directory) in /home/www/web3/html/ioff/attachment.php on line 53

Warning: fopen("/home/web3/html/ioff/attachments/84902300622b0d0ded64d1ddcb68ff5e.file", "rb") - No such file or directory in /home/www/web3/html/ioff/attachment.php on line 54

Warning: fread(): supplied argument is not a valid File-Handle resource in /home/www/web3/html/ioff/attachment.php on line 55

Warning: fclose(): supplied argument is not a valid File-Handle resource in /home/www/web3/html/ioff/attachment.php on line 56

chmod 777 done
php 4.2.2
php_admin_flag safe_mode Off
php_admin_value open_basedir none

[Scott MacVicar]

is this with all attachments or just some and was the attachment before or after the hack install?

[scotty]

copy 2.2.8 to new directory (with all attachments! ~2000)
upgrade to 2.3.0
installed:
- dynamic templates
- quickreply
- avatar as file (no problem!)
- welcome panel
- and now attachment as file

attachment was uploaded with the 2.2.8 version and your hack

when I try to upload, then this error appears:

Warning: Unable to create '/home/web3/html/ioff/attachments/bea992c8f4cdf9729c408c93a7deb10b.file': No such file or directory in /home/www/web3/html/ioff/admin/functions.php on line 1776

Warning: Unable to move '/home/www/web3/phptmp/phpfcMMqX' to '/home/web3/html/ioff/attachments/bea992c8f4cdf9729c408c93a7deb10b.file' in /home/www/web3/html/ioff/admin/functions.php on line 1776

Warning: stat failed for /home/web3/html/ioff/attachments/bea992c8f4cdf9729c408c93a7deb10b.file (errno=2 - No such file or directory) in /home/www/web3/html/ioff/admin/functions.php on line 1780

[scotty]

error even apperas, if "upload safe mode" in CP is activated

(avatar as file does work without it)

[Scott MacVicar]

you said you copied the entire directory to a new folder, did you move the attachments back to /home/web3/html/ioff/attachments or adjust the path in settings to reflect this?

[scotty]

Today at 01:06 PM PPN said this in Post #308
you said you copied the entire directory to a new folder, did you move the attachments back to /home/web3/html/ioff/attachments or adjust the path in settings to reflect this?

copied entire forum to new folder incl. attachments and adjusted path

[Scott MacVicar]

mk if you can pm me your ftp details and admincp details. Its definately a setting somewhere thats causing this.

The only thing i notice different is
/home/www/web3/html/ioff/attachments
and
/home/web3/html/ioff/admin/functions.php

missing www but that is probably intended