Scoring bug when the user has two open game windows

One of our users reported a major flaw in the Arcade mod.

If he opens 1 game in one browser window, and plays, but does not submit scores, and then goes and plays another game in a second browser window, it is possible to have the score for game 2 to be submitted as the score for game 1.

Here's some more info posted by himon how to reproduce the problem:

Play Game 1
Finish Game 1 but donot submit the score.
Start Game 2
No go and submit Game 1 score
It will get recorded in Game 2

Maybe it's possible to have the score-submission part of the mod verify the score is coming from the proper game somehow?

Thanks.

Regards,

Peter

[doubleclick]

Here's the post from the German site as provided by mahoni. However, I am not a licenced user there, so I can't see the code.

Can someone who is licensed at the German site please login over there and provide the simple fix that they have come up with?

OK, so wie es aussieht konnte ich den Bug bei uns fixen. Das Vorgehen im ersten Post ist soweit richtig. Ich hatte nicht bedacht, dass die v32 Spiele die Methode "save_score" nutzen. Diese wurde entweder vergessen upzudaten oder dort wird absichtlich anders agiert, was ich mir nicht vorstellen kann.

Jedenfalls nach dem ich die Zeile:
PHP-Code:
Der Inhalt dieses Abschnitts ist nur f?r Lizenznehmer sichtbar, Sie werden derzeit jedoch nicht als Lizenzinhaber erkannt.

Bitte ?ffnen Sie den <a href="http://members.vbulletin-germany.com/membersupport_priority.php">Kundenbereich</a>, tragen Sie Ihre E-Mail-Adresse ein, mit der Sie sich hier registriert haben und aktivieren Sie die Lizenz?berpr?fung f?r http://www.vbulletin-germany.org.
durch diese ersetzt habe:
PHP-Code:
Der Inhalt dieses Abschnitts ist nur f?r Lizenznehmer sichtbar, Sie werden derzeit jedoch nicht als Lizenzinhaber erkannt.

Bitte ?ffnen Sie den <a href="http://members.vbulletin-germany.com/membersupport_priority.php">Kundenbereich</a>, tragen Sie Ihre E-Mail-Adresse ein, mit der Sie sich hier registriert haben und aktivieren Sie die Lizenz?berpr?fung f?r http://www.vbulletin-germany.org.
scheint das Problem nicht mehr aufzutauchen.

Was mich wundert ist wieso ?berhaupt die GameID aus der Session mit der realen ID verglichen wird. Im Prinzip ist es doch v?llig egal wie viele Fenster ein User ge?ffnet hat, solange das Ergebnis dem Spiel eindeutig zugeordnet werden kann, was ja ?ber den gname geschieht. Oder ?bersehe ich dort etwas?

Jedenfalls ist man, wie es momentan aussieht, mit dieser ?nderung sicher gegen?ber Cheatern, die keine Tools einsetzten aber Tools sind eine andere Sache, die einen anderen Schutz ben?tigt.

W?rde mich ?ber Feedback freuen ob es funktioniert oder ob der Fehler weiterhin besteht. Bei uns zumindest ist er verschwunden.

Gr??e

P.S.: Die ?nderung bezieht sich auf die arcade.php

__________________

[Mahoni999]

Originally Posted by doubleclick

After registering, and going to google translator, the code fix is this:

I am an unlicensed user.

Since I bought my licence from vbulletin.com and not vbulletin-Germany.com, I am considered an outsider over there.

You have to register and valid your Licencenumber. if you have a valid Licence than you are also allowed to participate overthere. I signed up on german vbulletin and also had to make a Validation here and it works. So defently same for you. Just registering is not enough. If you unsure, you should contact the Support or an Admin overthere. He will for sure answer and help you to validate.

Hint:

Got to http://members.vbulletin-germany.com

Login with your Userdetails that you got when you signed up for vbulletin -> There go to Cutsomerarea -> On the left Side you see: Licenseowner in other Supportforums ( http://members.vbulletin-germany.com...t_priority.php ) -> there mark all Forums and you will shortly be able to see Code on all Sites which are listed there (included the one you need)

[doubleclick]

My god What a freakin mess this has been.

So: I am a member everywhere in the US and Germany, and here is the fix. Imagine my surprise to find Mr. Zeropage belongs to the forum there, and thus has ready access to this fix.

Anyway, in case anyone else is interested in stopping this scoring bug, here is the results of joining both German forums, exchanging emails with everyone on both continents, and wearing out google translator. Below is the post that Mahoni said contains the fix.

Thanks to Arthur Spooner who provided the following fix via google translator:

<begin Arthur Spooner post>

OK, it looks like I could fix the bug with us. The approach in the first post has come true. I had not considered that use the v32 games, the method "save_score. This was to update either forgotten or there is intentionally acting differently, which I can not imagine.

In any case, after I the line:

$DB->query("SELECT * FROM ibf_games_list WHERE gid=".$userinfo['arcade_sess_gid']);

was replaced by this:

$DB->query("SELECT * FROM ibf_games_list WHERE gname='".$swfgname . "'");

the problem seems to appear no more.

What surprises me is why all the GameID is compared from the session with the real ID. In principle, it is not matter how many windows a user has opened, as long as the outcome of the game can be uniquely identified with what is happening even on the gname. Or do I overlook something here?

In any case, one is, as it currently looks like, certainly with this change from cheaters, which uses no tools, but tools are a different matter that requires a different protection.

'd Appreciate feedback if it works or whether the problem persists. At the very least, he is gone.

Regards

PS: The amendment refers to the arcade.php

<end Arthur Spooner post>

Haven't had a chance to try this out yet, but have my fingers crossed in both languages.

Good luck,
ze doubleclicken

[Mahoni999]

So what counts is that you finally made it

Don`t understand why it was a Mess for you

And yes Mr. Zeropage is german and the Support in the german Forum is just great!!!

Hope you got if fixed now :up:

Give it a Shot and let the english People know if it works for you...

[doubleclick]

Yes, it's good to have the solution.

Don`t understand why it was a Mess for you

It's mess registering, confirming, etc. using a machine translator. Google or babelfish, are helpful to a point, but are often, well, funny if not wrong. Plus, when you try to translate a page that requires a login, the translater won't work. Plus getting the licence to work with support, etc., etc. If you want to try it yourself, find a vbulletin site in say, chinese, then try the process. You'll understand.

Why, if Mr. Zeropage is German, and the fix has been on the German site for a long time, doesn't he add this correction to his code releases? They've already done the work for him, so he just has to copy/paste and everyone's script is good. Otherwise, as I said before, everyone has to remember to edit his code whenever there is an upgrade.

The fix works to a point. Now, when the two-window situation arises, it simply refuses to post a score. Great for stopping the problem, but it leaves the users confused and/or angry, since they think the script is broken.

It would be great if someone here takes this code fix a step further so an error message appears explaining why the score they earned is not being posted.

Now lest anyone misunderstand, I like this script, or I wouldn't spend so much time getting it to work right. I have a number of local business who provide prizes for game and tournament winners, which is why correct scores and error messages are so important to me.

Happy Holiday of Your Choice,
dc

[Mahoni999]

Originally Posted by doubleclick

Why, if Mr. Zeropage is German, and the fix has been on the German site for a long time, doesn't he add this correction to his code releases?

The fix works to a point. Now, when the two-window situation arises, it simply refuses to post a score. Great for stopping the problem, but it leaves the users confused and/or angry, since they think the script is broken.

dc

Why he never changed that? Ask himself via PM....

btw: according to your Mess to register i just can tell you that: i made the full Progress and it was not difficult.

but now back to Topic as i`m getting offtopic....

Well, anyhow you will receive a Error-Message if you want to proceed with this 2 open Windows. It won`t leave the Users confused if you edit this Error Message to your wished Letters. I simply changed the Text. Now it is telling the Player that he might have had opend a second Window of the Arcade and for Anti-Cheat Protection this Score was not saved!

Wish you all a happy New Year

[doubleclick]

Originally Posted by Mahoni999

Ask himself via PM....

Kinda defeats the purpose of this support forum. Others concerned with this issue would want the answer if the reason as well is it breaks something.[/QUOTE]

Originally Posted by Mahoni999

2 open Windows. It won`t leave the Users confused if you edit this Error Message to your wished Letters.

The error message is:

"This score was not submitted from the game. Your score will not be saved."

I searched in cp> Languages & Phrases > Search in Phrases, and in all the arcade files, and can't find this message. Do you happen to know where this lives?

[stangger5]

Originally Posted by doubleclick

The error message is:

"This score was not submitted from the game. Your score will not be saved."

I searched in cp> Languages & Phrases > Search in Phrases, and in all the arcade files, and can't find this message. Do you happen to know where this lives?

Look in the arcade/lang/lang_Arcade_en.php file..

cheater		  	=> "This score was not submitted from the game.  Your score will not be saved.",

[doubleclick]

that did it!

Thanks stangger5

[Mahoni999]

yes, as stangger already descriped. You will find all the Text of the Arcade that might need to be changed in this php-File.

Regards
Mahoni