Is this SQL query correct?

[Lynne]

Of course it's an unknown column 'user.userid' in the field list - you aren't joining to the user table, so how would it get that field? But in the query you wrote, you use "$vbulletin->GPC['i']" which is a variable that is passed. That doesn't mean that line is still in the database. Have you looked at that table which testing this process and seen whether the row you want is still there?

What I was saying about global.php is that it's called in the register.php page, so I'm not sure it needs to be called again.

[Dismounted]

PHP Code:

$userdata = $db->query_first("
    SELECT u.username
    FROM " . TABLE_PREFIX . "useractivation AS ua
    LEFT JOIN " . TABLE_PREFIX . "user AS u USING (userid) 
    WHERE ua.activationid = '" . $vbulletin->db->escape_string($vbulletin->GPC['i']) . "'
    AND ua.emailchange = 0
    LIMIT 1
");

$username = $userdata['username']; 


[powerful_rogue]

Originally Posted by Lynne

Of course it's an unknown column 'user.userid' in the field list - you aren't joining to the user table, so how would it get that field? But in the query you wrote, you use "$vbulletin->GPC['i']" which is a variable that is passed. That doesn't mean that line is still in the database. Have you looked at that table which testing this process and seen whether the row you want is still there?

What I was saying about global.php is that it's called in the register.php page, so I'm not sure it needs to be called again.

Hi Lynne,
I knew that about the unknown column, I was just showing how I got a database error that confirmed the correct activationID was being associated with the user.

Originally Posted by Dismounted

PHP Code:

$userdata = $db->query_first("
    SELECT u.username
    FROM " . TABLE_PREFIX . "useractivation AS ua
    LEFT JOIN " . TABLE_PREFIX . "user AS u USING (userid) 
    WHERE ua.activationid = '" . $vbulletin->db->escape_string($vbulletin->GPC['i']) . "'
    AND ua.emailchange = 0
    LIMIT 1
");

$username = $userdata['username']; 


Hi Discountinued.

I replaced

PHP Code:

$username = htmlspecialchars_uni($vbulletin->userinfo['username']); 


with the above query, however it then throws up this error after confirming the email address

Fatal error: Call to a member function save() on a non-object in /home/dc/public_html/testsite/register.php on line 1079

[Lynne]

Try removing the global.php line and see what happens.

[powerful_rogue]

Hi Lynne,

Still comes back with the same error.

[Lynne]

Again I'll suggest that you take a look at the useractivation table during this process. I'm still not convinced that that row isn't deleted and thus you wouldn't get any result from that query.

[powerful_rogue]

Hi Lynne,

Looking through register.php it looks like your right.

Line 1023

PHP Code:

// delete activationid
        $db->query_write("DELETE FROM " . TABLE_PREFIX . "useractivation WHERE userid=$userinfo[userid] AND type=0"); 


Line 1068

PHP Code:

($hook = vBulletinHook::fetch_hook('register_activate_process')) ? eval($hook) : false; 


It deletes the activationid before it gets to the hook I need to use.

Looks like I might be a bit stuffed! I dont suppose you know of any other ways I may be able to resolve this.

[Dismounted]

Catch and hold the username at an earlier hook?

[powerful_rogue]

Thanks dismounted.
Is this an easy thing to do?

[Lynne]

Originally Posted by powerful_rogue

Thanks dismounted.
Is this an easy thing to do?

Again, look at register.php. That is the best thing to do. Find this right around line 1000:

PHP Code:

    $userinfo = verify_id('user', $vbulletin->GPC['u'], 1, 1);

    ($hook = vBulletinHook::fetch_hook('register_activate_start')) ? eval($hook) : false; 


You really need to look at the page you are using plugins for to see what is already going on.