Miscellaneous Hacks - CES Lv vB Event Forums Addon - Query Blaster

CES Lv vB Event Forums - Query Blaster
Version: 1.1.3

Requires:

• CES Pre-Process Hooks 1.2.0+ (needs showthread_preprocess and forumdisplay_preprocess)
• Lv vB Event Forums 3.3.1+
• Farcaster's Event Attendance & vb Event Forums Integration 1.1.0+

*** NEWS ***
7/28/2007 - v1.1.3 released
7/27/2007 - v1.1.2 released
7/24/2007 - v1.1.0, v1.1.1 released
4/2/2007 - v1.0.0 released

Known Issues:
- none

What It Does:
This modifies the Lv vB Event Forums addon by replacing a number of plugins and effectively removing LOTS of extra queries (you probably noticed). Also adds the ability to add attachments to events.

Products to Install: 1
Plugins Included: 20
Files to Upload: 0
Files to Edit: 1
New Templates: 5
Template Edits: 0

Mod Features:
- adds an option to the Forum Manager
- event attachments
- much fewer queries in forumdisplay and especially showthread

You will need to edit all your Event Forums in the Forum Manager and set "Is this an event forum?" to yes. This just makes some of the plugin code simpler and I think removed 1 query elsewhere. You still need to specify forum-calendar relationships in settings.

*** Changelog ***
As of Version 1.1.3

• fixed upcoming events on forumdisplay
• fixed edit options for first post
• fixed thread titles in forumdisplay
• fixed thread not created on event creation
• removed unused templates

As of Version 1.1.2

• fixed empty first post (event details)

As of Version 1.1.1

• fixed missing plugin since 1.0.0 that fetches event info

As of Version 1.1.0

• event forums use own showthread template
• separate postbit for event details
• map forums to calendars in the forum manager
• fixed redirect bug on attachment edit
• fixed bug where comments bar was disconnected

[TheMilkCarton]

Well.. there's at least some progress, now.

The first post, (the event) still shows up twice. Once at the top, and once underneath the "Post Reply" button and right before the first comment. EDIT: To clarify, it not only shows the entire event twice, it also somehow duplicates the rsvp_form and rsvp_bits. And to be more precise it puts the 2nd copy directly under the "Thread Tools ---- Search This Thread ---- Rate Thread" bar.

Also, it changes my formatting for "calendar_showeventsbit", and I can't seem to find which template you've replaced the first post with. It's also somehow showing my avatar, username, and user title, much like the horizontal postbit template looks.

Oh, and of course, the spacer_open/close is still out of whack. Everything from the first Post Reply button all the way down to below the Forum Jump is jutting out 10-ish pixels to the right.
-------------------------------------------
If it helps diagnose, the XML disabled 10 of the original event forums plugins, and 1 of the integration Add-On, is this the correct number?

EDIT2: OK... well I deleted "$lv_vb_eventforums_eventdetails" out of "showthread_event" and now it shows the eventbit in the correct place (and only once) .

EDIT3: All right... I figured out why the layout was messing up. I use vBadvanced to integrate something on the top of many pages, including showthread.php, and I've noticed since using Event Forums + Event Attendance that somehow, one of the products were inserting "calendar_showeventsbit" above the table I've integrated below $navbar, instead of inserting below it.

Well, anyway, I disabled the vBa integration on showthread.php, and that fixes it.... but the layout still shouldn't be breaking. The layout didn't break with Event Forums + Event Attendance + vBa below $navbar, but it does with EF + EA + Your Fix + vBa below $navbar.

EDIT4: Also had to change lv_vb_eventforums_event_comments to:

<if condition="$totalposts == 1">
$spacer_open

<table class="tborder" cellpadding="$stylevar[cellpadding]" cellspacing="$stylevar[cellspacing]" border="0" width="100%" align="center">
		<tr>
			<td class="alt1" align="$stylevar[left]"<if condition="$vboptions['legacypostbit']"> colspan="2"</if> valign="top">
				$vbphrase[no_comments_event]
			</td>
		</tr>
</table>
<br />

$spacer_close
</if>

Otherwise it was breaking my layout somewhat. And I got rid of the "Comments" tcat entirely, because placing one tcat under another (the threadtools tcat) looked weird, and I thought the "Comments" tcat was unnecessary anyway.

Well I'm glad to say that I got it working AND looking right!!

Thank you so much for updating this. I went from 84+ queries to 20+ on FORUMDISPLAY and from 35-40+ queries to 17+ on SHOWTHREAD

-------------------------------------------------
EDIT5: Spoke too soon.. When posting a New Event it doesn't create the thread. I've mapped everything appropriately, since the existing threads in the event forums still work as events. When I switch back to the old "eventdata_presave" it created the thread, but since I didn't switch back to the old redirect plugins, it didn't redirect.

Switching back to all the old "eventdata_" plugins seems to fix my problem. Coincidentally, the CPU usage just sky rocketed on my (shared) server, so I sure hope it wasn't me.

EDIT6: Well........... "Edit Attachments" doesn't seem to work either. It sends me to "calendar.php?do=edit&e=371"
EDIT7: Well........... "Upcoming Events" on FORUMDISPLAY doesn't work either.

I'm guessing there is a problem with some widely used variable you're using like "$lv_vb_eventforums_threadid" or one of those.

EDIT8: Geeeeez... It's also not adding the date to the end of thread titles. So I'm assuming it's either part of the above problems, or you're not telling it to grab the "Thread Title Format" field from the Event Forums options. Switching back to the old "threadbit_process" makes it work again, but of course the queries on forumdisplay DOUBLE.

[thincom2000]

lol Thank you for being so thorough. At least now I can narrow down the issues. You should continue to use the old eventdata plugins. I included them in the product when I was feeling a bit more ambitious, then realized doing so would result in a total rewrite of the original Event Forums hack (but it did not seem an errors would occur).

I will also look into upcoming events disappearing on forumdisplay. Strange the spacing still didn't work for you since I recall testing it at multiple spacer settings. I'm surprised the attachments still don't redirect properly since that bug was supposedly fixed but I will look at it again. I believe the current plugins don't try to use the thread title options from the Event options, since I was more concerned as of late actually getting the rest of the hack to work on other setups than mine.

Anyway, I'm glad you finally discovered a conflict with another hack because it was going to drive me nuts figuring that out when I don't even use vBa myself.

[TheMilkCarton]

Well, the only conflict with vBa was the layout messing up, and it's only because the original Event Forums plugin is inserting the "calendar_showeventsbit" in the same location as the top vBa block.

It should be:

$header
$navbar
<!-- vBa Top Block -->
<!-- calendar_showeventsbit -->

but instead it was doing:

$header
$navbar
<!-- calendar_showeventsbit -->
<!-- vBa Top Block -->

So, I just have to figure out where the original mod tells the calendar_showeventsbit to insert right below $navbar.

Although, really, the original mod shouldn't be trying to insert anything, since YOUR mod is also trying to insert the same thing in another location. But like I said, I already deleted "$lv_vb_eventforums_eventdetails" from showthread_event to get rid of the duplicates.

[thincom2000]

It's a setting in the Event Forums options. Choose the option that says you will edit the showthread template yourself. You shouldn't have to do anything else except tick that option.

[thincom2000]

I think I fixed pretty much everything you complained about in your last post in the new product. Let me know if you find anything else.

[TheMilkCarton]

All right. I turned off the automatic template edit and am using the $lv_vb_eventforums_eventdetails variable now, just to narrow down WHY things aren't working for me.

The update seemed to fix the FORUMDISPLAY issues... Custom fields and the Event Date now show in the threadbits, and still only use 26 queries, instead of 52!!

However, Edit Attachments still takes me to calendar.php. And the "eventdata_" plugins that come with YOUR product still aren't working.

The only thing I really care about is Edit Attachments. I'm fine with using the old "eventdata_" plugins. To narrow things down a bit, how did you "fix" Edit Attachments in this last update? Was it just a plugin edit? If it were a template edit, then I know why it's not working for me, since my templates are customized and wouldn't have been updated with 1.1.3

[thincom2000]

If you modified showthread_event you will need to revert it in 1.1.3. I usually include a list of updated templates in my hacks but I guess I didn't think of it for this one. However, the new version of the calendar_manage_start plugin should have fixed the attachments issue.

Try changing the Execute Order for the calendar_manage_start plugin to 1.

[TheMilkCarton]

I compared the templates and there is nothing functional changed. You do insert a </form> before the $lv_vb_eventforums_eventdetails and then begin the inline mod form after it, but I don't have my $lv_vb_eventforums_eventdetails in that location anyway. I did add "name="iform"" to the inline mod form, however. Since I guess you did that in case the Event form and Inline Mod form were clashing.

I changed the Execute Order to 1 and still nothing.

It's not even trying to send me to editpost.php so

if ($vbulletin->GPC['what'] == 'attach')

is somehow false, or maybe "if (intval($_GET['attach']) == 1)" is coming up false.

If the condition were true then it should at LEAST be trying to send me to something like "/editpost.php?p=&attach=1" with a blank postid, if it were the query that wasn't grabbing the firstpostid correctly.

OK. So I entered "editpost.php?p=4911&attach=1" where 4911 is the firstpostid of one of my events, and it redirects me to calendar.php...

So can you tell me exactly what plugins need to be DISABLED on the old Event Forums mod? Something might still be enabled when it shouldn't be.

[thincom2000]

Maybe the old editpost_edit_start plugin is still enabled. I just checked the install code and the product doesn't automatically disable it, so this is probably the issue.

[TheMilkCarton]

Yeah, that's probably it. LOL.

Sorry, there were far too many plugins between your product and the old one to try and sort out plugins at duplicate hooks. Especially when it involves scrolling from one end of the plugin page to another.

Oh, and I totally lied about FORUMDISPLAY working 100%. I forgot about testing out Upcoming Events... and well it's still not working.