EDIT: Search $vbphrase[mark_forums_read] in your styles and replace the whole <a href> tag with the one he gave.
Why? You might have multiple places that has the "Mark Forums Read" button, such as the Welcome Panel Rewrite mod or in your ForumHome template near the footer.
(I had three places.)
EDIT2: Dismounted, you might want to add that into your readme.
Hmmm, I might. Depends
Quote:
Originally Posted by Tralala
Actually, this works for me everywhere, except the QuickLinks pulldown in the standard vBulletin skin. I select the "Mark Forums Read" menu option, confirm the dialog that pops up, then nothing happens; no page refresh like I am used to.
(Ironically enough it works fine in my custom skin, in the QuickLinks pulldown, and all the other spots.)
Any clues?
EDIT: Code removed, as I'm told by Ziki below that it won't work, don't want to confuse future readers
You have to change the plugin location to global_complete. I made it at forumhome_complete because it was originally design to be only used for the link on the index.
You have to change the plugin location to global_complete. I made it at forumhome_complete because it was originally design to be only used for the link on the index.
Has anyone done this and had success? Without thinking I tried global_start instead of global_complete and of course it did not work.
What is there to debug? The hack is working as designed, it's just that people make modifications to the original usage which creates bugs.
While I agree with what you are saying here, if that's the stance you plan to take, you may want to explicitly state in the first post here that "this mod only provides a confirmation dialog when users click the 'Mark Forums Read' link on Forum Home, and nowhere else."
Because otherwise, one would assume the functionality is extended to every instance of "Mark Forums Read." Why would it not, from a UI standpoint? Why would one "Mark Forums Read" command differ from another?
Clearly there's a desire for consistency with this enhancement. It can be confusing if it works as expected in one place but not another -- especially when it comes to this sort of command where data (read/unread markers) is about to be effectively lost. That's the point of this mod, to give some security and warning back.
And so, as annoying as it may be that folks have begun to "run with" your mod and add stuff and then complain about bugs, I'd look at it as a compliment. Folks really like what you've started here! And so, may I respectfully request that you enhance this a tiny bit to work globally? Pretty please?
Quote:
Originally Posted by Dismounted
You have to change the plugin location to global_complete. I made it at forumhome_complete because it was originally design to be only used for the link on the index.
Quote:
Originally Posted by Smoothie
Has anyone done this and had success? Without thinking I tried global_start instead of global_complete and of course it did not work.
I tried changing it to global_complete and it did not work for me. I'd previously changed the other instances of the "Mark All Forums Read" command to call on the Javascript, but changing the plugin as suggested still didn't bring up the Confirmation dialog.
Still, regardless of what happens with this mod, I want to thank Dismounted for stepping up to the bat and offerring this up. vBulletin has needed this for a long while, and no one else cared to share. So, thanks, Dismounted!
That's a shame it does not work globally. It may confuse members in it's present state. As mentioned above, it's an awesome mod. Maybe Dismounted can help us out here and get this to work on all pages.
Mark All Forums Read Confirmation Details »»
About Developer
Uses Plugins 
No support by the author.
03-19-2007, 04:44 AM
