Forum Home Enhancements - Another Members that have Visited Statistics mod

This modification will make it possible to show statistics on the number of members that have visited. There are other modifications of this type, this one is however aimed at busy boards and written with performance in mind. Statistics are not real-time, but by default updated every 10 minutes by a cron.

Features:
- No extra queries on Forum Homepage
- 3 Timespans settible to show statistics for
- Optional show the membernames that have visited during the first timespan
- Information is collected by Scheduled Task to prevent processing on Forum Home
- Optional use filesystem caching
- Plus more optional settings
- This modifcation will not list the names of Members that are set to Invisible!

Please note that this is not marked as supported, as i don't have much time for that.

Changelog:
2007-01-19: v1.0.2
- Warning: implode() [function.implode]: Bad arguments. in /includes/cron/mh_mv_stats.php on line 144
This is caused by a changed behaviour between MySQL 4.1 and 5.x.
Changed:
AND NOT options & 512
To:
AND NOT (options & 512)
2007-01-02: v1.0.1
- Initial release

[sportsoutlaw]

Originally Posted by Steve B

Just tried this and I am getting the following error when the cron is run..



line 144 reads

,    '" . $vbulletin->db->escape_string(implode(", ", $names_a_short)) . "'

I have tried it with both the database writing and also the file writing with the same error.

Any ideas please?

Originally Posted by Al-Fateh

I installed the mod, however the members names who actually keep visiting the site are not shown on the list...

is there something wrong?

I have both of these issues.

php 4.4.4
Set to 200 members, which is lower than what I actually would have.

[thincom2000]

Originally Posted by Steve B

line 144 reads

PHP Code:

,    '" . $vbulletin->db->escape_string(implode(", ", $names_a_short)) . "' 


I have tried it with both the database writing and also the file writing with the same error.

Any ideas please?

Originally Posted by sportsoutlaw

I have both of these issues.

I don't have this mod installed, but by the looks of line 144, it could be causing both.

Try changing line 144 to:

PHP Code:

,    '" . $db->escape_string(implode(", ", $names_a_short)) . "' 


If what I say below is true, then this shouldn't change much, except make your code cleaner.

Originally Posted by Steve B

Test site with closed access apart from 4 mods: its showing no names at all, but under Members Visited Statistics: Last 24 Hours: 1 - Last 7 Days: 2 - Last 30 Days: 4 which seems to be right?

This would result in you having only 1 value for $names_a_short which either wouldn't count as an array (but you would get the error 'supplied argument is not an array') OR implode() just wouldn't be happy imploding less than 2 pieces. There is nothing in the php.net documentation about this, though, so it might not be the issue. Just a thought.

In any case, is there a check to do the following?

PHP Code:

if (count($names_a_short) < 2)
{
     // no commas necessary
     $whatever_the_string_is = $db->escape_string($names_a_short);
} 


EDIT: Having downloaded the code, and looking at it, the problem seems to be at line 82:

PHP Code:

        $names_a_short = $names_a_short[0]; 


Looking back at line 81, we see that $names_a_short[0] is in fact from an array, multi-dimensional thanks to array_chunk():

PHP Code:

        $names_a_short = (intval($vbulletin->options['mh_mv_max_forumhome']) == 0 ? array($names_a) : array_chunk($names_a, intval($vbulletin->options['mh_mv_max_forumhome']))); 


The array $names_a_short is formed from whatever $names_a is. The most recent definition of $names_a is line 73, where it is compressed to a single-level array:

PHP Code:

        $names_a["$name[username]"] = $names_a["$name[username]"]['username']; 


Thus, even though my logic makes no sense, this error makes no sense. Line 82 turns record 0 of the multi-level array not into another array, but into a string "Array". And we cannot implode a string...

Comment out line 82 and change line 144 to:

PHP Code:

,    '" . $db->escape_string(implode(", ", $names_a_short[0])) . "' 


OR

Change line 82 to:

PHP Code:

        $names_a_short = array_merge($names_a_short[0]); 


[Marco van Herwaarden]

Originally Posted by Al-Fateh

I installed the mod, however the members names who actually keep visiting the site are not shown on the list...

is there something wrong?

make sure you have set the member names to show in the vBulletin Options, and that the Scheduled Task has ran since you turned on showing membernames.

[Marco van Herwaarden]

Version 1.0.2 released to fix a bug with MySQL 4.x

Changelog:
2007-01-19: v1.0.2
- Warning: implode() [function.implode]: Bad arguments. in /includes/cron/mh_mv_stats.php on line 144
This is caused by a changed behaviour between MySQL 4.1 and 5.x.
Changed:
AND NOT options & 512
To:
AND NOT (options & 512)

[Marco van Herwaarden]

Warning: implode() [function.implode]: Bad arguments. in /includes/cron/mh_mv_stats.php on line 144

As per my previous post, this was caused by a change in behaviour between MySQL 4.x (tested on 4.1.21) and 5.x (development was done on 5.0). The WHERE-clause that should filter members that are set to invisible was causing the query to return no results with MySQL 4.1.21.

Adding () around the condition solved the problem. Also added test to avoid errors if no members returned.

[Steve B]

Thank you for taking the time to fix this.

Its now installed on our live site and working well

[sportsoutlaw]

Thanks Marco, it seems to be working perfectly for me now.

[Al-Fateh]

working great now!!!

[thincom2000]

Haha, or caused by $db->num_rows($names_a_short) < 1

That could work too. Glad you worked it out.

[PinkDaisy]

This isn't showing at all for me, I did all the instructions on installing. ???