Remove 1 Query Per Page

[CENTER]Remove 1 Database Query Per Page
Reduce your forums query usage !

Summary: (Quoted From Original Hack for vb3)

Removes 1 Query Per Page.

Instructions:

1. Open includes/class_core.php
2. Go to about line 2538 and look for

PHP Code:

$this->set('location', WOLPATH); 


3. Above that, paste the following.

PHP Code:

$this->set('old_location', $session['location']); 


4. Go to about line 2818 and look for the following:

PHP Code:

            // registered user
            if (!SESSION_BYPASS)
            {
                if (TIMENOW - $this->userinfo['lastactivity'] > $this->registry->options['cookietimeout'])
                {
                    // see if session has 'expired' and if new post indicators need resetting
                    $this->registry->db->shutdown_query("
                        UPDATE " . TABLE_PREFIX . "user
                        SET
                            lastvisit = lastactivity,
                            lastactivity = " . TIMENOW . "
                        WHERE userid = " . $this->userinfo['userid'] . "
                    ", 'lastvisit');

                    $this->userinfo['lastvisit'] = $this->userinfo['lastactivity'];
                }
                else
                {
                        $this->registry->db->shutdown_query("
                            UPDATE " . TABLE_PREFIX . "user
                            SET lastactivity = " . TIMENOW . "
                            WHERE userid = " . $this->userinfo['userid'] . "
                            ", 'lastvisit');
                }
            } 


5. Replace that with the following:

PHP Code:

            // registered user
            if (!SESSION_BYPASS)
            {
                if (TIMENOW - $this->userinfo['lastactivity'] > $this->registry->options['cookietimeout'])
                {
                    // see if session has 'expired' and if new post indicators need resetting
                    $this->registry->db->shutdown_query("
                        UPDATE " . TABLE_PREFIX . "user
                        SET
                            lastvisit = lastactivity,
                            lastactivity = " . TIMENOW . "
                        WHERE userid = " . $this->userinfo['userid'] . "
                    ", 'lastvisit');

                    $this->userinfo['lastvisit'] = $this->userinfo['lastactivity'];
                }
                elseif ($this->vars['old_location'] != WOLPATH || THIS_SCRIPT == 'misc' || THIS_SCRIPT == 'online')
                {
                    $this->registry->db->shutdown_query("
                        UPDATE " . TABLE_PREFIX . "user
                        SET lastactivity = " . TIMENOW . "
                        WHERE userid = " . $this->userinfo['userid'] . "
                        ", 'lastvisit');
                }
            } 


[Trigunflame]

Gotta love bumps.. but no this really is important...

[Oblivion Knight]

Is there anything fundamentally changed by this?

The only reason I haven't installed it personally, is because Jelsoft generally do a good job at optimising their code and queries. If they could have originally saved on this query without losing some kind of functionality, I'd be wondering why they didn't.

[Trigunflame]

Originally Posted by Oblivion Knight

Is there anything fundamentally changed by this?

The only reason I haven't installed it personally, is because Jelsoft generally do a good job at optimising their code and queries. If they could have originally saved on this query without losing some kind of functionality, I'd be wondering why they didn't.

Well good thing you asked that actually. I just noticed earlier today that I need to update this hack to reflect a change in 3.5.x that I didnt account for when i ported it from vb3.

It deals with how sessions are updated; before in vb3 it was handled in a single function; now it uses 2 seperate functions for updating the user last active and the session.

So yes, it wont hurt anything to use this small addition.. but it does need to be expanded to deal with the session table as well; which would/could save 2 queries as opposed to the 1.

[MissKalunji]

Originally Posted by Trigunflame

Well good thing you asked that actually. I just noticed earlier today that I need to update this hack to reflect a change in 3.5.x that I didnt account for when i ported it from vb3.

It deals with how sessions are updated; before in vb3 it was handled in a single function; now it uses 2 seperate functions for updating the user last active and the session.

So yes, it wont hurt anything to use this small addition.. but it does need to be expanded to deal with the session table as well; which would/could save 2 queries as opposed to the 1.

Waiting on update

[EasyTarget]

hmm... bump

[Alien]

I'm very interested in this.. I'll wait for update.

[Trigunflame]

Yes.. will be done sometime, lol lots of things on my todo list.

[Alien]

Look forward to it!

I'm currently running 3.5.4, will this mess up anything regarding sessions or can I still run this one until the other one is out?

[Zia]

Caching Template...also reduce 1 query.....this also reduce 1 ..
hope to get an update about this(Remove 1 Query Per Page) hack

[MissKalunji]

Originally Posted by Zia

Caching Template...also reduce 1 query.....this also reduce 1 ..
hope to get an update about this(Remove 1 Query Per Page) hack

accelerator :P accelerates

and compress less loading

isnt the world perfect now? lol

sure is for me

thanks! Trigunflame (i cant never spell his name right)