The Arcive of Official vBulletin Modifications Site.

BBR Google Analytics Addon · **Released**: 12-01-2009

I will no longer support vBulletin because of IB and the agile development, and they are not fixing bugs like they should. Instead they add bloat.

TeknoSounds · #**212** 01-20-2011, 02:46 AM

It works fine on mine...according to the page source it shows up just before the end of the header section.

Did you go into the options of the plugin and change them to the header and not the footer?

polle · #**213** 01-20-2011, 07:45 AM

Yes, I have "Add code just above the opening body tag" selected as yes, but the code is after the closing </head> and not before.

Any idea ?

TeknoSounds · #**214** 01-20-2011, 10:40 AM

Hmm I moved mine up and I'm now getting an error on all my pages according to firebug:

Code:

script is not defined  Line 24

Line 24 : var s = document.getElementsByTagName(script)[0]; s.parentNode.insertBefore(ga, s);

TeknoSounds · #**215** 01-20-2011, 10:46 AM

Okay, fixed the error...
In Plugin Manager -> BBR Google Analytics -> Edit

Find:

Code:

var s = document.getElementsByTagName(script)[0]; s.parentNode.insertBefore(ga, s);

Replace with:

Code:

var s = document.getElementsByTagName(\'script\')[0]; s.parentNode.insertBefore(ga, s);

note the \' around script

TeknoSounds · #**216** 01-20-2011, 10:48 AM

Quote:

Originally Posted by polle

Yes, I have "Add code just above the opening body tag" selected as yes, but the code is after the closing </head> and not before.

Any idea ?

Link to your site?

Also visit mine, do a page source, see if you're seeing it like on mine.

btw, did you upgrade it from a previous version? or a fresh install?

polle · #**217** 01-20-2011, 11:11 AM

Actually you don't have any google analytics in your forum.

See it here, is a fresh install of forum and plugin.

Thanks.

TeknoSounds · #**218** 01-21-2011, 06:16 AM

Quote:

Originally Posted by polle

Actually you don't have any google analytics in your forum.

See it here, is a fresh install of forum and plugin.

Thanks.

Oh man! thanks for pointing that out! I fubar'd the escape characters and screwed it up

Check again and it should now be showing.
Hmm you're using a different version or something compared to mine...the code that renders on yours is different.
Even though I have 1.0.3 my code in mine is different. I'm going to verify the script on googles site for async.

The good news is I also found where the error is

Checking real fast to make sure thats the right code, then will post up the fix.

TeknoSounds · #**219** 01-21-2011, 06:24 AM

Okay to fix the <body> issue:
AdminCP -> Plugin Manager -> Edit BBR Google Analytics
Find

Code:

$BBR_find='<body>';

and change it to

Code:

$BBR_find='</head>';

What I'm worried about is the change between the latest file on here and my version...the function difference is this:
Mine & on Google's site

Code:

(function() {
var ga = document.createElement('script'); ga.type = 'text/javascript'; ga.async = true;
ga.src = ('https:' == document.location.protocol ? 'https://ssl' : 'http://www') + '.google-analytics.com/ga.js';
var s = document.getElementsByTagName('script')[0]; s.parentNode.insertBefore(ga, s);
})();

versus whats in the latest file on here:

Code:

  (function() {
    var ga = document.createElement('script'); ga.type = 'text/javascript'; ga.async = true;
    ga.src = ('https:' == document.location.protocol ? 'https://ssl' : 'http://www') + '.google-analytics.com/ga.js';
    (document.getElementsByTagName('head')[0] || document.getElementsByTagName('body')[0]).appendChild(ga);
  })();

Note the last line there....

polle · #**220** 01-22-2011, 07:58 AM

Changing body to head fixed it.

About the code difference I have no idea why, in GA you get different codes ?

Thanks for the fix.

Crotan · #**221** 02-21-2011, 11:24 PM

Quote:

Originally Posted by TeknoSounds

Okay to fix the <body> issue:
AdminCP -> Plugin Manager -> Edit BBR Google Analytics
Find

Code:

$BBR_find='<body>';

and change it to

Code:

$BBR_find='</head>';

What I'm worried about is the change between the latest file on here and my version...the function difference is this:
Mine & on Google's site

Code:

(function() {
var ga = document.createElement('script'); ga.type = 'text/javascript'; ga.async = true;
ga.src = ('https:' == document.location.protocol ? 'https://ssl' : 'http://www') + '.google-analytics.com/ga.js';
var s = document.getElementsByTagName('script')[0]; s.parentNode.insertBefore(ga, s);
})();

versus whats in the latest file on here:

Code:

  (function() {
    var ga = document.createElement('script'); ga.type = 'text/javascript'; ga.async = true;
    ga.src = ('https:' == document.location.protocol ? 'https://ssl' : 'http://www') + '.google-analytics.com/ga.js';
    (document.getElementsByTagName('head')[0] || document.getElementsByTagName('body')[0]).appendChild(ga);
  })();

Note the last line there....

Do this still work? Or did 4.1.2 break it and thus make the developer flee to IPboard?

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.04935 seconds Memory Usage 2,316KB Queries Executed 25 (?)
More Information
Template Usage: (1)SHOWTHREAD (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (1)ad_showthread_beforeqr (11)bbcode_code (3)bbcode_quote (1)footer (1)forumjump (1)forumrules (1)gobutton (1)header (1)headinclude (1)modsystem_post (1)navbar (4)navbar_link (120)option (1)pagenav (1)pagenav_curpage (2)pagenav_pagelink (1)pagenav_pagelinkrel (11)post_thanks_box (2)post_thanks_box_bit (11)post_thanks_button (1)post_thanks_javascript (1)post_thanks_navbar_search (1)post_thanks_postbit (11)post_thanks_postbit_info (10)postbit (11)postbit_onlinestatus (11)postbit_wrapper (1)spacer_close (1)spacer_open (1)tagbit_wrapper Phrase Groups Available: global inlinemod postbit posting reputationlevel showthread	Included Files: ./showthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/functions_bigthree.php ./includes/class_postbit.php ./includes/class_bbcode.php ./includes/functions_reputation.php ./includes/functions_post_thanks.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete showthread_start showthread_getinfo forumjump showthread_post_start showthread_query_postids showthread_query bbcode_fetch_tags bbcode_create showthread_postbit_create postbit_factory postbit_display_start post_thanks_function_post_thanks_off_start post_thanks_function_post_thanks_off_end post_thanks_function_fetch_thanks_start fetch_musername post_thanks_function_fetch_thanks_end post_thanks_function_thanked_already_start post_thanks_function_thanked_already_end post_thanks_function_fetch_thanks_bit_start post_thanks_function_show_thanks_date_start post_thanks_function_show_thanks_date_end post_thanks_function_fetch_thanks_bit_end post_thanks_function_fetch_post_thanks_template_start post_thanks_function_fetch_post_thanks_template_end postbit_imicons bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete postbit_display_complete post_thanks_function_can_thank_this_post_start pagenav_page pagenav_complete tag_fetchbit_complete forumrules navbits navbits_complete showthread_complete
Messages:

2 благодарности(ей) от:
comunidadmh, misericorde

The Arcive of Official vBulletin Modifications Site.

It is not a VB3 engine, just a parsed copy!