Login by username or email

This code modification was made as part of a request in this thread: https://vborg.vbsupport.ru/showthrea...5&page=1&pp=15

All that it does is allow to use the email address instead of the username to be used to login (username also still works).

Since people where stating that it should be released, well here it goes.

1 File edit:
in file includes/functions_login.php, find:

PHP Code:

    if ($vbulletin->userinfo = $vbulletin->db->query_first("SELECT userid, usergroupid, membergroupids, username, password, salt FROM " . TABLE_PREFIX . "user WHERE username = '" . $vbulletin->db->escape_string(htmlspecialchars_uni($username)) . "'")) 


and replace by:

PHP Code:

 // Start hack login with mail address (MarcoH64)
//    if ($vbulletin->userinfo = $vbulletin->db->query_first("SELECT userid, usergroupid, membergroupids, username, password, salt FROM " . TABLE_PREFIX . "user WHERE username = '" . $vbulletin->db->escape_string(htmlspecialchars_uni($username)) . "'"))
if (!$vbulletin->userinfo = $vbulletin->db->query_first("SELECT userid, usergroupid, membergroupids, username, password, salt FROM " . TABLE_PREFIX . "user WHERE username = '" . $vbulletin->db->escape_string(htmlspecialchars_uni($username)) . "'"))
{
$vbulletin->userinfo = $vbulletin->db->query_first("SELECT userid, usergroupid, membergroupids, username, password, salt FROM " . TABLE_PREFIX . "user WHERE email = '" . $vbulletin->db->escape_string(htmlspecialchars_uni($username)) . "'");
}
if ($vbulletin->userinfo)
// End hack login with mail address (MarcoH64) 


This will allow logging in with either mail or username.

[Marco van Herwaarden]

just replace email with userid and you're done.

[mikehawk]

Register by email would be good as well...

[dcpaq2xx]

I was doing some playing around with this hack and something that I noticed was that if you have more than one user name assigned to the same email address it cannot tell which one to login as and it logs you in on the first one in the user id list.

Other than that it seems to work fine.

Thank you for taking the time to create this hack Marco, Im still undecided as of right now though If ill be using this hack or not.

Doug

[Marco van Herwaarden]

Originally Posted by dcpaq2

I was doing some playing around with this hack and something that I noticed was that if you have more than one user name assigned to the same email address it cannot tell which one to login as and it logs you in on the first one in the user id list.

Well that would make sense. I don't think this is the right hack if you allow multiple users (although they are probably all the same person) to share 1 mail address.

[Tim Simms]

Maybe instead of:

PHP Code:

// Start hack login with mail address (MarcoH64)
//    if ($vbulletin->userinfo = $vbulletin->db->query_first("SELECT userid, usergroupid, membergroupids, username, password, salt FROM " . TABLE_PREFIX . "user WHERE username = '" . $vbulletin->db->escape_string(htmlspecialchars_uni($username)) . "'"))
if (!$vbulletin->userinfo = $vbulletin->db->query_first("SELECT userid, usergroupid, membergroupids, username, password, salt FROM " . TABLE_PREFIX . "user WHERE username = '" . $vbulletin->db->escape_string(htmlspecialchars_uni($username)) . "'"))
{
$vbulletin->userinfo = $vbulletin->db->query_first("SELECT userid, usergroupid, membergroupids, username, password, salt FROM " . TABLE_PREFIX . "user WHERE email = '" . $vbulletin->db->escape_string(htmlspecialchars_uni($username)) . "'");
}
if ($vbulletin->userinfo)
// End hack login with mail address (MarcoH64) 


...you could do this:

PHP Code:

// Start hack login with mail address (MarcoH64)
//    if ($vbulletin->userinfo = $vbulletin->db->query_first("SELECT userid, usergroupid, membergroupids, username, password, salt FROM " . TABLE_PREFIX . "user WHERE username = '" . $vbulletin->db->escape_string(htmlspecialchars_uni($username)) . "'"))
        if (!$vbulletin->userinfo = $vbulletin->db->query_first("SELECT userid, usergroupid, membergroupids, username, password, salt FROM " . TABLE_PREFIX . "user WHERE username = '" . $vbulletin->db->escape_string(htmlspecialchars_uni($username)) . "'"))
        {
                if (($result = $vbulletin->db->query("SELECT userid, usergroupid, membergroupids, username, password, salt FROM " . TABLE_PREFIX . "user WHERE email = '" . $vbulletin->db->escape_string(htmlspecialchars_uni($username)) . "'")) && $vbulletin->db->num_rows($result) > 1)
                {
                        // Do some sort of notification to user
                        // saying that email address is ambiguous
                }
                else
                {
                        $vbulletin->userinfo = $vbulletin->db->fetch_array($result);
                        $vbulletin->db->free_result($result);
                }
        } 


I did it on ours, and at least it prevents a shared email address from logging into any of them. Of course, I don't have any feedback to the user, cuz I don't know how...

[Marco van Herwaarden]

That is a good suggestion and i might add it to a next (??) release.

[Smiry Kin's]

does this work on 3.5.4?

[BaBa2002]

Originally Posted by MarcoH64

email only would even be easier, just replace 1 word in the original file.

what do you mean with just replace 1 word?
for just email registration? and witch word?

[xr8d76]

where/how do you add on the login boxes, instead of it just showing:

username:
Password:

TO

Username/Email:
Password:

Pls and thx

[Smiry Kin's]

Originally Posted by xr8d76

where/how do you add on the login boxes, instead of it just showing:

username:
Password:

TO

Username/Email:
Password:

Pls and thx

search parse "User Name"

maybe?