Attachment Upload by URL

/*================================================= =====================*\
|| Attachment Upload by URL
|| Author : Psionic Vision
|| Works on : vBulletin 3.0.7 Only
\*================================================ ======================*/

There have been some requests for attachment upload by URL option... So here it is - my atttempt to create something like this. I am not sure that the way I did it is completely valid, but it does work. That is why I put it in beta releases. The code is fairly short, so it will not take more than one minute to install or remove it.

What this does is, it allows a user to upload an attachment from an URL rather than directly from user's computer. Sometime it is very useful.

Please test it out and comment and/or criticize. Thanks.

Edit: A fix was posted, please see this post:
https://vborg.vbsupport.ru/showpost....7&postcount=14
This fix is included into the new manual.

[Zachery]

Originally Posted by reminder

Not working. Error "Please select a file to attach using the "Browse..." button."

Please do not report a post if its not working for you. You should contact the author or uninstall the hack

[Reminder]

Originally Posted by Zachery

Please do not report a post if its not working for you. You should contact the author or uninstall the hack

Oppps. Sory. Ok.

[Lionel]

Your problem is in the javascript in template that checks for a value in upload field.

[akanevsky]

Sorry, I forgot to include that into the instructions. Will update them in a minute.

The fix is as follows:

In template 'newattachment', find:

if (elm.type == 'file')

and replace with:

if ((elm.type == 'file') || (elm.type == 'text'))

[AN-net]

from the looks of it this hack requires curl which is not a standard library, you should mention this in the first post

pretty cool though, i may look into it

[Trigunflame]

Originally Posted by AN-net

from the looks of it this hack requires curl which is not a standard library, you should mention this in the first post

pretty cool though, i may look into it

Yes he is using curl.
This can be done much easier with fopen.

I have not Installed this hack, or tested my file change.. It should work though.

Replace the Code he gives in the install file with this.

PHP Code:

        if (is_array($_POST['attachmenturl']))
        {
            foreach ($_POST['attachmenturl'] AS $key => $url)
            {
                // attempt to fetch the filename from the url
                preg_match('/\/([A-z0-9]*)([\.]{1})([A-z0-9]{2,6})$/si', $url, $matches);
                $filename['original'] = str_replace("/", "", $matches[0]);

                // did we retrieve a valid filename?
                $validurl = iif(!empty($url) AND !empty($filename['original']), true, false);

                /*
                 * FOPEN Modification By Trigunflame
                 */
                // valid url
                if ($validurl)
                {
                    // init
                    $data = '';

                    // cancel the file that might have been uploaded
                    unset($_FILES["attachment{$key}"]);

                    // attempt opening of remote file
                    if ($fileOpen = @fopen($url, "rb"))
                    {
                        while (!feof($fileOpen))
                        {
                            $data = @fread($fileOpen, 4096);
                        }
                        @fclose($fileOpen);
                    }

                    // empty
                    if (empty($data))
                    {
                        $error = construct_phrase($vbphrase['error_cannot_retrieve_url'], $url);
                        $errors[] = array(
                            'filename' => htmlspecialchars_uni($url),
                            'error' => $error
                        );
                    }

                    // save file
                    else
                    {
                        $tmp_name = 'vbupload' . substr(TIMENOW, -4);
                        $filesize = strlen($data);
    
                        // write file to temporary directory...
                        if ($vboptions['safeupload'])
                        {
                            // ... in safe mode
                            $filename['temp'] = $vboptions['tmppath'] . "/$tmp_name";
                            $filenum = @fopen($filename['temp'], 'wb');
                            @fwrite($filenum, $data);
                            @fclose($filenum);
                        }
                        else
                        {
                            // ... in normal mode
                            $filename['temp'] = tempnam(ini_get('upload_tmp_dir'), 'vbupload');
                            $fp = @fopen($filename['temp'], 'wb');
                            @fwrite($fp, $data);
                            @fclose($fp);
                        }

                        $_FILES["attachment$key"]['name'] = $filename['original'];
                        $_FILES["attachment$key"]['type'] = '';
                        $_FILES["attachment$key"]['size'] = $filesize;
                        $_FILES["attachment$key"]['tmp_name'] = $filename['temp'];
                        $_FILES["attachment$key"]['error'] = 0;
                        $_FILES["attachment$key"]['url_upload_by_curl'] = 1;
                    }
                }
            }
        } 


[Allan]

screenshot please, just for looking ?

[Reminder]

Originally Posted by Dark Visor

Then you did not install it correctly. What is your vB version?

Vbulletin Version 3.0.7

[Boofo]

Originally Posted by Trigunflame

Yes he is using curl.
This can be done much easier with fopen.

I have not Installed this hack, or tested my file change.. It should work though.

Replace the Code he gives in the install file with this.

PHP Code:

        if (is_array($_POST['attachmenturl']))
        {
            foreach ($_POST['attachmenturl'] AS $key => $url)
            {
                // attempt to fetch the filename from the url
                preg_match('/\/([A-z0-9]*)([\.]{1})([A-z0-9]{2,6})$/si', $url, $matches);
                $filename['original'] = str_replace("/", "", $matches[0]);
 
                // did we retrieve a valid filename?
                $validurl = iif(!empty($url) AND !empty($filename['original']), true, false);
 
                /*
                 * FOPEN Modification By Trigunflame
                 */
                // valid url
                if ($validurl)
                {
                    // init
                    $data = '';
 
                    // cancel the file that might have been uploaded
                    unset($_FILES["attachment{$key}"]);
 
                    // attempt opening of remote file
                    if ($fileOpen = @fopen($url, "rb"))
                    {
                        while (!feof($fileOpen))
                        {
                            $data = @fread($fileOpen, 4096);
                        }
                        @fclose($fileOpen);
                    }
 
                    // empty
                    if (empty($data))
                    {
                        $error = construct_phrase($vbphrase['error_cannot_retrieve_url'], $url);
                        $errors[] = array(
                            'filename' => htmlspecialchars_uni($url),
                            'error' => $error
                        );
                    }
 
                    // save file
                    else
                    {
                        $tmp_name = 'vbupload' . substr(TIMENOW, -4);
                        $filesize = strlen($data);
 
                        // write file to temporary directory...
                        if ($vboptions['safeupload'])
                        {
                            // ... in safe mode
                            $filename['temp'] = $vboptions['tmppath'] . "/$tmp_name";
                            $filenum = @fopen($filename['temp'], 'wb');
                            @fwrite($filenum, $data);
                            @fclose($filenum);
                        }
                        else
                        {
                            // ... in normal mode
                            $filename['temp'] = tempnam(ini_get('upload_tmp_dir'), 'vbupload');
                            $fp = @fopen($filename['temp'], 'wb');
                            @fwrite($fp, $data);
                            @fclose($fp);
                        }
 
                        $_FILES["attachment$key"]['name'] = $filename['original'];
                        $_FILES["attachment$key"]['type'] = '';
                        $_FILES["attachment$key"]['size'] = $filesize;
                        $_FILES["attachment$key"]['tmp_name'] = $filename['temp'];
                        $_FILES["attachment$key"]['error'] = 0;
                        $_FILES["attachment$key"]['url_upload_by_curl'] = 1;
                    }
                }
            }
        } 


I get a filesize stats failed error with this code.

[Lionel]

Can't get the fopen() code to work either.