Unnecessary query?

[Andreas]

http://www.vbulletin.com/forum/bugs....iew&bugid=2224

Status: Closed (Fixed)

But no reply So I guess i'll have to wait for the next RC ...

[Xenon]

yes you have...

btw, you're showing up unlicensed now...

[Andreas]

I do? I don't get that "You're unlicensed remider"
Anyway, that's bollox

I've had problems to get rid of that "you're unlicensed" at vB-germany.com and they suggested to remove my email from the member area and afterwards add it again.
I did so ... that could be the reason.

[NTLDR]

Either way its worked and you appear licenced again. Good to see this nasty bug fixed too

[Xenon]

yes, that would explain the short unlicensed period

[Natch]

To confirm, does the bug report showing fixed in RC4 mean that it was reported under RC4 ? or fixed for RC4 ?

[Freddie Bingham]

Originally Posted by Natch

To confirm, does the bug report showing fixed in RC4 mean that it was reported under RC4 ? or fixed for RC4 ?

Fixed for Gold. Try this:

PHP Code:

        else
        { // imodcache is not set - do a query

            if (isset($modcache["$userid"]))
            {
                return $modcache["$userid"];
            }

            $modcache["$userid"] = 0;

            DEVDEBUG('QUERY: is the user a moderator (any forum)?');
            $ismod_all = $DB_site->query("SELECT moderatorid, permissions FROM " . TABLE_PREFIX . "moderator WHERE userid = $userid");
            while ($ismod = $DB_site->fetch_array($ismod_all))
            {
                if ($do)
                {
                    if ($ismod['permissions'] & $_BITFIELD['moderatorpermissions']["$do"])
                    {
                        $modcache["$userid"] = 1;
                        break;
                    }
                }
                else
                {
                    $modcache["$userid"] = 1;
                    break;
                }
            }

            return $modcache["$userid"];
        } 


As for can_moderate generating a query on many pages for non admins/supermods, I didn't even realize that was happening. I don't think that is really acceptable so we will see what we can do about it.

[Freddie Bingham]

Originally Posted by freddie

Fixed for Gold. Try this:

PHP Code:

        else
        { // imodcache is not set - do a query

            if (isset($modcache["$userid"]))
            {
                return $modcache["$userid"];
            }

            $modcache["$userid"] = 0;

            DEVDEBUG('QUERY: is the user a moderator (any forum)?');
            $ismod_all = $DB_site->query("SELECT moderatorid, permissions FROM " . TABLE_PREFIX . "moderator WHERE userid = $userid");
            while ($ismod = $DB_site->fetch_array($ismod_all))
            {
                if ($do)
                {
                    if ($ismod['permissions'] & $_BITFIELD['moderatorpermissions']["$do"])
                    {
                        $modcache["$userid"] = 1;
                        break;
                    }
                }
                else
                {
                    $modcache["$userid"] = 1;
                    break;
                }
            }

            return $modcache["$userid"];
        } 


As for can_moderate generating a query on many pages for non admins/supermods, I didn't even realize that was happening. I don't think that is really acceptable so we will see what we can do about it.

Oops I see that could have a problem if you call can_moderate() on the same user using different 'do' actions. I'll have to fix that one but this should get you by.

[filburt1]

Good thing it was fixed...I relied on this function for a lot of stuff in custom templates I develop.

[Boofo]

Where would you add that code at?