Go Back   vb.org Archive > vBulletin 4 Discussion > vB4 Programming Discussions

Reply
 
Thread Tools Display Modes
  #11  
Old 03-18-2016, 01:32 AM
webmastersun's Avatar
webmastersun webmastersun is offline
 
Join Date: Oct 2013
Location: www.webmastersun.com
Posts: 433
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by Paul M View Post
...."its perfectly fine"....
if so, I think it will have social connect? which allows visitors to register/login with their social network (Twitter, Facebook, Google+...) accounts?
I will update to this version if vB 4.2.4 has this function.
Reply With Quote
  #12  
Old 03-18-2016, 02:51 AM
RichieBoy67's Avatar
RichieBoy67 RichieBoy67 is offline
 
Join Date: Apr 2004
Location: CT - Down in a hole..
Posts: 3,057
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Well to be fair here the fact that 4.2.3 will delete your attachments sometimes is not good. Hopefully this issue will be addressed with the next version.

I have a couple sites already updated to 4.2.3 that I cannot rebuild attachments on ever for fear of losing them.
Reply With Quote
2 благодарности(ей) от:
ArcadeSyndicate, Gio~Logist
  #13  
Old 03-22-2016, 09:13 PM
Mark.B Mark.B is offline
Senior Member
 
Join Date: Feb 2004
Posts: 1,354
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

4.2.3 doesn't delete attachments at all, and whether you rebuild them makes zero difference.

What happened in those cases is this:

vB4 was always supposed to have a cron job that ran to delete any attachments marked as 'unused'. Unused means the post(s) they were in were deleted, so in effect the attachment is 'orphaned'...it exists but isn't used anywhere. They are marked as unused by the refcount value.

The script that was meant to run regularly to delete these unused attachments was broken and had been for years....in 4.2.3 it got fixed, so any unused attachments then got deleted, which is entirely correct.

The sites that experienced problems with ALL attachments being deleted, had an issue whereby the refcount values for their attachments had got corrupted some time way back in the past, meaning ALL their attachments were mrked as unused. This previously didn't have any effect, since the attachment deletion cron didn't work. But as of 4.2.3, it did.....so such sites lost all their attachments. This issue could not have been reasonably foreseen, and it's a good example of why you NEVER UPGRADE WITHOUT A FULL BACKUP. We don't say it for fun.

In 4.2.4, Paul has added a refcount check to the upgrade script, so this issue won't arise in 4.2.4 onwards, as the refcounts will be fixed if they're wrong.

The overwhelming majority of sites were NOT affected by this issue, it was just a small handful.
Reply With Quote
2 благодарности(ей) от:
Lynne, MarkFL
  #14  
Old 03-22-2016, 10:16 PM
Manoel J?nior Manoel J?nior is offline
 
Join Date: Feb 2009
Location: SP / Brasil
Posts: 778
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

If I knew it before
Reply With Quote
  #15  
Old 03-23-2016, 08:43 PM
Mark.B Mark.B is offline
Senior Member
 
Join Date: Feb 2004
Posts: 1,354
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by Manoel J?nior View Post
If I knew it before
Yes, but we didn't know it before either....that's the point.

However, if you do as we have always recommended and take a full backup of both files and database before upgrading, it can all be easily fixed afterwards.
Reply With Quote
  #16  
Old 03-24-2016, 05:00 PM
Lynne's Avatar
Lynne Lynne is offline
 
Join Date: Sep 2004
Location: California/Idaho
Posts: 41,180
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by Mark.B View Post
4.2.3 doesn't delete attachments at all, and whether you rebuild them makes zero difference.

What happened in those cases is this:

.....
(see two posts above for full quote)

Great explanation, Mark! :up:
Reply With Quote
Благодарность от:
MarkFL
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT. The time now is 03:38 PM.


Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2024, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.06296 seconds
  • Memory Usage 2,234KB
  • Queries Executed 12 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)ad_showthread_beforeqr
  • (1)ad_showthread_firstpost
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (3)bbcode_quote
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)navbar
  • (3)navbar_link
  • (120)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (1)pagenav_pagelink
  • (6)post_thanks_box
  • (5)post_thanks_box_bit
  • (6)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (3)post_thanks_postbit
  • (6)post_thanks_postbit_info
  • (6)postbit
  • (6)postbit_onlinestatus
  • (6)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available:
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files:
  • ./showthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • forumjump
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • fetch_musername
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • post_thanks_function_fetch_thanks_bit_start
  • post_thanks_function_show_thanks_date_start
  • post_thanks_function_show_thanks_date_end
  • post_thanks_function_fetch_thanks_bit_end
  • post_thanks_function_fetch_post_thanks_template_start
  • post_thanks_function_fetch_post_thanks_template_end
  • pagenav_page
  • pagenav_complete
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • showthread_complete