Go Back   vb.org Archive > vBulletin 4 Discussion > vB4 Programming Discussions

Reply
 
Thread Tools Display Modes
  #11  
Old 11-03-2014, 10:05 AM
Morrus Morrus is offline
 
Join Date: Jan 2002
Posts: 494
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Thanks, guys! That was really useful. I think that has helped me narrow it down to two possible culprits.

The bad news is that both were mods written by people in the paid work section here at vBulletin.org, and almost without exception, 100% of people hired there flake out and disappear. Which leaves me in something of a pickle...

What would you advise I do next? Try to hire someone to look at those two mods and see if they can figure out the issue?

Edit - confirmed; deactivating one of the two culprits fixes the issue, so at least is has been identified! The plugin itself is pretty short. Is it likely that the error is there in that short plugin, or will someone have to examine the entire mod?
Reply With Quote
  #12  
Old 11-03-2014, 10:09 AM
ozzy47's Avatar
ozzy47 ozzy47 is offline
 
Join Date: Jul 2009
Location: USA
Posts: 10,929
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

What was the code in the offending plugin?
Reply With Quote
  #13  
Old 11-03-2014, 10:12 AM
Morrus Morrus is offline
 
Join Date: Jan 2002
Posts: 494
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by ozzy47 View Post
What was the code in the offending plugin?
Here we go. Hopefully this will display OK. It's part of aa mod which counts the number of times an article is viewed in preview mode, since I always use full article display in sections.

Code:
if (self::VIEW_PREVIEW == $viewtype) {
    if ($increment_count) {
        if (PreviewViewCount::$content->isSection() && PreviewViewCount::display()) {
            ExtendedDatabases_Query::write(array(
                'query' => 'UPDATE `%1$scms_nodeinfo`
                    SET `preview_view_list` = `preview_view_list` + 1
                        WHERE `nodeid` = %2$d',
                'params' => $this->content->getNodeId()
            ));

            if (!defined('PREVIEW_COUNT_FIRST')) {
                ExtendedDatabases_Query::write(array(
                    'query' => 'UPDATE `%1$scms_nodeinfo`
                        SET `preview_view_first` = `preview_view_first` + 1
                            WHERE `nodeid` = %2$d',
                    'params' => $this->content->getNodeId()
                ));

                define('PREVIEW_COUNT_FIRST', true);
            }
        }
    }
}
Reply With Quote
  #14  
Old 11-03-2014, 04:04 PM
kh99 kh99 is offline
 
Join Date: Aug 2009
Location: Maine
Posts: 13,185
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Unfortunately that doesn't help a lot. It must be that PreviewViewCount::$content is not an object, but we'd have to see more of the code to have any chance of knowing why that is. You might be able to change the third line to something like:

Code:
if (is_object(PreviewViewCount::$content) && PreviewViewCount::$content->isSection() && PreviewViewCount::display()) {

(the part in red is added), and it might make the error message go away, but without understanding more of the code I can't tell you what effect that would have on the preview counting.
Reply With Quote
  #15  
Old 11-03-2014, 05:50 PM
Morrus Morrus is offline
 
Join Date: Jan 2002
Posts: 494
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Thank you! That may have worked! I'll keep an eye on it, but at first glance it looks like the preview counts are still incrementing and the category links are now working.
Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT. The time now is 06:27 PM.


Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2024, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.05272 seconds
  • Memory Usage 2,197KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)ad_showthread_beforeqr
  • (1)ad_showthread_firstpost
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (2)bbcode_code
  • (1)bbcode_quote
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)navbar
  • (3)navbar_link
  • (120)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (1)pagenav_pagelink
  • (5)post_thanks_box
  • (5)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (5)post_thanks_postbit_info
  • (5)postbit
  • (5)postbit_onlinestatus
  • (5)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available:
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files:
  • ./showthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • forumjump
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • pagenav_page
  • pagenav_complete
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • showthread_complete