Using vb:raw in templates

[Scanu]

PHP Code:

$vbulletin->input->clean_gpc('r', 'do', TYPE_STR);
$do = $vbulletin->GPC['do'];
if (!isset($do))
$do = 1; //default value

if ($do == 1) {

}
if ($do == 2) {

}
if ($do == 3) {

}
if ($do == 4) {

} 


[cellarius]

Originally Posted by Black Snow

Your link doesn't show how to use $vbulletin->input->clean_array_gpc when requesting a page. Could you show me an example?

Of course it does.

Cleaning Superglobal Arrays

By Superglobal, I mean $_POST, $_GET, $_REQUEST and so on. These arrays are created automaticly by PHP and contain the user-sent input. They are referenced in the vBulletin Input Cleaner by nice short single letter names. These are:
p - $_POST
g - $_GET
r - $_REQUEST
s - $_SERVER
e - $_ENV
c - $_COOKIE
f - $_FILES

and so on.

[Black Snow]

Originally Posted by Scanu

PHP Code:

$vbulletin->input->clean_gpc('r', 'do', TYPE_STR);
$do = $vbulletin->GPC['do'];
if (!isset($do))
$do = 1; //default value

if ($do == 1) {

}
if ($do == 2) {

}
if ($do == 3) {

}
if ($do == 4) {

} 


Thanks for the example. Makes me understand more now.

--------------- Added [DATE]1409646066[/DATE] at [TIME]1409646066[/TIME] ---------------

Originally Posted by Scanu

PHP Code:

$vbulletin->input->clean_gpc('r', 'do', TYPE_STR);
$do = $vbulletin->GPC['do'];
if (!isset($do))
$do = 1; //default value

if ($do == 1) {

}
if ($do == 2) {

}
if ($do == 3) {

}
if ($do == 4) {

} 


I tried doing this but it won't work if I access the info.php page without the query on the end of the URL:

$vbulletin->input->clean_gpc('r', 'do', TYPE_STR);
$do = $vbulletin->GPC['do'];
if (!isset($do))
//default value
$do = "siterules";


//Use as http:/site.com/info.php?do=siterules
if ($do == "siterules") {
$pagetitle = 'General Site Rules';
$templater = vB_Template::create('siterules');
$templater->register_page_templates();
$templater->register('navbar', $navbar);
$templater->register('pagetitle', $pagetitle);
$templater->register('custom_nav', $custom_nav);
print_output($templater->render());
exit;
}

[Scanu]

Originally Posted by Black Snow

Thanks for the example. Makes me understand more now.

--------------- Added [DATE]1409646066[/DATE] at [TIME]1409646066[/TIME] ---------------


I tried doing this but it won't work if I access the info.php page without the query on the end of the URL:

$vbulletin->input->clean_gpc('r', 'do', TYPE_STR);
$do = $vbulletin->GPC['do'];
if (!isset($do))
//default value
$do = "siterules";


//Use as http:/site.com/info.php?do=siterules
if ($do == "siterules") {
$pagetitle = 'General Site Rules';
$templater = vB_Template::create('siterules');
$templater->register_page_templates();
$templater->register('navbar', $navbar);
$templater->register('pagetitle', $pagetitle);
$templater->register('custom_nav', $custom_nav);
print_output($templater->render());
exit;
}

Try replacing this

PHP Code:

$vbulletin->input->clean_gpc('r', 'do', TYPE_STR);
$do = $vbulletin->GPC['do'];
if (!isset($do))
//default value
$do = "siterules"; 


With this

PHP Code:

if (!isset($_REQUEST['do'])
$_REQUEST['do'] = 'siterules';
$vbulletin->input->clean_gpc('r', 'do', TYPE_STR);
$do = $vbulletin->GPC['do']; 


[Black Snow]

Originally Posted by Scanu

Try replacing this

PHP Code:

$vbulletin->input->clean_gpc('r', 'do', TYPE_STR);
$do = $vbulletin->GPC['do'];
if (!isset($do))
//default value
$do = "siterules"; 


With this

PHP Code:

if (!isset($_REQUEST['do'])
$_REQUEST['do'] = 'siterules';
$vbulletin->input->clean_gpc('r', 'do', TYPE_STR);
$do = $vbulletin->GPC['do']; 


Thanks for helping. I still get a blank page.

[Scanu]

I can't see anything wrong now, and I don't have time right now to test it
Maybe this code could make a difference

PHP Code:

[PHP]
$vbulletin->input->clean_gpc('r', 'do', TYPE_STR); 
$do = $vbulletin->GPC['do'];
if (!isset($_REQUEST['do']) 
$do = 'siterules'; 


[/PHP]

[kh99]

There is a $vbulletin->GPC_exists[] array, so you could try this:

$vbulletin->input->clean_gpc('r', 'do', TYPE_STR);
if ($vbulletin->GPC_exists['do'])
   $do = $vbulletin->GPC['do'];
else
   $do = "siterules";

// etc

Another thing you could do is just make 'siterules' the default 'else':

$vbulletin->input->clean_gpc('r', 'do', TYPE_STR);
$do = $vbulletin->GPC['do'];

if ($do == 'something')
{
 // something
}
else if ($do == 'somethingelse')
{
// something else
}
else // default to siterules
{
  // siterules
}

BTW, I'm not a php expert so I'm not going to argue with what's correct and what's "evil", but I would say that there was nothing actually wrong with what you originally had (as far as introducing vulnerabilities), and in fact the vb scripts do it that way (just for the 'do' variable).