Go Back   vb.org Archive > vBulletin 4 Discussion > vB4 Programming Discussions

Reply
 
Thread Tools Display Modes
  #11  
Old 10-23-2012, 06:38 PM
Lynne's Avatar
Lynne Lynne is offline
 
Join Date: Sep 2004
Location: California/Idaho
Posts: 41,180
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

It is being called, however I believe the template gets evaled before it is called, so doing the preregister of the variable may not be working. (You'd have to do a str_replace in the evaled template instead.)
Reply With Quote
  #12  
Old 10-23-2012, 06:40 PM
kh99 kh99 is offline
 
Join Date: Aug 2009
Location: Maine
Posts: 13,185
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

I think the problem might be that the template name used by PMs is "postbit" and not "postbit_legacy", or at least that's what it shows in the html comments. Try changing the preRegister call to 'postbit', or just do preRegister twice, once each to 'postbit' and 'postbit_legacy', and see if that works.

BTW, if that is all the plugin code you don't need the ob_ calls, you could just replace the "echo"s with "$php_include = " and remove all the ob_ lines. Also, if you replace only the style= part instead of the entire <div> tag, it won't mess up the html even if the variable is blank.

Edit: or it might be what Lynne said - I was typing while she posted.
Reply With Quote
  #13  
Old 10-23-2012, 06:46 PM
Revelence Revelence is offline
 
Join Date: Apr 2011
Posts: 44
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by Lynne View Post
It is being called, however I believe the template gets evaled before it is called, so doing the preregister of the variable may not be working. (You'd have to do a str_replace in the evaled template instead.)
Quote:
Originally Posted by kh99 View Post
I think the problem might be that the template name used by PMs is "postbit" and not "postbit_legacy", or at least that's what it shows in the html comments. Try changing the preRegister call to 'postbit', or just do preRegister twice, once each to 'postbit' and 'postbit_legacy', and see if that works.

BTW, if that is all the plugin code you don't need the ob_ calls, you could just replace the "echo"s with "$php_include = " and remove all the ob_ lines. Also, if you replace only the style= part instead of the entire <div> tag, it won't mess up the html even if the variable is blank.

Edit: or it might be what Lynne said - I was typing while she posted.
See if it were that problem, then there wouldn't be a problem with the PM's in the first place because it wouldn't read the postbit_legacy which I made edits to.

I'll try with the just replacing the style, as that would be a lot easier and did not think of that, not quite sure how I didn't lol

--------------- Added [DATE]1351021778[/DATE] at [TIME]1351021778[/TIME] ---------------

Okay I did what you said, Kh99. Just make it edit the style, and add a background. Which works, it doesn't mass up any PM templates, and adds a background correctly.

I appreciate your help with this. Thanks.
Reply With Quote
  #14  
Old 10-23-2012, 06:56 PM
kh99 kh99 is offline
 
Join Date: Aug 2009
Location: Maine
Posts: 13,185
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by Revelence View Post
See if it were that problem, then there wouldn't be a problem with the PM's in the first place because it wouldn't read the postbit_legacy which I made edits to.
Well it's obviously displaying postbit_legacy just from looking at it. But the way the postbit/legacy switching works is weird, and like I said, when you turn on template names in html comments it says "postbit_legacy" when viewing the forum, but "postbit" when viewing a pm, so I was guessing that the preregistering was also getting confused. It could also be what Lynne said except that I'm pretty sure postbit_display_start is called before the template is rendered.

In any case I guess it doesn't matter now.
Reply With Quote
  #15  
Old 10-23-2012, 06:59 PM
Revelence Revelence is offline
 
Join Date: Apr 2011
Posts: 44
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by kh99 View Post
Well it's obviously displaying postbit_legacy just from looking at it. But the way the postbit/legacy switching works is weird, and like I said, when you turn on template names in html comments it says "postbit_legacy" when viewing the forum, but "postbit" when viewing a pm, so I was guessing that the preregistering was also getting confused. It could also be what Lynne said except that I'm pretty sure postbit_display_start is called before the template is rendered.

In any case I guess it doesn't matter now.
Yeah that does seem pretty weird how it works I guess, but it's fixed now and I appreciate your help. Thanks again.
Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT. The time now is 02:12 PM.


Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.04163 seconds
  • Memory Usage 2,200KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)ad_showthread_beforeqr
  • (1)ad_showthread_firstpost
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (4)bbcode_quote
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)navbar
  • (3)navbar_link
  • (120)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (1)pagenav_pagelink
  • (5)post_thanks_box
  • (5)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (5)post_thanks_postbit_info
  • (5)postbit
  • (5)postbit_onlinestatus
  • (5)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available:
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files:
  • ./showthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • forumjump
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • pagenav_page
  • pagenav_complete
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • showthread_complete