Form error

[Artistichaven]

Originally Posted by kh99

That's a good question, and I just now figured it out: the print_form_header() function is adding do on the url *and* as a hidden field, and the hidden field value is run through htmlspecialchars(), so the '&' gets encoded and it looks like one field. I guess this hidden POSTed field is overriding the GET value for do on the url. So maybe your existing code would work if you used $_GET for do and u and $_REQUEST for the rest of the values.



I think you need {$vbulletin->GPC['userid']} to make it so you don't get "Array['userid'] ".

I changed it from if ($_REQUEST['do'] == 'banned') to $_GET and it didn't work. Maybe I should try displaying the URL.

[kh99]

Yeah, I wish I understood this: I put a print_r($_GET) in the code and got this:

Array ( [do] => banned&u=1 [u] => 1 [userid] => 1 )

So somehow it's actually finding the u parameter, but insists on lumping it in with the do value as well. I changed the print_form_head() code to 'do=banned&u=1' and it makes no difference to what's in the $_GET array.

[Artistichaven]

How did you check it?

[kh99]

I created a plugin using hook location misc_start and this code:

if ($_REQUEST['do'] == 'form')
{
   require_once("includes/adminfunctions.php");
  $userid = 1;
  print_form_header('misc', 'banned&u=' . $userid);
  print_table_header("Ban a User");
  print_label_row("Ban: " . $username);
  print_select_row("Ban Length", 'banLength', array(24 => "1 Day", 48 => "2 Days", 72 => "3 Days", 168 => "1 Week", 336 => "2 Weeks", 720 => "1 Month", -1 => "Permanently"), $vbulletin->GPC['userid']);
  print_input_row("Ban Reason:", 'banreason');
  print_submit_row("Ban");
    exit;
}
if (strpos($_GET['do'], 'banned') === 0)
{
    echo "banned userid=" . $_REQUEST['userid'] . "<BR />\n";
    print_r($_GET);
    exit;
}

Then I go to url misc.php&do=form, then submit the form.

I think I'm going to try a non-vb test file and see if maybe some vb code is messing with $_GET[do].

[Artistichaven]

Originally Posted by kh99

I created a plugin using hook location misc_start and this code:

if ($_REQUEST['do'] == 'form')
{
   require_once("includes/adminfunctions.php");
  $userid = 1;
  print_form_header('misc', 'banned&u=' . $userid);
  print_table_header("Ban a User");
  print_label_row("Ban: " . $username);
  print_select_row("Ban Length", 'banLength', array(24 => "1 Day", 48 => "2 Days", 72 => "3 Days", 168 => "1 Week", 336 => "2 Weeks", 720 => "1 Month", -1 => "Permanently"), $vbulletin->GPC['userid']);
  print_input_row("Ban Reason:", 'banreason');
  print_submit_row("Ban");
    exit;
}
if (strpos($_GET['do'], 'banned') === 0)
{
    echo "banned userid=" . $_REQUEST['userid'] . "<BR />\n";
    print_r($_GET);
    exit;
}

Then I go to url misc.php&do=form, then submit the form.

I think I'm going to try a non-vb test file and see if maybe some vb code is messing with $_GET[do].

I got it to work! Your error here was "'banned&u='" it should have been "'banned&u="

[kh99]

Yep...and I was sure I tried that, but I must have messed it up.

Anyway, I also made a file called testform.php containing only this:

<?php
print_r($_GET);
?>

and changed the form script to 'testform', and I got this:

Array ( [do] => banned [u] => 1 )

even with 'do=banned&u=1' (no & ).

So I guess the 'problem' is that the vb startup code is doing something with the 'do' value. I put 'problem' in quotes because there may be a good reason for it that I don't understand.

Anyway, sounds like you've got it solved.

[Boofo]

Originally Posted by Artistichaven

I got it to work! Your error here was "'banned&u='" it should have been "'banned&u="

They should have both worked in that case as & = &.

& is the validated way to use &.