Portal Software - A Better News Module Fix for vBadvanced CMPS 2.2.1

vBadvanced has released CMPS 2.2.1 with a substandard fix to the News module bug that has plagued many vBulletin forums for months.

Volconvo.com and developer Sillysoft are offering a free and better fix.


BACKGROUND

In version 2.2.0, the problem occurred when when the maximum characters variable was set at such a number that it precluded the display of closing BBCode tags. (thumb: news_verybad.png)

Version 2.2.1 "resolved" the issue by ending quoted material prematurely, effectively ignoring the actual maximum character value. (thumb: news_bad.png)

Volconvo.com and developer Sillysoft have partnered to offer the following better fix for vBadvanced CMPS that respects your personal settings. (thumb: news_good.png)


INSTALLATION

1. Find this line in [forumdirectory]/modules/news.php:
   PHP Code:

    $news['message'] = substr($news['message'], 0, strrpos(substr($news['message'], 0, $mod_options['portal_news_maxchars']), ' ')); 

   Replace with the following code:
   PHP Code:

   // START BUG FIX
// Provided by Volconvo.com and Sillysoft
// http://www.volconvo.com/cmps.php?page=newsmodulefix
// Original code:
// $news['message'] = substr($news['message'], 0, strrpos(substr($news['message'], 0, $mod_options['portal_news_maxchars']), ' '));

                    $rawdata = $news['pagetext'];
                    $newspart1 = substr($rawdata,0,$mod_options['portal_news_maxchars']);
                    $newsposition = strrpos($newspart1,' ');
                    $newspart1 = substr($newspart1,0,$newsposition);
                    
                    $rawdata = $rawdata .'.';
                    $newspart2 = substr($rawdata,$newsposition,-1);
                    
                    preg_match_all('#(\[(.*?)\])?.*?(\[\/(.*?)\])?#',$newspart2,$newspart2tags); 
                    $numtags = count($newspart2tags[0]);
                    $tags = '';
                    
                    for($i = 0; $i < $numtags; $i++)
                    { 
                        
                        $tags .= $newspart2tags[1][$i] . $newspart2tags[3][$i];
                             
                    }
                    
                    $shownews = $newspart1 .'...';
                    $news['message'] = $bbcode_parser->do_parse($shownews, $mod_options['portal_news_enablehtml'], $news['allowsmilie'], $mod_options['portal_news_enablevbcode'], $mod_options['portal_news_enablevbimage']);

// END BUG FIX 

2. Click INSTALL.

CHANGE LOG

11/6/06: Update to better handle images as provided here.

CREDITS

This fix was developed by Sillysoft in partnership with Volconvo.

You may contact Sillysoft at liquidchaoss (at) yahoo.com or via AIM at "Sillysoft".
The Volconvo administrator may be contacted here.

[bitHacker]

six month ago, i cam across an error, which made my page not validated due to
news module cutting HTML tags - http://www.vbadvanced.com/forum/show...1456#post91456

your solution fixed that problem too !!!!!!

one more thing...

add this:

PHP Code:

$news['message'] .= ' '. construct_phrase($vbphrase['read_more'], $vbulletin->options['bburl'], $news['threadid'], $session['sessionurl']); 


before

PHP Code:

// END BUG FIX 


to get a "[Read More]" link at the end of the post

THANK YOU !!!!

p.s.
if only i could *click INSTALL* a million times

[voteforbird]

Glad it helped!

Mine already does have a [READ MORE] link. Can anyone else confirm? Perhaps somehow I left this out of the fix instructions.

[Paul M]

Please attach the modification as a (text) file.

You can keep it in the first post if you wish, but all modifications must be supplied in a downloadable form.

Thanks.

[voteforbird]

Sorry about that. Done!

[lolo?]

great works fine thanks for this fix

[Mecho]

Hi .. do u think that u can add some code for resize Images ( not attach images ) in news M... ?

sorry if i ask in wrong section but i saw that u work on it thats why....

Tnx alot

[voteforbird]

Sorry, that's not me, but you may be able to find your solution here: https://vborg.vbsupport.ru/showthread.php?t=127266

[Mecho]

Tnx mate but this topic that u said i think is not for Vbadvanced . isnt it ?

i need resize image for vbadvanced . i was looking for it everywhere and i request it more that 5times in vbadvanced forum too . but ....

it will be great if some coder can make this mode for news moudle for vbadvanced coz it doest exist . Tnx alot . regards

[Bad Bunny]

Just to clarify...does this fix work with vbadvanced 2.2.1 or 2.2.0, or both?

[voteforbird]

Mecho,
It should work with vBadvanced with slight alteration. Please save that discussion for another thread, though.

Bad Bunny,
The line in 2.2.0 is slightly different. You can find it shortly under this:

// Strip characters and add "read more"

The fix will still work—in fact, it was originally created for version 2.2.0. I just assumed you all would have upgraded