Remove 1 Query Per Page

[CENTER]Remove 1 Database Query Per Page
Reduce your forums query usage !

Summary: (Quoted From Original Hack for vb3)

Removes 1 Query Per Page.

Instructions:

1. Open includes/class_core.php
2. Go to about line 2538 and look for

PHP Code:

$this->set('location', WOLPATH); 


3. Above that, paste the following.

PHP Code:

$this->set('old_location', $session['location']); 


4. Go to about line 2818 and look for the following:

PHP Code:

            // registered user
            if (!SESSION_BYPASS)
            {
                if (TIMENOW - $this->userinfo['lastactivity'] > $this->registry->options['cookietimeout'])
                {
                    // see if session has 'expired' and if new post indicators need resetting
                    $this->registry->db->shutdown_query("
                        UPDATE " . TABLE_PREFIX . "user
                        SET
                            lastvisit = lastactivity,
                            lastactivity = " . TIMENOW . "
                        WHERE userid = " . $this->userinfo['userid'] . "
                    ", 'lastvisit');

                    $this->userinfo['lastvisit'] = $this->userinfo['lastactivity'];
                }
                else
                {
                        $this->registry->db->shutdown_query("
                            UPDATE " . TABLE_PREFIX . "user
                            SET lastactivity = " . TIMENOW . "
                            WHERE userid = " . $this->userinfo['userid'] . "
                            ", 'lastvisit');
                }
            } 


5. Replace that with the following:

PHP Code:

            // registered user
            if (!SESSION_BYPASS)
            {
                if (TIMENOW - $this->userinfo['lastactivity'] > $this->registry->options['cookietimeout'])
                {
                    // see if session has 'expired' and if new post indicators need resetting
                    $this->registry->db->shutdown_query("
                        UPDATE " . TABLE_PREFIX . "user
                        SET
                            lastvisit = lastactivity,
                            lastactivity = " . TIMENOW . "
                        WHERE userid = " . $this->userinfo['userid'] . "
                    ", 'lastvisit');

                    $this->userinfo['lastvisit'] = $this->userinfo['lastactivity'];
                }
                elseif ($this->vars['old_location'] != WOLPATH || THIS_SCRIPT == 'misc' || THIS_SCRIPT == 'online')
                {
                    $this->registry->db->shutdown_query("
                        UPDATE " . TABLE_PREFIX . "user
                        SET lastactivity = " . TIMENOW . "
                        WHERE userid = " . $this->userinfo['userid'] . "
                        ", 'lastvisit');
                }
            } 


[Kihon Kata]

Originally Posted by Trigunflame

Because if you would look at the query:

$this->registry->db->shutdown_query()

It is a shutdown query that is run as the script is ending, and is not shown in any query counters. Nevertheless it is still sending that query to your forums mysql database which affects the system.

I didnt say this would necessarily make your forum "Faster", I just said it would reduce a query, lol.

Go read my thread in vb3 if you dont believe me...

Oh, all I said is that when the stats lists, it's the same number of queries listed, that's all. Nothing about speed or "Faster".

Anyhow, thanks for this

[Snake]

Thank you very much. I always wanted to reduce the query usage on my forums but guess what, this helps a lot!

[NuclioN]

Trigunflame the code to replace at the very bottom of the last replacement says you have to overwrite. That section in the original has this:

$this->registry->db->shutdown_query("
						UPDATE " . TABLE_PREFIX . "user
						SET lastactivity = " . TIMENOW . "
						WHERE userid = " . $this->userinfo['userid'] . "
					", 'lastvisit');
				}
			}
		}
	}
}

-----------------------

According to the manual i have to overwrite the first two } is that correct?

[Trigunflame]

Originally Posted by NuclioN

Trigunflame the code to replace at the very bottom of the last replacement says you have to overwrite. That section in the original has this:

$this->registry->db->shutdown_query("
						UPDATE " . TABLE_PREFIX . "user
						SET lastactivity = " . TIMENOW . "
						WHERE userid = " . $this->userinfo['userid'] . "
					", 'lastvisit');
				}
			}
		}
	}
}

-----------------------

According to the manual i have to overwrite the first two } is that correct?

Just replace the php code in the first php example, with the php code in the 2nd example.

[NuclioN]

Tnx Every reduce of query is usefull

[o0Hubba0o]

3. Above that, paste the below

So does it go above? Or does it go below?

Wait, I think I understand now that I look at what I typed, your saying to paste what's below above this "$this->set('location', WOLPATH); " right? Maybe change it to say: "3. Above that, paste the following:". Otherwise more people might get confused if they're looking at this right after getting up in the morning like me hehe.

[Trigunflame]

Originally Posted by o0Hubba0o

So does it go above? Or does it go below?

Wait, I think I understand now that I look at what I typed, your saying to paste what's below above this "$this->set('location', WOLPATH); " right? Maybe change it to say: "3. Above that, paste the following:". Otherwise more people might get confused if they're looking at this right after getting up in the morning like me hehe.

It doesnt matter if you paste it below it or above it, just a 1 liner.

[Trigunflame]

*bump*

[dutchbb]

I'm still not sure what changes when I remove the query. And if it doesn't change speed I rather keep the extra query

[Trigunflame]

Originally Posted by Triple_T

I'm still not sure what changes when I remove the query. And if it doesn't change speed I rather keep the extra query

If you dont care, dont worry about it :tired: