Major Additions - GRPS: Groups Commune 2.0.x

Welcome ladies and gentleman, this is the release thread for GRPS, an interactive groups commune. I hope you enjoy this release and i sincerely hope it provides everything to your community in which you're looking for.

What is it?
It's a groups commune. The original idea is that forums with lots and lots of forums on the front-page suck, as a result i thought most of the conversation was rather obscure in regards to what the forums were trying to achieve, so it'd be nice to have that all going on elsewhere, not detracting away from the content and stopping your front-page from looking like a car crash.

Features?

• Groups Home
  
  • Groups Activity List
    
    • Newest Groups
      
    • Most Popular Groups
      
    • Largest Groups
      
  • Category List
    
  • Group Search by Title
    
  • Group Sort by Alphabetical Title, Categories, Member Count
    
    
  • Users can create groups
    
  • Admin switch to moderate groups or not
    
    • Admin CP access to moderation panel
      
• Groups Page
  
  • Posts since last visit notification
    
  • Group Info
    
    • Group Leader shown with avatar
      
    • Category
      
    • Type
      
      • Groups can be listed as public, private or hidden
        
    • Start Date
      
    • Member count
      
    • Post count
      
  • Group Desciption
    
    • Shows group title
      
    • Shows random image
      
    • Shows group information set by group leader
      
  • Groups Thread List (Forum)
    
    • Status Icon
      
    • Title
      
      • Threads use postbit as per the forums
        
    • Thread Author with avatar and time that the thread was started
      
    • Last reply with avatar, username and time that the last reply was posted
      
    • Post New Thread Button
      
      • Groups Members can create threads
        
  • Newest Members
    
    • Shows five newest members
      
    • Link to view all members
      
      • Shows all members of the group
        
  • Group Options
    
    • Users can join/leave groups
      
      • PM Notification for group leaders upon join requests (when moderation enabled).
        
      • PM Notification for of acceptance or refusal.
        
    • Users can send invites to other users via PM
      
• Groups Thread
  
  • Groups Info Box (see above for more info)
    
  • Group Description box (see above for more info)
    
  • Newest Members List (see above for more info)
    
  • List of groups posts using forums postbit
    
  • Pagination using native vBulletin pagination
    
  • Group Leader/Moderation Options
    
    • Open/Close Thread
      
    • Stick Thread
      
    • Delete Thread
      
  • Users have the ability to report posts
    
  • Moderators have the ability to view IP and host.
    
• Group Leader Options
  
  • Groups Management
    
    • WYSIWYG Editor
      
    • Reason for editing box
      
    • Group Options
      
      • Private Posts
        
      • Only group leader can make threads
        
      • Moderate Members
        
      • Show group text edit details
        
      • Hide group image on group pages
        
      • Hidden Group
        
        • This option is only available to admins
          
  • Group Members Moderation
    
    • Ability to accept or deny new members
      
• Postbit Integration
  
  • View Users Groups
    
• User Control Panel (Integration)
  
  • List of groups appears in usercp in order of the last post
    
• Administrator Options
  
  • vBulletin Options
    
    • Turn groups on or off
      
    • Groups Limit Per User
      
    • Posts Per Page (threads)
      
    • Check Forum Activity Posts
      
    • Check Forum Activity Time
      
    • Number of Random Images
      
    • Turn email notification of new groups on/off
      
  • Usergroup Options
    
    • Can view groups
      
    • Can create groups
      
    • Can join groups
      
    • Can post messages in groups
      
    • Can edit messages in groups
      
    • Can delete messages posted in groups
      
    • Numbers of groups usergroup can join limited
      
    • Can moderate groups
      
      • See above for more info
        
    • Can view IP Addresses
      
  • Category Editor
    
    • Edit
      
      • Edit cat id (please not this can ef up your show)
        
      • Edit cat title
        
      • Edit cat description
        
    • Add
      
      • New Cat Title And Description
        
  • Groups Editor
    
    • Search for group by id
      
      • Edit
        
        • Title
          
        • Desciption
          
        • Categoryid
          
        • Group leader id
          
        • Private Posts
          
        • Moderate Members
          
        • Hidden group
          

Special Thanks to harry1951, without his help testing and his recommendations, this would've never ended up the way it did.

Honestly, i can't think of anything else, if you appreciate the work gone into this mod, please donate (in GBP) (right click open in new window)

Hopefully you all appreciate that i just relaunched my site and rather than soak up the atmosphere there or go out drinking i came to release this tonight.

Screens below, rest to your right

Please note this mod does work with 3.5.x

PLEASE DO NOT JOIN MY SITE IN A BID TO PLAY WITH IT OR HAVE A LOOK AT IT FURTHER, MY SITE IS SOMETHING I VALUE FOR BEING SOMEWHERE I CAN CHILL AT, IT'S NOT A TEST SUITE OR DEMO!

Bug Fixes

• Groups v2.0.0 RC1b.zip: fix regarding incorrect table prefixes in index.php and editpost.php
• Groups v2.0.0 RC2.zip: fix regarding incorrect table prefixes in functions_grps.php and class_grps.php. also fix regarding installation instructions.
• Groups v2.0.0 RC3.zip: fix regarding inability to get to create groups page. updated simplified instructions, sadly still not cool html ones and also added ability to delete groups, delete categories and of course the menu options to get to these.
  • Groups v2.0.0 RC3b.zip: fix regarding joining and leaving group depreciated function error added uninstaller to the zip at http://www.yoursite.com/groups/tools...p?do=uninstall
  • Groups v2.0.0 RC3c.zip: fix regarding edit being stated as 70's on group stages, requires re-installtion of the plugin only.
• Groups v2.0.0 RC4.zip: various bug fixes and new general setting, please reupload all files and then reinstall the product.
• Groups v2.0.0 RC5.zip: bug fixes regarding fixing links to forums being broken and forcing redirects for create group outcomes.
• Groups v2.0.0 RC6.zip: various bug fixes including table prefixes in admincp, invitations system now features in-line erroneous username fall-back and clean up regarding broken images in viewthread.php
• Groups v2.0.0 RC7.zip: bug fixes including missing phrases and missing 'noavatar.gif for group leader on groups info.
• Groups v2.0.0 RC8.zip: various bug fixes including missing phrases, smilies not working. new function to turn of new group moderation. form now working on print_no_permission page (thanks Adrian) and something else i forgot.
• Groups v2.0.0 RC9.zip: fixes two spelling mistakes, moves viewthread.php string_replacements to admincp and simplifies the installer experience. (yeah i thought there'd be more to it too).
  • Groups v2.0.0 RC9b.zip: re-fixes two spelling mistakes, fixes a viewthread.php string_replacement via the admincp and turns the default random image count down to that of which is provided.
• Groups v2.0.0 RC10.zip: optimises some of the code, cuts down on queries in exchange for additional joins and now forces compatibility in groups/viewthread.php with vBulletin options. also adds new option in admincp in order to make usercp listing work better out of the box.
• Groups v2.0.0 RC11.zip: fixes a problem with avatars not displaying correctly in thread listing and also optimises the code in membership.php
• Groups v2.0.0.zip: adds and array_merge to the code and smilie popup fixed. now features hooks for plug-in 'easability'. uCS integration moved to external plugin too.
• Groups v2.0.1.zip: removes one hook, fixes problem with membership.php, fixes problem editgroup.php not remembering options and fixes avatar problem.
• Groups v2.0.2.zip: various bug fixes (like missing pagenavs, more elegant removal of reputation button and infraction button and php notices), one or two new features (like intuitive page titles) and now fully phrased.
• Groups v2.0.3.zip: bug fix regarding now being able to select categories. includes a new feature which is basically pagination for the thread listings.
• Groups v2.0.4.zip: bug fix regarding not being able to moderate group memberships.
• Groups v2.0.5.zip: bug fix regarding those introduced via 2.0.4, new features such as double post prevention disable, admins can override privacy settings, usergroup permission text more intuitive and end-user usability increased with modification to threadbit on groups.php. group leaders can now kick users from there groups.
• Groups v2.0.6.zip: bug fix including report, missing edit button and other misc small bugs, new features such as disable hidden groups, allow mods to see private groups, and resign from group handing off to another user.
• Groups v2.0.7.zip: bug fix including fixing post counts, thread goto's and fatal php errors.
• Groups v2.0.8.zip: bug fix regarding inability to delete posts, problem with editing posts and other misc errors.
• Groups v2.0.9.zip: various bug fixes including wywiwyg error, admin cp error and redirect/goto errors.
  • Groups v2.0.9b.zip: fixes problem with upgrade4.php
• Groups v2.0.10.zip: various bug fixes including acknowledging renamed modcp and admincp dir's also adds option regarding removing of posts at group exit/kick.
• Groups v2.0.11.zip: various bug fixes including security/privacy fixes.
• Groups v2.0.12.zip: permission bug fixed.
• Groups v2.0.13.zip: various bug fixes including ability to ignore members in groups and newreply bug.

[Merriweather]

Originally Posted by sabret00the

can i get a screenshot of this one please?

I PMed you the screenshot.

[Merriweather]

Originally Posted by sabret00the

can you please run this query with the same values for which you used XX and YY on the test_viewthread.php please

[sql] SELECT grps_post.postid, grps_post.groupid, grps_post.username AS postusername, grps_post.ipaddress AS ip, grps_post.title AS posttitle, grps_post.dateline, grps_post.pagetext, grps_post.iconid, i.title AS icontitle, i.iconpath, grps_post.visible, grps_post.allowsmilie, grps_post.showsignature, grps_post.edit_username, grps_post.edit_userid, grps_post.edit_reason, grps_post.edit_dateline, grps_post.delete_username, grps_post.delete_userid, grps_post.delete_reason, grps.leaderid, u.*, uf.*, utf.*, a.avatarid, a.avatarpath, NOT ISNULL(ca.userid) AS hascustomavatar, ca.dateline AS avatardateline, ca.width AS avwidth, ca.height AS avheight
FROM grps_post
LEFT JOIN grps ON (grps.groupid = grps_post.groupid)
LEFT JOIN user u ON (u.userid = grps_post.userid)
LEFT JOIN userfield uf ON (uf.userid = u.userid)
LEFT JOIN usertextfield utf ON (utf.userid = u.userid)
LEFT JOIN icon i ON (i.iconid = grps_post.iconid) > 0
LEFT JOIN avatar a ON (a.avatarid = u.avatarid)
LEFT JOIN customavatar ca ON (ca.userid = u.userid)
WHERE grps_post.groupid = XX and grps_post.threadid = YY
ORDER BY grps_post.dateline ASC
[/sql]

and please just look for the iconpath column and let me know if it's empty on all counts.

hold on, i think i've figured it out. are you using a default icon on your forums?

I am using a default icon. But even if a different icon is selected, it doesn't show.

The results are 0 for all iconids, null for all icontitles and paths. Posttitle is NOT blank for some, but the title doesn't show on the posts.

[sabret00the]

Originally Posted by Merriweather

I am using a default icon. But even if a different icon is selected, it doesn't show.

The results are 0 for all iconids, null for all icontitles and paths. Posttitle is NOT blank for some, but the title doesn't show on the posts.

can you please go to your Admin CP => vBulletin Options => Thread Display Options

and check your default post icon path please.

[sabret00the]

Originally Posted by sabret00the

can i get a screenshot of that because i'm unable to replicate that.

confirmed, it's a problem with the WYSIWYG editor. being worked on now.

[Merriweather]

Originally Posted by sabret00the

can you please go to your Admin CP => vBulletin Options => Thread Display Options

and check your default post icon path please.

Adding my full URL there fixed the default (YAY!) but there is still the issue that if you choose a different icon, or enter a title, they don't show.

[sabret00the]

Originally Posted by Merriweather

Adding my full URL there fixed the default (YAY!) but there is still the issue that if you choose a different icon, or enter a title, they don't show.

enter a title?

[Merriweather]

Originally Posted by sabret00the

enter a title?

Yes, when you post, you can enter a post title and your message. If you enter a title, it is supposed to show next to the post icon. Neither the selected post icon (if you select one) nor the post title (if you enter one) ever show. It only shows the default post icon. It's saving the titles, because I can see them in the DB, but they aren't displayed. I'm not sure about the post icons.

[Merriweather]

Other issues my users have reported:

(1) If a user has no avatar, it shows a red X or missing image placeholder for the user. It should not show anything, or at least some default "missing avatar" placeholder.

(2) When you post to a thread, the page refreshes to the start of page one, instead of where you just posted. So if you post to page five, it bounces you back to page one, and you have to click and scroll to get back where you left off.

(3) The [View My Last Reply] [View New Posts] [View Last Reply] links just take you to the start of the thread.

My own issue is that the system does not seem to check a user's permissions, only if they are a member. So when I had a member join a group, then get changed to a usergroup without group joining privileges, she could still see and post to the group because she was still a member. If the system could check the user against their usergroup permissions to make sure that they have permissions to access the groups, whether or not they are a member or leader of a group would be great. Perhaps a cron job to remove users from groups once their permissions change, even.

[Merriweather]

I've made some progress figuring out this maddening DB error on replying to posts as well as why it takes you to the start of the post and not where you left off.

If I click to reply on certain group threads, the HTML source looks like this:

<input type="hidden" name="s" value="" />
		<input type="hidden" name="do" value="postreply" />
		<input type="hidden" name="t" value="0" />
		<input type="hidden" name="p" value="" />
		<input type="hidden" name="posthash" value="" />
		<input type="hidden" name="poststarttime" value="" />
		<input type="submit" class="button" name="sbutton" id="vB_Editor_001_save" value="Submit Reply" accesskey="s" tabindex="1" />
		<input type="submit" class="button" name="preview" value="Preview Post" accesskey="p" tabindex="1" />

Obviously, the topicid and postid are missing.

On the ones that work, the source is like this:

<input type="hidden" name="s" value="" />
		<input type="hidden" name="do" value="postreply" />
		<input type="hidden" name="t" value="47" />
		<input type="hidden" name="p" value="" />
		<input type="hidden" name="posthash" value="" />
		<input type="hidden" name="poststarttime" value="" />
		<input type="submit" class="button" name="sbutton" id="vB_Editor_001_save" value="Submit Reply" accesskey="s" tabindex="1" />
		<input type="submit" class="button" name="preview" value="Preview Post" accesskey="p" tabindex="1" />

The topicid is there, though the postid is not. This is why I can reply to the post, but it takes me to the start of the thread, and not the post I made, after I submit.

Interestingly, on threads that have no topicid when replying, you CAN quote them -- the topicid gets pulled there. So perhaps an investigation of the code to see what the difference is in pulling the topicid for the quote vs. the new reply will help you solve this?

I will let you know if I figure out any more.

[Merriweather]

Another bug -- I deleted a post from a thread, but it still shows the thread as having a reply, which it no longer does. The info block on the right, however, that says "Posts in this Thread" has the correct count.