Go Back   vb.org Archive > vBulletin Modifications > Archive > Modification Graveyard

Reply
 
Thread Tools
OS/Browser Display in Postbits Details »»
OS/Browser Display in Postbits
Version: 1.0.6, by nhawk nhawk is offline
Developer Last Online: May 2021 Show Printable Version Email this Page

Category: Show Thread Enhancements - Version: 4.1.5 Rating:
Released: 03-29-2012 Last Update: 05-09-2012 Installs: 84
DB Changes Uses Plugins
Additional Files  
No support by the author.

No longer available on vB.org.

Show Your Support

  • This modification may not be copied, reproduced or published elsewhere without author's permission.
4 благодарности(ей) от:
Adrijan, DirtRider, Megaboost, MikeF

Comments
  #132  
Old 05-10-2012, 01:59 PM
EliasAlucard's Avatar
EliasAlucard EliasAlucard is offline
 
Join Date: Nov 2009
Location: Sweden
Posts: 125
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by nhawk View Post
I would prefer you didn't.

And I feel it's as complicated as it needs to be for what it does. If you disagree with that, use PMs and we'll discuss it.

Also, the system does identify Ubuntu, etc.
Well, if we may not come to agreement, I may just install it and use my own modification of it on my forum. I'm using vB3.8.7 now though, so I'm not using your plugin.

You've done a good job in adding more browser and OS support, but it's still quite incomplete (hey, I don't blame ya, I've learned myself that this takes quite some time).

We can take it here rather than PM. For one, I don't understand why you've grouped together Windows 7 and Server 2008 R2? They are clearly distinguishable by user agent string (6.1 and 6.0) and so it's possible to separate them in the postbit information. You also don't have a specific icon for Windows 7; you're using the Vista icon.

Personally, I think the icons should be sized at least 20 on the height and 24 as a max.

I wouldn't really need to modify your plugin though. I guess all I need is to add browser/OS version support for Fighter1405's old vB3.8 plugin, in the alt text. Do I need $tmp_array, $useragent and $client_data for that?
Reply With Quote
  #133  
Old 05-10-2012, 02:06 PM
nhawk nhawk is offline
 
Join Date: Jan 2011
Posts: 1,604
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Windows 7 and Vista do have the same logo from Microsoft. They never changed it.

So far as icon size, they are sized at 19. But if you like 20, I can't please everyone.

I can't help with Fighter1405's plugin since I've never seen it and I don't know a thing about it.
Reply With Quote
  #134  
Old 05-10-2012, 02:16 PM
datoneer datoneer is offline
 
Join Date: Jul 2011
Posts: 453
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Installed and nominated
Reply With Quote
Благодарность от:
nhawk
  #135  
Old 05-10-2012, 02:16 PM
EliasAlucard's Avatar
EliasAlucard EliasAlucard is offline
 
Join Date: Nov 2009
Location: Sweden
Posts: 125
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by nhawk View Post
Windows 7 and Vista do have the same logo from Microsoft. They never changed it.

So far as icon size, they are sized at 19. But if you like 20, I can't please everyone.

I can't help with Fighter1405's plugin since I've never seen it and I don't know a thing about it.
Well, there are Windows 7 icons like this one:

http://www.pconline.se/wp-content/up...7/windows7.jpg

Here's Fighter's plugin:

https://vborg.vbsupport.ru/showthread.php?t=219687
Reply With Quote
  #136  
Old 05-10-2012, 02:22 PM
nhawk nhawk is offline
 
Join Date: Jan 2011
Posts: 1,604
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by EliasAlucard View Post
Well, there are Windows 7 icons like this one:

http://www.pconline.se/wp-content/up...7/windows7.jpg

Here's Fighter's plugin:

https://vborg.vbsupport.ru/showthread.php?t=219687
Well, the ones I user are the ones shown on most Microsoft packaging.

And if you didn't know it the Server 2008 version numbers are the same for Windows 7 and Vista.

Windows7/Server 2008 = 6.1
Vista/Server 2008 = 6.0

And the newest is Windows 8 = 6.2

I have no intention of using my time to decode someone else add-on. If you want to change it you are on your own.
Reply With Quote
  #137  
Old 05-10-2012, 02:32 PM
EliasAlucard's Avatar
EliasAlucard EliasAlucard is offline
 
Join Date: Nov 2009
Location: Sweden
Posts: 125
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by nhawk View Post
Well, the ones I user are the ones shown on most Microsoft packaging.
Yeah, but still, it would be like using a win2k icon for winxp if you know what I mean.

Quote:
Originally Posted by nhawk View Post
And if you didn't know it the Server 2008 version numbers are the same for Windows 7 and Vista.

Windows7/Server 2008 = 6.1
Vista/Server 2008 = 6.0

And the newest is Windows 8 = 6.2
Yes, but most forum posters don't actually use Windows Server 2008 R2 so it's kind of redundant to even have that as the alt text.

Quote:
Originally Posted by nhawk View Post
I have no intention of using my time to decode someone else add-on. If you want to change it you are on your own.
I can understand that. Looks like I'll be playing around with your plugin then

Also, you lack iOS icons and so on. I've currently done a good job with updating Fighter's plugin, but it's for vB3.8 only so I'm not sure if it's worth working any more on it.
Reply With Quote
  #138  
Old 05-10-2012, 02:41 PM
nhawk nhawk is offline
 
Join Date: Jan 2011
Posts: 1,604
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by EliasAlucard View Post
Also, you lack iOS icons and so on.

Quote:
1.0.6 - (May 10, 2012)
Add - iPhone/iPad iPhone OS
Hmmm
Reply With Quote
  #139  
Old 05-10-2012, 03:21 PM
EliasAlucard's Avatar
EliasAlucard EliasAlucard is offline
 
Join Date: Nov 2009
Location: Sweden
Posts: 125
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by nhawk View Post
Hmmm
That's good, although I've added icons for every Android version

By the way, I was thinking... is it possible that you could add some statistics counter or something? In admincp or something that shows how many posts were made with this OS and that browser, something like that, would be nice.
Reply With Quote
  #140  
Old 05-10-2012, 04:44 PM
Robru Robru is offline
 
Join Date: Aug 2005
Location: Netherlands
Posts: 368
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Thank you for this update!
Reply With Quote
  #141  
Old 06-23-2012, 08:57 PM
wally07 wally07 is offline
 
Join Date: Sep 2010
Posts: 39
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

thanks for the update!
Reply With Quote
Reply

Thread Tools

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT. The time now is 05:24 AM.


Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2024, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.11546 seconds
  • Memory Usage 2,316KB
  • Queries Executed 25 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)ad_showthread_beforeqr
  • (9)bbcode_quote
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)modsystem_post
  • (1)navbar
  • (4)navbar_link
  • (120)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (1)pagenav_pagelinkrel
  • (11)post_thanks_box
  • (5)post_thanks_box_bit
  • (11)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (2)post_thanks_postbit
  • (11)post_thanks_postbit_info
  • (10)postbit
  • (11)postbit_onlinestatus
  • (11)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available:
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files:
  • ./showthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • forumjump
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • fetch_musername
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • post_thanks_function_fetch_thanks_bit_start
  • post_thanks_function_show_thanks_date_start
  • post_thanks_function_show_thanks_date_end
  • post_thanks_function_fetch_thanks_bit_end
  • post_thanks_function_fetch_post_thanks_template_start
  • post_thanks_function_fetch_post_thanks_template_end
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • pagenav_page
  • pagenav_complete
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • showthread_complete