Private Messages Enhancements - User PM Search

Description:
This modification allows your users to search thru their pms

Installation:
All the installation information is in the package.

Changes/Adds:
7 Plugins
19 Phrases
1 Template
1 Template change

Changelog
2.0
Rewrote some parts and included (hopefully) all feature requests
- Search is now on a single page
- Usergroup permission added
- (Little to) no template changes necessary
- Should hopefully work with other pm addons like pm preview etc without additional template changes (not tested)

1.0.2
Fixed a template bug, thx Makc666

Change

$vbphrase[search_results_in_folder]<span class="normal">: <span id="nav_pmfolders.messagelist">$foldername<script type="text/javascript"> vbmenu_register("nav_pmfolders.messagelist"); </script></span></span>

to

$vbphrase[search_results_in_folder]<span class="normal">: $foldername</span>

1.0.1
Fixed some minor problems

[thaki]

It's work but when I install it the error happen in main search for threads and post

Parse error: parse error, unexpected ',' in /home/abaunet/public_html/vb/search.php(1958) : eval()'d code on line 1

???

[Silviu]

Installed the mod and love it, but some of our users recently started reporting that both Search functions are inoperable. If they try to use them, they get the following errors:

Search by Username:

Database error in vBulletin 3.6.8:

Invalid SQL:

SELECT pm.*, pmtext.*
, icon.title AS icontitle, icon.iconpath
FROM pm AS pm
LEFT JOIN pmtext AS pmtext ON(pmtext.pmtextid = pm.pmtextid)
LEFT JOIN icon AS icon ON(icon.iconid = pmtext.iconid)
WHERE pm.userid=4877
AND pm.folderid= AND fromuserid IN (618, 17103, 17921, 29550, 31022, 31200, 37237, 43083, 56188, 59939, 61094, 64280, 73683, 87463, 95220)
ORDER BY pmtext.dateline DESC;

MySQL Error : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'AND fromuserid IN (618, 17103, 17921, 29550, 31022, 31200, 37237, 43083, 56188, ' at line 7
Error Number : 1064
Date : Friday, October 12th 2007 @ 12:19:38 PM
Script : http://forum.computergames.ro/private.php?folderid=0
Referrer : http://forum.computergames.ro/private.php
IP Address : 193.111.120.28
Username : Bossman
Classname : vB_Database_MySQLi

Normal search:

Database error in vBulletin 3.6.8:

Invalid SQL:

SELECT pm.*, pmtext.*
, icon.title AS icontitle, icon.iconpath
FROM pm AS pm
LEFT JOIN pmtext AS pmtext ON(pmtext.pmtextid = pm.pmtextid)
LEFT JOIN icon AS icon ON(icon.iconid = pmtext.iconid)
WHERE pm.userid=4877
AND pm.folderid= AND MATCH(pmtext.title, pmtext.message) AGAINST ('+moderator' IN BOOLEAN MODE)
ORDER BY pmtext.dateline DESC;

MySQL Error : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'AND MATCH(pmtext.title, pmtext.message) AGAINST ('+moderator' IN BOOLEAN MODE)
' at line 7
Error Number : 1064
Date : Friday, October 12th 2007 @ 12:22:57 PM
Script : http://forum.computergames.ro/private.php?folderid=0
Referrer : http://forum.computergames.ro/private.php
IP Address : 193.111.120.28
Username : Bossman
Classname : vB_Database_MySQLi

Any ideas why this is happening?

From what I can tell, there seems to be a problem with the pm.folderid= bit in the query

[Thaliada]

That is indeed the problem, actually

if(!isset($_GET['folderid']) || trim($_GET['folderid']) == '') $_GET['folderid'] = 0;

should take care of this problem, but as i see now, i forgott to change

AND pm.folderid=" . mysql_real_escape_string($_GET['folderid']) . " ";

it in the query later on...

Sry just change

AND pm.folderid=" . mysql_real_escape_string($_GET['folderid']) . " ";

with

AND pm.folderid=" . mysql_real_escape_string($search_folderid) . " ";

That should fix this problem.

[Silviu]

I assume these changes need to be done in the XML before importing it, right?

[AWJunkies]

This should be in VB as default VERY GOOD MOD!

[Illustrious]

This is a great mod. I wonder how much resources this uses on the server. Also, can you add usergroup permissions for this?

/me installs and nominates.

[Silviu]

Originally Posted by Thaliada

Sry just change

AND pm.folderid=" . mysql_real_escape_string($_GET['folderid']) . " ";

with

AND pm.folderid=" . mysql_real_escape_string($search_folderid) . " ";

That should fix this problem.

Well, I applied this fix to the xml, re-imported it with Overwrite on, but the error still persists

[trackpads]

Nice Hack!

I have one problem, I am using the show avatars in PM list mod and the search results breaks the rows as show in the screenie. Here is my pmbitlsit template. Any ideas?

Thanks!

-Jason

<tr>
	<td class="alt1"><img src="$stylevar[imgdir_statusicon]/pm_$pm[statusicon].gif" alt="" border="0" /></td>
	<td class="alt2"><img src="$vboptions[bburl]/image.php?u=$userid" width="50" height="50"></td>
	<td class="alt1Active" id="m$pm[pmid]" width="100%">
		<div>
			<span style="float:$stylevar[right]" class="smallfont">$pm[senddate]</span>
<if condition="$pm['attach']"><img class="inlineimg" src="$stylevar[imgdir_misc]/paperclip.gif" alt="<phrase 1="$pm[attach]">$vbphrase[x_attachments]</phrase>" /></if>
			<a href="private.php?$session[sessionurl]do=showpm&amp;pmid=$pm[pmid]"><if condition="$show['unread']"><strong>$pm[title]</strong><else />$pm[title]</if></a>
		</div>
		<div class="smallfont">
			<span style="float:$stylevar[right]" class="time">$pm[sendtime]</span>
			<if condition="$show['unread']"><strong>$userbit</strong><else />$userbit</if>
		</div>
	
	</td>
	<if condition="$show['pmcheckbox']"><td class="alt2" align="center" style="padding:0px"><input type="checkbox" name="pm[$pmid]" value="$groupid" /></td></if>
</tr>

[Acedeal]

Get's an error what installed

Database error in vBulletin 3.6.7:

Invalid SQL:

			SELECT pm.*, pmtext.*
				, icon.title AS icontitle, icon.iconpath
			FROM vb3_pm AS pm
			LEFT JOIN vb3_pmtext AS pmtext ON(pmtext.pmtextid = pm.pmtextid)
			LEFT JOIN vb3_icon AS icon ON(icon.iconid = pmtext.iconid)
			WHERE pm.userid=94
			AND pm.folderid=0  AND MATCH(pmtext.title, pmtext.message) AGAINST ('+scuba' IN BOOLEAN MODE) 
			ORDER BY pmtext.dateline DESC;

MySQL Error  : The used table type doesn't support FULLTEXT indexes
Error Number : 1214
Date         : Saturday, October 20th 2007 @ 06:02:52 PM
Script       : http://forum.xxxxx.com/private.php?folderid=0
Referrer     : http://forum.xxxxx.com/private.php
IP Address   : 68.xx.xx.xx
Username     : nxx
Classname    : vB_Database

[the Sandman]

It took me a while, but I figured out how to get this to work with MySQLi. It will also still work with MySQL, so it probably should be substituted into the plug-in for all users.

Find:

PHP Code:

AND pm.folderid=" . mysql_real_escape_string($_GET['folderid']) . " "; 


or, if you've already made the change mentioned in Post #103:

PHP Code:

AND pm.folderid=" . mysql_real_escape_string($search_folderid) . " "; 


And replace it with:

PHP Code:

AND pm.folderid=" . $db->escape_string($search_folderid) . " ";