Fatel Error: call to member object......

[xellos16]

I have just updated my forums to the newest update, and my members run into an error when they post a new post.

Fatal error: Call to a member function on a non-object in /home/rpg-game/public_html/forum/newreply.php on line <b>340

I don't undertand what the problem is though.

PHP Code:

// ### POST HAS ERRORS ###
                           $postpreview = construct_errors($errors); // this will take the preview's place
                           construct_checkboxes($newpost);
                           $_REQUEST['do'] = 'newreply';
                           $newpost['message'] = htmlspecialchars_uni($newpost['message']);
               }
               else if ($newpost['preview'])
               {
                           if ($forumperms & $vbulletin->bf_ugp_forumpermissions['canpostattachment'] AND $vbulletin->userinfo['userid'])
                           {
                                       // Attachments added
                                       $attachs = $db->query_read("
                                                   SELECT dateline, thumbnail_dateline, filename, filesize, visible, attachmentid, counter,
                                                               IF(thumbnail_filesize > 0, 1, 0) AS hasthumbnail, thumbnail_filesize,
                                                               attachmenttype.thumbnail AS build_thumbnail, attachmenttype.newwindow
                                                   FROM " . TABLE_PREFIX . "attachment AS attachment
                                                   LEFT JOIN " . TABLE_PREFIX . "attachmenttype AS attachmenttype USING (extension)
                                                   WHERE posthash = '" . $db->escape_string($posthash) . "'
                                                               AND userid = " . $vbulletin->userinfo['userid'] . "
                                                   ORDER BY attachmentid
                                       ");
                                       while ($attachment = $db->fetch_array($attachs))
                                       {
                                                   if (!$attachment['build_thumbnail'])
                                                   {
                                                               $attachment['hasthumbnail'] = false;
                                                   }
                                                   $postattach["$attachment[attachmentid]"] = $attachment;
                                       }
                           } 


that is the code block for the error message. the bold is the line that was called. can anyone help me with this? thanks.


Also is there a way that I can fix this with stripping my board of everything?

[Colin F]

Can you bold your line 340 in a [code ] field? The syntax highlighting removes it.

[Paul M]

Given the error message it's probably the $db->query_read .

Well he said he upgraded to the most recent version, and that's a default vb file...

[Paul M]

Originally Posted by Danny.VBT

Well he said he upgraded to the most recent version, and that's a default vb file...

Yes, which would make this a bit of puzzle, but I can't see another line that could cause that error, perhaps you can ?

Anyway, we will see when the OP returns ....

[xellos16]

IF(thumbnail_filesize > 0, 1, 0) AS hasthumbnail, thumbnail_filesize,

is line number 340. Thank you everyone that is trying to help, I appericate it.

[Anthony_R]

To fix this error in my custom code I had to declare any objects I pass into procedure that are not in my module as global. I also had to declare the

global $vbulletin;

object and convert code like

$db->query_read(

to
$vbulletin->db->query_read(

I'm not a PHP coder (although I code full time in another language) so your mileage may vary.

It's worth noting that all the error is raised in the VB code, the actual error occurs because you are using a variable that has *not* been initialised to actually contain an object. I think this related to the fact that since they aren't global the VB procedure is using it's own instance of the variable name and not the one you are using.

[xellos16]

:nervous: Thanks.....................

Could you explain in a less techy way? I am just starting to work withthis so, I don't understand alot of what you said. I'm sorry.

[Anthony_R]

Hmmm... less techy .... You are running some PHP code that didn't ship with vBulletin V3.5.x. This may be in the form of hack/mod or modified template etc...

This non standard PHP code is not compatible with the latest version of vBulletin and needs to be modified as per my above notes.

If yours is a clean install of vbulleting and has *no* modifications then you need to contact Jelsoft for support.

[xellos16]

ok, so find $db->query_read( i

in the code that I posted and change it

to

$vbulletin->db->query_read(

?

Is that what you are sugegestiing?