Go Back   vb.org Archive > vBulletin 3 Discussion > vB3 General Discussions
  #1  
Old 01-02-2006, 05:26 PM
fatalsex fatalsex is offline
 
Join Date: Jul 2004
Posts: 72
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default Html Injection

Html_Injection in vBulletin 3.5.2

-------

KAPDA New advisory

Vendor: http://www.vbulletin.com
Vulnerable Version: 3.5.2 (prior versions also may be affected)
Bug: Html_Injection (Second order Cross_Site_Scripting)
Exploitation: Remote with browser

Description:
--------------------
vBulletin is a powerful, scalable and fully customizable forums package. It has been written using the Web's quickest-growing scripting language; PHP, and is complemented with a highly efficient and ultra fast back-end database engine built using MySQL.

Vulnerability:
--------------------
Html_Injection :
The software does not properly filter HTML tags in the title of events before being passed to user in 'calendar.php'&'reminder.php AS include'. that may allow a remote user to inject HTML/javascript codes to events of calendar. The hostile code may be rendered in the web browser of the victim user who will Request Reminder for those Events (persistent).
For example an attacker creates new event (Single-All Day Event , Ranged Event OR Recurring Event)with this content:

TITLE:--------->Test<script>alert(document.cookie)</script>
BODY:---------->No matter
OTHER OPTIONS:->No matter

The hostile code will be rendered in the web browser of the victim user who will Request Reminder for this Event via http://example.com/vbulletin/calenda...addreminder&e=[eventid]
The hostile code will originate from the site running the Vbulletin software and will run in the security context of that site. As a result, the code will be able to access the target user's cookies (including authentication cookies),or take actions on the site acting as the target user.

Demonstration XSS URL:
--------------------
http://example.com/vbulletin/calenda...addreminder&e=[eventid]

Solution:
--------------------
There is no vendor supplied patch for this issue at this time.

Credit :
--------------------
Discovered & released by trueend5 (trueend5 kapda ir)
Security Science Researchers Institute Of Iran
[http://www.KAPDA.ir]

Moon-Tzu the sister of Sun-Tzu:"Wish you a good year and joyful one. HAPPY NEW YEAR"

=================

WTF how can i get rid of this ?
Its no rimender.php in incl dir.
Disabled calendar. But i think it must be BugFix
Reply With Quote
  #2  
Old 01-02-2006, 05:59 PM
nexialys
Guest
 
Posts: n/a
Default

this is what we call a code leak, someone found a crack in the code, and this site is intented to help hackers to pirate your site by advertising failure on the code...

i suppose that vb.COM guys are aware of this one, as it's not new... if it is really a problem, they will release a patch/upgrade real soon...
Reply With Quote
  #3  
Old 01-02-2006, 06:00 PM
StGaensler's Avatar
StGaensler StGaensler is offline
 
Join Date: Jan 2005
Location: Munich
Posts: 141
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

I haven't found any bug related to this topic so I created a new bug report: http://www.vbulletin.com/forum/bugs3...iew&bugid=2037

quick&dirty:
Open calendar.php and add at line 2271:
PHP Code:
$eventinfo['title'] = htmlspecialchars_uni($eventinfo['title']); 
Reply With Quote
  #4  
Old 01-02-2006, 06:23 PM
Scott MacVicar Scott MacVicar is offline
 
Join Date: Oct 2001
Location: Glasgow, Scotland
Posts: 1,199
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Use this plugin to fix it, we received no notification from the author and are looking into this at the moment.

Version 3.0 changed this to a version checker so it will only affect 3.5.2 and below.
Attached Files
File Type: xml product-calendar_xss.xml (898 Bytes, 11 views)
Reply With Quote
  #5  
Old 01-02-2006, 06:39 PM
Paul M's Avatar
Paul M Paul M is offline
 
Join Date: Sep 2004
Location: Nottingham, UK
Posts: 23,748
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Thank you Scott. I don't think we use this functionality much (if at all), but I've added the plugin anyway.
Reply With Quote
  #6  
Old 01-02-2006, 06:49 PM
Scott MacVicar Scott MacVicar is offline
 
Join Date: Oct 2001
Location: Glasgow, Scotland
Posts: 1,199
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by Paul M
Thank you Scott. I don't think we use this functionality much (if at all), but I've added the plugin anyway.
Just updated the plugin to take into account an issue on online.php, uninstall the current one and re-install this.

I think this can be sorted with permissions too.
Reply With Quote
  #7  
Old 01-02-2006, 07:15 PM
Scott MacVicar Scott MacVicar is offline
 
Join Date: Oct 2001
Location: Glasgow, Scotland
Posts: 1,199
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

One more bump, changed to a product and added some install code so it will only run for 3.5.2 and below.
Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT. The time now is 10:17 PM.


Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.08880 seconds
  • Memory Usage 2,237KB
  • Queries Executed 14 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)ad_showthread_beforeqr
  • (1)ad_showthread_firstpost
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (1)bbcode_php
  • (1)bbcode_quote
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)navbar
  • (3)navbar_link
  • (120)option
  • (7)post_thanks_box
  • (7)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (7)post_thanks_postbit_info
  • (7)postbit
  • (1)postbit_attachment
  • (6)postbit_onlinestatus
  • (7)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available:
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files:
  • ./showthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • forumjump
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • postbit_attachment
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • showthread_complete