DB error with 3.5.2

[ogden2k]

I have a custom hack that is an inline chatbox. After upgrading to the latest vB, guests get this error on the forum home:

<!--
Database error in vBulletin 3.5.2:
Invalid SQL:
SELECT userid, id, name, comment, date FROM chatbox
LEFT JOIN user ON (user.username=chatbox.name)
WHERE etat = 0 ORDER BY id DESC LIMIT;
MySQL Error : You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 3
Error Number : 1064
Date		 : Sunday, December 11th 2005 @ 01:51:44 PM
Script	 : http://www.thegrimescene.com/forums/
Referrer	 : http://www.thegrimescene.com/
IP Address : 68.171.28.68
Username	 : Unregistered
Classname	: vb_database
-->

Guests are not even allowed to see the CB or even call the CB. I have uninstalled and re-installed with now luck. This same hack works fine on another one of my boards, same vB and chat version.

[peterska2]

Does your chat require any file edits? If yes then you possibly have not re-edited the files when upgrading.

If no, then I suggest you contact your coder for support as we can't provide support for a custom mod as we don't know anything about it.

[ogden2k]

No, it doesn't require any file edits.

[peterska2]

You will need to contact the coder who wrote this mod for you then as you have said that it is a custom mod.

Unfortunately there is nothing that we can do here to help with custom works.

[ogden2k]

I don't think it's an issue with the mod as it works on another board with the same versions and skin.

[peterska2]

The fact that your error clearly states

Invalid SQL:
SELECT userid, id, name, comment, date FROM chatbox
LEFT JOIN user ON (user.username=chatbox.name)
WHERE etat = 0 ORDER BY id DESC LIMIT;

makes it pretty obvious to me that the problem lies with your chatbox mod.

[Chris M]

As I can see it, your query specifies "LIMIT" yet no value is assigned to it...

It's possible that a variable determining what the LIMIT is has not be added correctly...

It should be

PHP Code:

DESC LIMIT ' . $variable . '"); 


not

PHP Code:

DESC LIMIT '$variable'"); 


Chris

[ogden2k]

I have tried changing the query around a bit with no avail.

This is the plugin code:

PHP Code:

 $info_chatbox = $vbulletin->input->clean_gpc('r', 'info_chatbox', TYPE_STR);
// m?morise l'?tat de la chatbox si celui-ci ? chang?
if($vbulletin->GPC['info_chatbox'] != '' AND $vbulletin->GPC['info_chatbox'] != $vbulletin->userinfo['chatbox'])
{
$db->query_first("UPDATE " . TABLE_PREFIX . "user SET chatbox = " . intval($vbulletin->GPC['info_chatbox']) . " WHERE userid = " . $vbulletin->userinfo['userid']);
$vbulletin->userinfo['chatbox'] = $vbulletin->GPC['info_chatbox'];
}
// si chatbox ouverte
if (($vbulletin->userinfo['chatbox'] == 1 OR $vbulletin->userinfo['chatbox'] == 2) AND $vbulletin->options['chatbox_forumhome'] AND ($permissions['chatboxpermissions'] & $vbulletin->bf_ugp_chatboxpermissions['canusechatbox']))
{
$chatbox_refresh = $vbulletin->userinfo['chatbox'] == 1 ? 1 : 0;
eval('$chatbox .= "' . fetch_template('chatbox') . '";');
DEVDEBUG('Chatbox Template loaded');
} elseif ($vbulletin->userinfo['chatbox'] == 0){
require_once(DIR . '/includes/class_bbcode.php');
require_once(DIR . '/includes/functions_chatbox.php');
$result = $db->query_read("
SELECT userid, id, name, comment, date FROM " . TABLE_PREFIX . "chatbox
LEFT JOIN " . TABLE_PREFIX . "user ON (user.username=chatbox.name)
WHERE etat = 0 ORDER BY id DESC LIMIT $chatbox_perpage_reduite");
if(!$db->num_rows($result)){
eval('$chatbit = "' . fetch_template('chatbox_bit_vide') . '";');
DEVDEBUG('Chatbox Template vide loaded');
}else{
$compteur = 0;
while($get = $db->fetch_array($result)){
$colorirc = ($compteur++ % 2) ? "1" : "2";
$name = $get['name'];
$date = date('[d/m|H:i]', $get['date'] + $vbulletin->userinfo['timezoneoffset']);
$parser =& new vB_BbCodeParser($vbulletin, fetch_tag_list());
$comment = $parser->do_parse($get['comment']); 
if(substr($comment, 0, 3) == '/me'){
    $comment = substr($comment, 3);
    eval('$chatbit .= "' . fetch_template('chatbox_bit_me') . '";');
}else{
    eval('$chatbit .= "' . fetch_template('chatbox_bit') . '";');
}
}
}
eval('$chatbox .= "' . fetch_template('chatbox_fermee') . '";');
DEVDEBUG('Chatbox Template fermee loaded');
} 


This exact same code works fine on another board.

I figured out the issue, elseif ($vbulletin->userinfo['chatbox'] == 0){ changed to elseif ($vbulletin->userinfo['chatbox'] == 1){.